Skip to content

btrfs: some cleanups for extent-io-tree (mostly renames)

[email protected] linux-btrfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest16 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/16btrfs: remove extent_io_tree_to_inode() and is_inode_io_tree()fs/btrfs/extent-io-tree.c fs/btrfs/extent-io-tree.h+16 -401 reply
2/16btrfs: add btrfs prefix to trace events for extent state alloc and freefs/btrfs/extent-io-tree.c include/trace/events/btrfs.h+4 -40 replies
3/16btrfs: add btrfs prefix to main lock, try lock and unlock extent functionsfs/btrfs/compression.c fs/btrfs/defrag.c fs/btrfs/direct-io.c +13 more+152 -1530 replies
4/16btrfs: add btrfs prefix to dio lock and unlock extent functionsfs/btrfs/direct-io.c fs/btrfs/extent-io-tree.h+17 -170 replies
5/16btrfs: rename __lock_extent() and __try_lock_extent()fs/btrfs/extent-io-tree.c fs/btrfs/extent-io-tree.h fs/btrfs/inode.c+15 -150 replies
6/16btrfs: rename the functions to clear bits for an extent rangefs/btrfs/block-group.c fs/btrfs/defrag.c fs/btrfs/direct-io.c +16 more+112 -1080 replies
7/16btrfs: rename set_extent_bit() to include a btrfs prefixfs/btrfs/block-group.c fs/btrfs/defrag.c fs/btrfs/dev-replace.c +8 more+57 -560 replies
8/16btrfs: rename the functions to search for bits in extent rangesfs/btrfs/block-group.c fs/btrfs/dev-replace.c fs/btrfs/disk-io.c +9 more+59 -580 replies
9/16btrfs: rename the functions to get inode and fs_info from an extent io treefs/btrfs/extent-io-tree.c fs/btrfs/extent-io-tree.h include/trace/events/btrfs.h+13 -130 replies
10/16btrfs: directly grab inode at __btrfs_debug_check_extent_io_range()fs/btrfs/extent-io-tree.c+1 -20 replies
11/16btrfs: rename the functions to init and release an extent io treefs/btrfs/disk-io.c fs/btrfs/extent-io-tree.c fs/btrfs/extent-io-tree.h +7 more+33 -320 replies
12/16btrfs: rename the functions to count, test and get bit ranges in io treesfs/btrfs/defrag.c fs/btrfs/extent-io-tree.c fs/btrfs/extent-io-tree.h +4 more+38 -370 replies
13/16btrfs: rename free_extent_state() to include a btrfs prefixfs/btrfs/dev-replace.c fs/btrfs/disk-io.c fs/btrfs/extent-io-tree.c +6 more+28 -280 replies
14/16btrfs: rename remaining exported functions from extent-io-tree.hfs/btrfs/extent-io-tree.c fs/btrfs/extent-io-tree.h fs/btrfs/qgroup.c +2 more+37 -350 replies
15/16btrfs: remove double underscore prefix from __set_extent_bit()fs/btrfs/extent-io-tree.c+13 -150 replies
16/16btrfs: make btrfs_find_contiguous_extent_bit() return bool instead of intfs/btrfs/extent-io-tree.c fs/btrfs/extent-io-tree.h fs/btrfs/file-item.c+13 -100 replies

Reviews trailers per patch

None of the 16 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchDavid SterbaJohannes Thumshirn
SeriesR-b R-b
1/16
2/16
3/16
4/16
5/16
6/16
7/16
8/16
9/16
10/16
11/16
12/16
13/16
14/16
15/16
16/16

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/16] btrfs: some cleanups for extent-io-tree (mostly renames)

From: Filipe Manana <[email protected]>

These are mostly to rename exported functions so that they have a 'btrfs_' prefix and follow coding style, to avoid potential clashes in the future with other kernel functions defined elsewhere outside btrfs. As more functions are added to extent-io-tree.h, there's a tendency to follow the existing style and not add a 'btrfs_' prefix for consistency with the other function names, so as time passes we get more exported functions that don't follow the coding style by missing a 'btrfs_' prefix. I'm in the process of adding another new exported function to extent-io-tree.h and found my self unconfortable adding a 'btrfs_' prefix to it while the other exported functions don't have one.

I tried to split the rename into several and more reasonably sized patches to make it easier to review and also because a few do a bit more than simply renaming, but with notes in the change logs.

Filipe Manana (16):
btrfs: remove extent_io_tree_to_inode() and is_inode_io_tree()
btrfs: add btrfs prefix to trace events for extent state alloc and free
btrfs: add btrfs prefix to main lock, try lock and unlock extent functions
btrfs: add btrfs prefix to dio lock and unlock extent functions
btrfs: rename __lock_extent() and __try_lock_extent()
btrfs: rename the functions to clear bits for an extent range
btrfs: rename set_extent_bit() to include a btrfs prefix
btrfs: rename the functions to search for bits in extent ranges
btrfs: rename the functions to get inode and fs_info from an extent io tree
btrfs: directly grab inode at __btrfs_debug_check_extent_io_range()
btrfs: rename the functions to init and release an extent io tree
btrfs: rename the functions to count, test and get bit ranges in io trees
btrfs: rename free_extent_state() to include a btrfs prefix
btrfs: rename remaining exported functions from extent-io-tree.h
btrfs: remove double underscore prefix from __set_extent_bit()
btrfs: make btrfs_find_contiguous_extent_bit() return bool instead of int

 fs/btrfs/block-group.c           |  34 ++---
 fs/btrfs/compression.c           |   6 +-
 fs/btrfs/defrag.c                |  36 ++---
 fs/btrfs/dev-replace.c           |  12 +-
 fs/btrfs/direct-io.c             |  38 +++---
 fs/btrfs/disk-io.c               |  35 ++---
 fs/btrfs/extent-io-tree.c        | 218 ++++++++++++++-----------------
 fs/btrfs/extent-io-tree.h        | 155 +++++++++++-----------
 fs/btrfs/extent-tree.c           |  38 +++---
 fs/btrfs/extent_io.c             |  40 +++---
 fs/btrfs/extent_map.c            |   4 +-
 fs/btrfs/fiemap.c                |   6 +-
 fs/btrfs/file-item.c             |  22 ++--
 fs/btrfs/file.c                  |  87 ++++++------
 fs/btrfs/free-space-cache.c      |  36 ++---
 fs/btrfs/inode.c                 | 167 +++++++++++------------
 fs/btrfs/ioctl.c                 |   8 +-
 fs/btrfs/ordered-data.c          |   8 +-
 fs/btrfs/qgroup.c                |  30 +++--
 fs/btrfs/reflink.c               |  12 +-
 fs/btrfs/relocation.c            |  61 ++++-----
 fs/btrfs/super.c                 |   4 +-
 fs/btrfs/tests/btrfs-tests.c     |   4 +-
 fs/btrfs/tests/extent-io-tests.c |  54 ++++----
 fs/btrfs/tests/inode-tests.c     |  24 ++--
 fs/btrfs/transaction.c           |  34 ++---
 fs/btrfs/tree-log.c              |  12 +-
 fs/btrfs/volumes.c               |  28 ++--
 include/trace/events/btrfs.h     |  16 +--
 29 files changed, 607 insertions(+), 622 deletions(-)
Signature · 1 line
2.45.2