Skip to content

objtool: Fix INSN_CONTEXT_SWITCH

Josh Poimboeuf lkml 1 version Applied

Status from this message: The following commit has been merged into the objtool/urgent branch of tip:

Get series with b4
b4 am [email protected]

Versions newest first

  1. v4 Latest4 patches 3 repliesApplied

Changes in v4 from the cover letter

- split up patches
- don't get rid of "unsupported instruction in callable function" warning
- split INSN_CONTEXT_SWITCH -> INSN_SYSCALL / INSN_SYSRET

Patches in v4 Applied

#Subject and filesSizeRepliesApplied
1/4objtool: Fix INSN_CONTEXT_SWITCH handling in validate_unret()tools/objtool/check.c+5 -00 replies
2/4objtool: Split INSN_CONTEXT_SWITCH into INSN_SYSCALL and INSN_SYSRETtools/objtool/arch/x86/decode.c tools/objtool/check.c tools/objtool/include/objtool/arch.h+17 -100 replies
3/4objtool: Stop UNRET validation on UD2tools/objtool/check.c+3 -00 replies
4/4objtool, xen: Fix INSN_SYSCALL / INSN_SYSRET semanticsarch/x86/xen/xen-asm.S tools/objtool/check.c+15 -120 replies

Reviews trailers per patch

None of the 4 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchPeter Zijlstra (Intel)
SeriesA-b
1/4
2/4
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/4] objtool: Fix INSN_CONTEXT_SWITCH

I decided to keep the "unsupported instruction in callable function" warning, it's not hurting anything. As a result we now have INSN_SYSCALL and INSN_SYSRET.

v4:
- split up patches
- don't get rid of "unsupported instruction in callable function" warning
- split INSN_CONTEXT_SWITCH -> INSN_SYSCALL / INSN_SYSRET

v3: https://lore.kernel.org/9b23e4413873bee38961e628b0c73f6d3a26d494.1743799705.git.jpoimboe@kernel.org

Josh Poimboeuf (4):
objtool: Fix INSN_CONTEXT_SWITCH handling in validate_unret()
objtool: Split INSN_CONTEXT_SWITCH into INSN_SYSCALL and INSN_SYSRET
objtool: Stop UNRET validation on UD2
objtool, xen: Fix INSN_SYSCALL / INSN_SYSRET semantics

 arch/x86/xen/xen-asm.S               |  4 +---
 tools/objtool/arch/x86/decode.c      | 18 ++++++++++-------
 tools/objtool/check.c                | 29 +++++++++++++++++++++-------
 tools/objtool/include/objtool/arch.h |  3 ++-
 4 files changed, 36 insertions(+), 18 deletions(-)
Signature · 1 line
2.49.0