Skip to content

Improve code readability in rtl8723bs module

Erick Karanja linux-staging lkml outreachy 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 0 repliesNew
  2. v22 patches 7 repliesSuperseded

Changes in v3 from the cover letter

Avoid refactoring the code in instances where comments are left dangling and in instances where refactoring introduces a checkpatch warning "line exceeds 100 columns"

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2staging: rtl8723bs: Initialize variables at declaration in rtl8723bs_xmit.cdrivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c+9 -240 replies
2/2staging: rtl8723bs: Initialize variables at declaration in rtl8723b_hal_init.cdrivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c+24 -570 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/2] Improve code readability in rtl8723bs module

The patchset aims at improving code readability by initializing variables at declaration.Key consideration is made to ensure that the code is clean, maintainable and easy to debug.

Changes since v2:
Avoid refactoring the code in instances where comments are left dangling and in instances where refactoring introduces a checkpatch warning "line exceeds 100 columns"

Changes since v1:
Avoid mixing pre-initialized variables with not-initialized variables and handle an edge case where initialization is made to function call.

Erick Karanja (2):
staging: rtl8723bs: Initialize variables at declaration in

    rtl8723bs_xmit.c
  staging: rtl8723bs: Initialize variables at declaration in
    rtl8723b_hal_init.c
 .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 81 ++++++-------------
 .../staging/rtl8723bs/hal/rtl8723bs_xmit.c    | 33 +++-----
 2 files changed, 33 insertions(+), 81 deletions(-)
Signature · 1 line
2.43.0