Rust abstractions for clk, cpumask, cpufreq, OPP
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v12 Latest15 patches 16 repliesIn review
- v1115 patches 17 repliesApplied
- v1015 patches 16 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v9 | 17 patches | 13 replies | Superseded |
Changes in v12 from the cover letter
- Added tags from Yury.
- Use "'static" for CStr in cpufreq-dt driver.
- Move clk code in a new module "common_clk" to fix build errors in the absence of CONFIG_COMMON_CLK (x86 for example).
- Use #[cfg(CONFIG_COMMON_CLK)] at few more places for Clk usage.
- Use Device<Bound>.
- Update prototype of update_limits_callback() (sync with PM tree).
Patches in v12 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/15 | rust: cpumask: Add few more helpersrust/ | +25 | 0 replies | |
| 2/15 | rust: cpumask: Add initial abstractionsrust/ rust/ | +331 | 0 replies | |
| 3/15 | MAINTAINERS: Add entry for Rust cpumask APIMAINTAINERS | +6 | 0 replies | |
| 4/15 | rust: clk: Add helpers for Rust codeMAINTAINERS rust/ rust/ +1 more | +69 | 0 replies | |
| 5/15 | rust: clk: Add initial abstractionsMAINTAINERS rust/ rust/ | +336 | 0 replies | |
| 6/15 | rust: macros: enable use of hyphens in module namesrust/ | +12 | 6 replies | |
| 7/15 | rust: cpu: Add from_cpu()MAINTAINERS rust/ rust/ +1 more | +33 | 0 replies | |
| 8/15 | rust: opp: Add initial abstractions for OPP frameworkMAINTAINERS rust/ rust/ +1 more | +303 | 0 replies | |
| 9/15 | rust: opp: Add abstractions for the OPP tablerust/ | +486 | 0 replies | |
| 10/15 | rust: opp: Add abstractions for the configuration optionsrust/ | +293 | 0 replies | |
| 11/15 | rust: cpufreq: Add initial abstractions for cpufreq frameworkMAINTAINERS rust/ rust/ +3 more | +379 | 0 replies | |
| 12/15 | rust: cpufreq: Extend abstractions for policy and driver opsrust/ | +461 | 0 replies | |
| 13/15 | rust: cpufreq: Extend abstractions for driver registrationrust/ | +490 | 4 replies | |
| 14/15 | rust: opp: Extend OPP abstractions with cpufreq supportrust/ | +70 | 0 replies | |
| 15/15 | cpufreq: Add Rust-based cpufreq-dt driverdrivers/ drivers/ drivers/ | +242 | 0 replies |
Reviews trailers per patch
7 of 15 patches have a Reviewed-by or Acked-by.
| Patch | Yury Norov [NVIDIA] | Daniel Almeida | Alice Ryhl | Danilo Krummrich | Benno Lossin |
|---|---|---|---|---|---|
| 1/15 | A-b | ||||
| 2/15 | R-b | ||||
| 3/15 | R-b | ||||
| 4/15 | R-b | ||||
| 5/15 | T-b R-b | ||||
| 6/15 | R-b | R-b | |||
| 7/15 | |||||
| 8/15 | |||||
| 9/15 | |||||
| 10/15 | |||||
| 11/15 | |||||
| 12/15 | |||||
| 13/15 | R-b | ||||
| 14/15 | |||||
| 15/15 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.
Cover letter [PATCH V12 00/15] Rust abstractions for clk, cpumask, cpufreq, OPP
Hello,
I have queued this up for v6.16-rc1, will merge it via the PM tree soon. Thanks.
This series introduces initial Rust abstractions for a few subsystems: clk, cpumask, cpufreq and Operating Performance Points (OPP).
The abstractions cover most of the interfaces exposed by cpufreq and OPP subsystems. It also includes minimal abstractions for the clk and cpumask frameworks, which are required by the cpufreq / OPP abstractions.
Additionally, a sample rcpufreq-dt driver is included. This is a duplicate of the existing cpufreq-dt driver, which is a platform-agnostic, device-tree based cpufreq driver commonly used on ARM platforms.
The implementation has been tested using QEMU, ensuring that frequency transitions, various configurations, and driver binding/unbinding work as expected. However, performance measurements have not been conducted yet.
For those interested in testing these patches, they can be found at:
git://git.kernel.org/pub/scm/linux/kernel/git/vireshk/pm.git rust/cpufreq-dt
Based on 6.15-rc1 + rust/devres dependencies + PM/cpufreq dependencies.
V11->V12:
- Added tags from Yury.
- Use "'static" for CStr in cpufreq-dt driver.
- Move clk code in a new module "common_clk" to fix build errors in the absence of CONFIG_COMMON_CLK (x86 for example).
- Use #[cfg(CONFIG_COMMON_CLK)] at few more places for Clk usage.
- Use Device<Bound>.
- Update prototype of update_limits_callback() (sync with PM tree).
V10->V11:
- cpufreq: Add TableIndex and make table methods safe.
- opp: Add freq module to keep all cfg stuff together.
- Use /// instead of // for documentation comments, even for private definitions.
- Switch back to heap allocation for struct cpufreq_driver as it needs to be a mutable object.
- Remove allow(dead_code)
- Improve few safety comments.
- Danilo: I haven't added your RBY tag to patch 13/15 as there were significant changes from the initial version.
V9->V10:
- Don't remove atomic cpumask bindings from rust/helpers/cpumask.c
- Rename from_raw/from_raw_mut to as_ref/as_mut_ref (cpumask).
- Improved comments for non-atomic methods (cpumask).
- s/new/new_zero/ and s/new_uninit/new/ (cpumask).
- Avoid using explicit casts as *const or as *mut.
- Renamed cpumask_box to cpumask_var and cpus.
- Add local types in Rust for cpufreq flags that use BIT().
- Add const initializer for cpufreq::Registration and simplify new().
- Improved few safety comments.
V8->V9:
- clk (changes since V4):
- V4: https://lore.kernel.org/all/[email protected]/
- Add more methods in Hertz (as_khz/mhz/ghz).
- Reword a comment.
- cpumask (changes since V4):
- V4: https://lore.kernel.org/all/[email protected]/
- Add support for cpumask_{test_cpu|empty|full} and switch to using non-atomic helpers for set/clear.
- s/CpumaskBox/CpumaskVar/
- s/set_all/setall/
- Improved examples, comments and commit logs.
- cpufreq/opp:
- V8: https://lore.kernel.org/all/[email protected]/
- Based on review comments received for clk/cpumask, a lot of changes were made to cpufreq/opp bindings in code, comments, examples, etc..
- attr fields were dropped from cpufreq support, not required anymore because of latest changes in cpufreq core.
- Use Hertz/MicroVolt/MicroWatt as units.
- Lots of other cleanups.
- Dropped Reviewed-by from Manos (there were too many changes).
V7->V8:
- Updated cpumask bindings to work with !CONFIG_CPUMASK_OFFSTACK case.
- Dropped few patches (property_present() and opp helpers), as they are already merged.
- from_cpu() is marked unsafe.
- Included a patch by Anisse Astier, to solve a long standing issue with this series.
- Dropped: "DO-NOT_MERGE: cpufreq: Rename cpufreq-dt platdev."
- Updated MAINTAINERS for new files.
- Other minor changes / cleanups.
V6->V7:
- from_cpu() is moved to cpu.rs and doesn't return ARef anymore, but just a reference.
- Dropped cpufreq_table_len() and related validation in cpufreq core.
- Solved the issue with BIT() macro differently, using an enum now.
- Few patches are broken into smaller / independent patches.
- Improved Commit logs and SAFETY comments at few places.
- Removed print message from cpufreq driver.
- Rebased over linux-next/master.
- Few other minor changes.
V5->V6:
- Rebase over latest rust/dev branch, which changed few interfaces that the patches were using.
- Included all other patches, which weren't included until now to focus only on core APIs.
- Other minor cleanups, additions.
V4->V5:
- Rename Registration::register() as new().
- Provide a new API: Registration::new_foreign_owned() and use it for rcpufreq_dt driver.
- Update MAINTAINERS file.
V3->V4:
- Fix bugs with freeing of OPP structure. Dropped the Drop routine and fixed reference counting.
- Registration object of the cpufreq core is modified a bit to remove the registered field, and few other cleanups.
- Use Devres for instead of platform data.
- Improve SAFETY comments.
V2->V3:
- Rebased on latest rust-device changes, which removed Data and so few changes were required to make it work.
- use srctree links (Alice Ryhl).
- Various changes the OPP creation APIs, new APIs: from_raw_opp() and from_raw_opp_owned() (Alice Ryhl).
- Inline as_raw() helpers (Alice Ryhl).
- Add new interface (OPP::Token) for dynamically created OPPs.
- Add Reviewed-by tag from Manos.
- Modified/simplified cpufreq registration structure / method a bit.
V1->V2:
- Create and use separate bindings for OF, clk, cpumask, etc (not included in this patchset but pushed to the above branch). This helped removing direct calls from the driver.
- Fix wrong usage of Pinning + Vec.
- Use Token for OPP Config.
- Use Opaque, transparent and Aref for few structures.
- Broken down into smaller patches to make it easy for reviewers.
- Based over staging/rust-device.
--
Viresh
Anisse Astier (1):
rust: macros: enable use of hyphens in module names
Viresh Kumar (14):
rust: cpumask: Add few more helpers
rust: cpumask: Add initial abstractions
MAINTAINERS: Add entry for Rust cpumask API
rust: clk: Add helpers for Rust code
rust: clk: Add initial abstractions
rust: cpu: Add from_cpu()
rust: opp: Add initial abstractions for OPP framework
rust: opp: Add abstractions for the OPP table
rust: opp: Add abstractions for the configuration options
rust: cpufreq: Add initial abstractions for cpufreq framework
rust: cpufreq: Extend abstractions for policy and driver ops
rust: cpufreq: Extend abstractions for driver registration
rust: opp: Extend OPP abstractions with cpufreq support
cpufreq: Add Rust-based cpufreq-dt driver
MAINTAINERS | 11 + drivers/cpufreq/Kconfig | 12 + drivers/cpufreq/Makefile | 1 + drivers/cpufreq/rcpufreq_dt.rs | 229 ++++++ rust/bindings/bindings_helper.h | 4 + rust/helpers/clk.c | 66 ++ rust/helpers/cpufreq.c | 10 + rust/helpers/cpumask.c | 25 + rust/helpers/helpers.c | 2 + rust/kernel/clk.rs | 334 ++++++++ rust/kernel/cpu.rs | 30 + rust/kernel/cpufreq.rs | 1310 +++++++++++++++++++++++++++++++ rust/kernel/cpumask.rs | 330 ++++++++ rust/kernel/lib.rs | 7 + rust/kernel/opp.rs | 1145 +++++++++++++++++++++++++++ rust/macros/module.rs | 20 +- 16 files changed, 3528 insertions(+), 8 deletions(-) create mode 100644 drivers/cpufreq/rcpufreq_dt.rs create mode 100644 rust/helpers/clk.c create mode 100644 rust/helpers/cpufreq.c create mode 100644 rust/kernel/clk.rs create mode 100644 rust/kernel/cpu.rs create mode 100644 rust/kernel/cpufreq.rs create mode 100644 rust/kernel/cpumask.rs create mode 100644 rust/kernel/opp.rs
Signature · 1 line
2.31.1.272.g89b43f80a514