Follow-up to RGMII mode clarification: am65-cpsw fix + checkpatch
Status from this message: This series was applied to netdev/net-next.git (main)
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest3 patches 10 repliesApplied 3/3
- v14 patches 42 repliesSuperseded
Changes in v2 from the cover letter
- Previous patch 1/4 has been dropped, has it has been replaced by [2]
- Patches 1/3, 2/3: collected review and ack tags
- Patch 3/3:
- Fixed multiple typos noted during review
- Extended to check .dtso in addition to .dts and .dtsi
- Changed CHK() to WARN(), so the warning triggers without --strict
[1] https://lore.kernel.org/lkml/[email protected]/
[2] https://lore.kernel.org/all/[email protected]/
commit c360eb0c3ccb ("dt-bindings: net: ethernet-controller: Add informative text about RGMII delays")
Patch series v1: https://lore.kernel.org/all/[email protected]/
Patches in v2 All 3 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | dt-bindings: net: ti: k3-am654-cpsw-nuss: update phy-mode in exampleDocumentation/ | +1 | 1 reply | Applied |
| 2/3 | net: ethernet: ti: am65-cpsw: fixup PHY mode for fixed RGMII TX delaydrivers/ | +25 | 6 replies | Applied |
| 3/3 | checkpatch: check for comment explaining rgmii(|-rxid|-txid) PHY modesDocumentation/ scripts/ | +21 | 3 replies | Applied |
Reviews trailers per patch
All 3 patches have a Reviewed-by or Acked-by.
| Patch | Maxime Chevallier | Andrew Lunn | Rob Herring (Arm) | Siddharth Vadapalli |
|---|---|---|---|---|
| 1/3 | R-b | R-b | A-b | R-b |
| 2/3 | R-b | R-b | R-b | |
| 3/3 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.
Cover letter [PATCH net-next v2 0/3] Follow-up to RGMII mode clarification: am65-cpsw fix + checkpatch
Following previous discussion [1] and the documentation update by Andrew [2]:
Fix up the mode to account for the fixed TX delay on the AM65 CPSW Ethernet controllers, similar to the way the icssg-prueth does it. For backwards compatibility, the "impossible" modes that claim to have a delay on the PCB are still accepted, but trigger a warning message.
As Andrew suggested, I have also added a checkpatch check that requires a comment for any RGMII mode that is not "rgmii-id".
No Device Trees are updated to avoid the warning for now, to give other projects syncing the Linux Device Trees some time to fix their drivers as well. I intend to submit an equivalent change for U-Boot's am65-cpsw-nuss driver as soon as the changes are accepted for Linux.
Changelog v2:
- Previous patch 1/4 has been dropped, has it has been replaced by [2]
- Patches 1/3, 2/3: collected review and ack tags
- Patch 3/3:
- Fixed multiple typos noted during review
- Extended to check .dtso in addition to .dts and .dtsi
- Changed CHK() to WARN(), so the warning triggers without --strict
[1] https://lore.kernel.org/lkml/[email protected]/
[2] https://lore.kernel.org/all/[email protected]/
commit c360eb0c3ccb ("dt-bindings: net: ethernet-controller: Add informative text about RGMII delays")
Patch series v1: https://lore.kernel.org/all/[email protected]/
Matthias Schiffer (3):
dt-bindings: net: ti: k3-am654-cpsw-nuss: update phy-mode in example
net: ethernet: ti: am65-cpsw: fixup PHY mode for fixed RGMII TX delay
checkpatch: check for comment explaining rgmii(|-rxid|-txid) PHY modes
Documentation/dev-tools/checkpatch.rst | 9 +++++++ .../bindings/net/ti,k3-am654-cpsw-nuss.yaml | 2 +- drivers/net/ethernet/ti/am65-cpsw-nuss.c | 27 +++++++++++++++++-- scripts/checkpatch.pl | 12 +++++++++ 4 files changed, 47 insertions(+), 3 deletions(-)
Signature · 4 lines
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht München, HRB 105018 Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider https://www.tq-group.com/