Skip to content

crypto: shash - Handle partial blocks in API

Herbert Xu linux-crypto oe-kbuild-all 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest67 patches 1 replyIn review
  2. v167 patches 1 replySuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/67crypto: shash - Handle partial blocks in APIcrypto/shash.c include/crypto/hash.h include/crypto/internal/hash.h +1 more+271 -790 replies
2/67crypto: blake2b-generic - Use API partial block handlingcrypto/blake2b_generic.c include/crypto/blake2b.h include/crypto/internal/blake2b.h+80 -350 replies
3/67crypto: arm/blake2b - Use API partial block handlingarch/arm/crypto/blake2b-neon-glue.c include/crypto/blake2b.h include/crypto/internal/blake2b.h+19 -840 replies
4/67crypto: ghash-generic - Use API partial block handlingcrypto/ghash-generic.c include/crypto/ghash.h+19 -400 replies
5/67crypto: powerpc/ghash - Use API partial block handlingarch/powerpc/crypto/ghash.c+28 -530 replies
6/67crypto: arm/ghash - Use API partial block handlingarch/arm/crypto/ghash-ce-glue.c+50 -600 replies
7/67crypto: arm64/ghash - Use API partial block handlingarch/arm64/crypto/ghash-ce-glue.c+60 -910 replies
8/67crypto: riscv/ghash - Use API partial block handlingarch/riscv/crypto/ghash-riscv64-glue.c include/crypto/ghash.h+18 -410 replies
9/67crypto: s390/ghash - Use API partial block handlingarch/s390/crypto/ghash_s390.c+50 -600 replies
10/67crypto: x86/ghash - Use API partial block handlingarch/x86/crypto/ghash-clmulni-intel_asm.S arch/x86/crypto/ghash-clmulni-intel_glue.c+43 -2630 replies
11/67crypto: md5-generic - Use API partial block handlingcrypto/md5.c include/crypto/md5.h+40 -650 replies
12/67crypto: mips/octeon-md5 - Use API partial block handlingarch/mips/cavium-octeon/crypto/octeon-md5.c+63 -560 replies
13/67crypto: powerpc/md5 - Use API partial block handlingarch/powerpc/crypto/md5-glue.c+20 -790 replies
14/67crypto: sparc/md5 - Use API partial block handlingarch/sparc/crypto/md5_glue.c+63 -780 replies
15/67crypto: x86/sha1 - Use API partial block handlingarch/x86/crypto/sha1_ssse3_glue.c include/crypto/sha1.h include/crypto/sha1_base.h+64 -600 replies
16/67crypto: arm64/sha1 - Use API partial block handlingarch/arm64/crypto/sha1-ce-glue.c+17 -490 replies
17/67crypto: mips/octeon-sha1 - Use API partial block handlingarch/mips/cavium-octeon/crypto/octeon-sha1.c+30 -1060 replies
18/67crypto: sha1-generic - Use API partial block handlingcrypto/sha1_generic.c include/crypto/sha1.h+12 -290 replies
19/67crypto: arm/sha1-ce - Use API partial block handlingarch/arm/crypto/sha1-ce-glue.c+8 -280 replies
20/67crypto: arm/sha1-neon - Use API partial block handlingarch/arm/crypto/sha1_neon_glue.c+10 -290 replies
21/67crypto: arm/sha1-asm - Use API partial block handlingarch/arm/crypto/sha1.h arch/arm/crypto/sha1_glue.c+11 -360 replies
22/67crypto: powerpc/sha1 - Use API partial block handlingarch/powerpc/crypto/sha1.c+20 -810 replies
23/67crypto: powerpc/sha1-spe - Use API partial block handlingarch/powerpc/crypto/sha1-spe-glue.c+24 -1080 replies
24/67crypto: s390/sha1 - Use API partial block handlingarch/s390/crypto/sha.h arch/s390/crypto/sha1_s390.c arch/s390/crypto/sha_common.c+93 -160 replies
25/67crypto: sparc/sha1 - Use API partial block handlingarch/sparc/crypto/sha1_glue.c+15 -940 replies
26/67crypto: sha1_base - Remove partial block helpersinclude/crypto/sha1_base.h+0 -610 replies
27/67crypto: x86/sha256 - Use API partial block handlingarch/x86/crypto/sha256_ssse3_glue.c include/crypto/sha2.h include/crypto/sha256_base.h+118 -731 reply
28/67crypto: mips/octeon-sha256 - Use API partial block handlingarch/mips/cavium-octeon/crypto/octeon-sha256.c+37 -1240 replies
29/67crypto: riscv/sha256 - Use API partial block handlingarch/riscv/crypto/sha256-riscv64-glue.c include/crypto/sha256_base.h lib/crypto/sha256.c+44 -450 replies
30/67crypto: sha256-generic - Use API partial block handlingcrypto/sha256_generic.c include/crypto/sha2.h+21 -350 replies
31/67crypto: arm/sha256-ce - Use API partial block handlingarch/arm/crypto/sha2-ce-glue.c+15 -370 replies
32/67crypto: arm/sha256-neon - Use API partial block handlingarch/arm/crypto/sha256_neon_glue.c+16 -330 replies
33/67crypto: arm/sha256-asm - Use API partial block handlingarch/arm/crypto/sha256_glue.c arch/arm/crypto/sha256_glue.h+19 -350 replies
34/67crypto: arm64/sha256-ce - Use API partial block handlingarch/arm64/crypto/sha2-ce-glue.c+18 -720 replies
35/67crypto: arm64/sha256 - Use API partial block handlingarch/arm64/crypto/sha256-glue.c+37 -600 replies
36/67crypto: powerpc/sha256-spe - Use API partial block handlingarch/powerpc/crypto/sha256-spe-glue.c+30 -1370 replies
37/67crypto: s390/sha256 - Use API partial block handlingarch/s390/crypto/sha256_s390.c+18 -170 replies
38/67crypto: sparc/sha256 - Use API partial block handlingarch/sparc/crypto/sha256_glue.c+20 -1010 replies
39/67crypto: sha256_base - Remove partial block helpersarch/x86/crypto/sha256_ssse3_glue.c include/crypto/sha256_base.h lib/crypto/sha256.c+17 -480 replies
40/67crypto: arm64/sha3-ce - Use API partial block handlingarch/arm64/crypto/sha3-ce-glue.c arch/s390/crypto/sha.h include/crypto/sha3.h+49 -630 replies
41/67crypto: s390/sha3 - Use API partial block handlingarch/s390/crypto/sha3_256_s390.c arch/s390/crypto/sha3_512_s390.c arch/s390/crypto/sha_common.c+56 -750 replies
42/67crypto: sha3-generic - Use API partial block handlingcrypto/sha3_generic.c include/crypto/sha3.h+47 -610 replies
43/67crypto: zynqmp-sha - Use API partial block handlingdrivers/crypto/xilinx/zynqmp-sha.c include/crypto/sha3.h+22 -540 replies
44/67crypto: x86/sha512 - Use API partial block handlingarch/x86/crypto/sha512_ssse3_glue.c include/crypto/sha2.h include/crypto/sha512_base.h+77 -570 replies
45/67crypto: mips/octeon-sha512 - Use API partial block handlingarch/mips/cavium-octeon/crypto/octeon-sha512.c+42 -1130 replies
46/67crypto: riscv/sha512 - Use API partial block handlingarch/riscv/crypto/sha512-riscv64-glue.c crypto/sha512_generic.c include/crypto/sha512_base.h+28 -300 replies
47/67crypto: sha512-generic - Use API partial block handlingcrypto/sha512_generic.c include/crypto/sha2.h+17 -360 replies
48/67crypto: arm/sha512-neon - Use API partial block handlingarch/arm/crypto/sha512-neon-glue.c+13 -300 replies
49/67crypto: arm/sha512-asm - Use API partial block handlingarch/arm/crypto/sha512-glue.c arch/arm/crypto/sha512.h+16 -260 replies
50/67crypto: arm64/sha512-ce - Use API partial block handlingarch/arm64/crypto/sha512-ce-glue.c+12 -370 replies
51/67crypto: arm/sha512 - Use API partial block handlingarch/arm64/crypto/sha512-glue.c+11 -170 replies
52/67crypto: s390/sha512 - Use API partial block handlingarch/s390/crypto/sha.h arch/s390/crypto/sha512_s390.c arch/s390/crypto/sha_common.c+47 -1360 replies
53/67crypto: sparc/sha512 - Use API partial block handlingarch/sparc/crypto/sha512_glue.c+15 -870 replies
54/67crypto: sha512_base - Remove partial block helpersinclude/crypto/sha512_base.h+0 -640 replies
55/67crypto: sm3-generic - Use API partial block handlingcrypto/sm3_generic.c include/crypto/sm3.h include/crypto/sm3_base.h+52 -250 replies
56/67crypto: arm64/sm3-ce - Use API partial block handlingarch/arm64/crypto/sm3-ce-glue.c+8 -400 replies
57/67crypto: arm64/sm3-neon - Use API partial block handlingarch/arm64/crypto/sm3-neon-glue.c+8 -400 replies
58/67crypto: riscv/sm3 - Use API partial block handlingarch/riscv/crypto/sm3-riscv64-glue.c+17 -320 replies
59/67crypto: x86/sm3 - Use API partial block handlingarch/x86/crypto/sm3_avx_glue.c+10 -440 replies
60/67crypto: lib/sm3 - Remove partial block helpersinclude/crypto/sm3.h include/crypto/sm3_base.h lib/crypto/sm3.c+6 -1280 replies
61/67crypto: cbcmac - Use API partial block handlingcrypto/ccm.c+24 -350 replies
62/67crypto: cmac - Use API partial block handlingcrypto/cmac.c+18 -740 replies
63/67crypto: xcbc - Use API partial block handlingcrypto/xcbc.c+18 -740 replies
64/67crypto: arm64/aes - Use API partial block handlingarch/arm64/crypto/aes-glue.c+41 -810 replies
65/67crypto: arm64/sm4 - Use API partial block handlingarch/arm64/crypto/sm4-ce-glue.c+31 -670 replies
66/67crypto: nx - Use API partial block handlingdrivers/crypto/nx/nx-aes-xcbc.c drivers/crypto/nx/nx-sha256.c drivers/crypto/nx/nx-sha512.c +2 more+161 -2610 replies
67/67crypto: padlock-sha - Use API partial block handlingdrivers/crypto/padlock-sha.c+138 -3260 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [v2 PATCH 00/67] crypto: shash - Handle partial blocks in API

v2 rebases on top of cryptodev.

Most hash algorithms are block-based and data is held back until a whole block can be fed into the algorithm. Currently, this retention is entirely handled in the low-level algorithm code, with the API and the user oblivious to it.

As a comparison, the block ciphers defer this retention entirely to the user and the API, who is expected to provide input with no partial data until the very end.

The result of this is that every shash algorithm has to implement partial block handling, and it gets many times worse when you look at ahash drivers.

This patch series adds optional handling of partial blocks to the shash API and converts some of the shash algorithms to it. In particular, all the algorithms used by ahash drivers have been converted. This ensures that when the ahash drivers themselves are converted the export format will be consistent.

As this touches so many shash algorithms, two extra changes have been made at the same time: removal of SIMD fallback paths on arm/arm64/x86 and exporting in the same format as that of the generic algorithm.

Herbert Xu (67):
crypto: shash - Handle partial blocks in API
crypto: blake2b-generic - Use API partial block handling
crypto: arm/blake2b - Use API partial block handling
crypto: ghash-generic - Use API partial block handling
crypto: powerpc/ghash - Use API partial block handling
crypto: arm/ghash - Use API partial block handling
crypto: arm64/ghash - Use API partial block handling
crypto: riscv/ghash - Use API partial block handling
crypto: s390/ghash - Use API partial block handling
crypto: x86/ghash - Use API partial block handling
crypto: md5-generic - Use API partial block handling
crypto: mips/octeon-md5 - Use API partial block handling
crypto: powerpc/md5 - Use API partial block handling
crypto: sparc/md5 - Use API partial block handling
crypto: x86/sha1 - Use API partial block handling
crypto: arm64/sha1 - Use API partial block handling
crypto: mips/octeon-sha1 - Use API partial block handling
crypto: sha1-generic - Use API partial block handling
crypto: arm/sha1-ce - Use API partial block handling
crypto: arm/sha1-neon - Use API partial block handling
crypto: arm/sha1-asm - Use API partial block handling
crypto: powerpc/sha1 - Use API partial block handling
crypto: powerpc/sha1-spe - Use API partial block handling
crypto: s390/sha1 - Use API partial block handling
crypto: sparc/sha1 - Use API partial block handling
crypto: sha1_base - Remove partial block helpers
crypto: x86/sha256 - Use API partial block handling
crypto: mips/octeon-sha256 - Use API partial block handling
crypto: riscv/sha256 - Use API partial block handling
crypto: sha256-generic - Use API partial block handling
crypto: arm/sha256-ce - Use API partial block handling
crypto: arm/sha256-neon - Use API partial block handling
crypto: arm/sha256-asm - Use API partial block handling
crypto: arm64/sha256-ce - Use API partial block handling
crypto: arm64/sha256 - Use API partial block handling
crypto: powerpc/sha256-spe - Use API partial block handling
crypto: s390/sha256 - Use API partial block handling
crypto: sparc/sha256 - Use API partial block handling
crypto: sha256_base - Remove partial block helpers
crypto: arm64/sha3-ce - Use API partial block handling
crypto: s390/sha3 - Use API partial block handling
crypto: sha3-generic - Use API partial block handling
crypto: zynqmp-sha - Use API partial block handling
crypto: x86/sha512 - Use API partial block handling
crypto: mips/octeon-sha512 - Use API partial block handling
crypto: riscv/sha512 - Use API partial block handling
crypto: sha512-generic - Use API partial block handling
crypto: arm/sha512-neon - Use API partial block handling
crypto: arm/sha512-asm - Use API partial block handling
crypto: arm64/sha512-ce - Use API partial block handling
crypto: arm/sha512 - Use API partial block handling
crypto: s390/sha512 - Use API partial block handling
crypto: sparc/sha512 - Use API partial block handling
crypto: sha512_base - Remove partial block helpers
crypto: sm3-generic - Use API partial block handling
crypto: arm64/sm3-ce - Use API partial block handling
crypto: arm64/sm3-neon - Use API partial block handling
crypto: riscv/sm3 - Use API partial block handling
crypto: x86/sm3 - Use API partial block handling
crypto: lib/sm3 - Remove partial block helpers
crypto: cbcmac - Use API partial block handling
crypto: cmac - Use API partial block handling
crypto: xcbc - Use API partial block handling
crypto: arm64/aes - Use API partial block handling
crypto: arm64/sm4 - Use API partial block handling
crypto: nx - Use API partial block handling
crypto: padlock-sha - Use API partial block handling

 arch/arm/crypto/blake2b-neon-glue.c           |  20 +-
 arch/arm/crypto/ghash-ce-glue.c               | 110 ++---
 arch/arm/crypto/sha1-ce-glue.c                |  36 +-
 arch/arm/crypto/sha1.h                        |  14 -
 arch/arm/crypto/sha1_glue.c                   |  33 +-
 arch/arm/crypto/sha1_neon_glue.c              |  39 +-
 arch/arm/crypto/sha2-ce-glue.c                |  52 +-
 arch/arm/crypto/sha256_glue.c                 |  46 +-
 arch/arm/crypto/sha256_glue.h                 |   8 +-
 arch/arm/crypto/sha256_neon_glue.c            |  49 +-
 arch/arm/crypto/sha512-glue.c                 |  36 +-
 arch/arm/crypto/sha512-neon-glue.c            |  43 +-
 arch/arm/crypto/sha512.h                      |   6 -
 arch/arm64/crypto/aes-glue.c                  | 122 ++---
 arch/arm64/crypto/ghash-ce-glue.c             | 151 +++---
 arch/arm64/crypto/sha1-ce-glue.c              |  66 +--
 arch/arm64/crypto/sha2-ce-glue.c              |  90 +---
 arch/arm64/crypto/sha256-glue.c               |  97 ++--
 arch/arm64/crypto/sha3-ce-glue.c              | 107 ++--
 arch/arm64/crypto/sha512-ce-glue.c            |  49 +-
 arch/arm64/crypto/sha512-glue.c               |  28 +-
 arch/arm64/crypto/sm3-ce-glue.c               |  48 +-
 arch/arm64/crypto/sm3-neon-glue.c             |  48 +-
 arch/arm64/crypto/sm4-ce-glue.c               |  98 ++--
 arch/mips/cavium-octeon/crypto/octeon-md5.c   | 119 ++---
 arch/mips/cavium-octeon/crypto/octeon-sha1.c  | 136 ++---
 .../mips/cavium-octeon/crypto/octeon-sha256.c | 161 ++----
 .../mips/cavium-octeon/crypto/octeon-sha512.c | 155 ++----
 arch/powerpc/crypto/ghash.c                   |  81 ++-
 arch/powerpc/crypto/md5-glue.c                |  99 +---
 arch/powerpc/crypto/sha1-spe-glue.c           | 132 +----
 arch/powerpc/crypto/sha1.c                    | 101 +---
 arch/powerpc/crypto/sha256-spe-glue.c         | 167 ++-----
 arch/riscv/crypto/ghash-riscv64-glue.c        |  58 +--
 arch/riscv/crypto/sha256-riscv64-glue.c       |  68 ++-
 arch/riscv/crypto/sha512-riscv64-glue.c       |  47 +-
 arch/riscv/crypto/sm3-riscv64-glue.c          |  49 +-
 arch/s390/crypto/ghash_s390.c                 | 110 ++---
 arch/s390/crypto/sha.h                        |  22 +-
 arch/s390/crypto/sha1_s390.c                  |  22 +-
 arch/s390/crypto/sha256_s390.c                |  35 +-
 arch/s390/crypto/sha3_256_s390.c              |  60 +--
 arch/s390/crypto/sha3_512_s390.c              |  67 +--
 arch/s390/crypto/sha512_s390.c                |  45 +-
 arch/s390/crypto/sha_common.c                 |  84 ++--
 arch/sparc/crypto/md5_glue.c                  | 141 +++---
 arch/sparc/crypto/sha1_glue.c                 | 109 +---
 arch/sparc/crypto/sha256_glue.c               | 121 +----
 arch/sparc/crypto/sha512_glue.c               | 102 +---
 arch/x86/crypto/ghash-clmulni-intel_asm.S     |   5 +-
 arch/x86/crypto/ghash-clmulni-intel_glue.c    | 301 ++----------
 arch/x86/crypto/sha1_ssse3_glue.c             |  81 +--
 arch/x86/crypto/sha256_ssse3_glue.c           | 104 ++--
 arch/x86/crypto/sha512_ssse3_glue.c           |  79 +--
 arch/x86/crypto/sm3_avx_glue.c                |  54 +-
 crypto/blake2b_generic.c                      |  31 +-
 crypto/ccm.c                                  |  59 +--
 crypto/cmac.c                                 |  92 +---
 crypto/ghash-generic.c                        |  56 +--
 crypto/md5.c                                  | 102 ++--
 crypto/sha1_generic.c                         |  33 +-
 crypto/sha256_generic.c                       |  50 +-
 crypto/sha3_generic.c                         | 101 ++--
 crypto/sha512_generic.c                       |  56 +--
 crypto/shash.c                                | 229 +++++++--
 crypto/sm3_generic.c                          |  31 +-
 crypto/xcbc.c                                 |  92 +---
 drivers/crypto/nx/nx-aes-xcbc.c               | 128 ++---
 drivers/crypto/nx/nx-sha256.c                 | 130 ++---
 drivers/crypto/nx/nx-sha512.c                 | 143 +++---
 drivers/crypto/nx/nx.c                        |  15 +-
 drivers/crypto/nx/nx.h                        |   6 +-
 drivers/crypto/padlock-sha.c                  | 464 ++++++------------
 drivers/crypto/xilinx/zynqmp-sha.c            |  71 +--
 include/crypto/blake2b.h                      |  31 +-
 include/crypto/ghash.h                        |   4 +-
 include/crypto/hash.h                         | 104 ++--
 include/crypto/internal/blake2b.h             |  94 ++--
 include/crypto/internal/hash.h                |  15 +
 include/crypto/md5.h                          |   3 +-
 include/crypto/sha1.h                         |   9 +-
 include/crypto/sha1_base.h                    |  79 +--
 include/crypto/sha2.h                         |  20 +-
 include/crypto/sha256_base.h                  | 111 +++--
 include/crypto/sha3.h                         |  16 +-
 include/crypto/sha512_base.h                  |  88 ++--
 include/crypto/sm3.h                          |   3 +-
 include/crypto/sm3_base.h                     |  79 ++-
 include/linux/crypto.h                        |   2 +
 lib/crypto/sha256.c                           |   7 +-
 lib/crypto/sm3.c                              |  68 +--
 91 files changed, 2372 insertions(+), 4561 deletions(-)
 delete mode 100644 arch/arm/crypto/sha1.h

base-commit: da4cb617bc7d827946cbb368034940b379a1de90

Signature · 1 line
2.39.5