Skip to content

Add TCP_MAXSEG socket option support

Geliang Tang mptcp 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 3 repliesIn review
  2. v23 patches 4 repliesSuperseded
  3. v12 patches 4 repliesSuperseded

Changes in v3 from the cover letter

- drop "EXPORT_SYMBOL(tcp_sock_set_maxseg)" as Matt suggested.
- use mptcp_getsockopt_first_sf_only instead of mptcp_put_int_option.
- drop selftest
- add a packetdrill test.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2tcp: add tcp_sock_set_maxseginclude/linux/tcp.h net/ipv4/tcp.c+15 -90 replies
2/2mptcp: add TCP_MAXSEG sockopt supportnet/mptcp/protocol.h net/mptcp/sockopt.c+26 -03 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchMatthieu Baerts (NGI0)
1/2A-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH mptcp-next v3 0/2] Add TCP_MAXSEG socket option support

v3:
- drop "EXPORT_SYMBOL(tcp_sock_set_maxseg)" as Matt suggested.
- use mptcp_getsockopt_first_sf_only instead of mptcp_put_int_option.
- drop selftest
- add a packetdrill test.

v2:
- add a new helper tcp_sock_set_maxseg.
- add maxseg member of struct mptcp_sock.
- add mptcp_setsockopt_all_subflows helper.
- invoke mptcp_setsockopt_all_subflows under the msk socket lock.
- drop mptcp_getsockopt_sol_tcp_maxseg, use mptcp_put_int_option instead.

Geliang Tang (2):
tcp: add tcp_sock_set_maxseg
mptcp: add TCP_MAXSEG sockopt support

 include/linux/tcp.h  |  1 +
 net/ipv4/tcp.c       | 23 ++++++++++++++---------
 net/mptcp/protocol.h |  1 +
 net/mptcp/sockopt.c  | 25 +++++++++++++++++++++++++
 4 files changed, 41 insertions(+), 9 deletions(-)
Signature · 1 line
2.43.0