Skip to content

Initial NFS client support for RWF_DONTCACHE

Trond Myklebust linux-fsdevel linux-mm linux-nfs 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest3 patches 1 replyIn review
  2. v43 patches 1 replySuperseded
  3. v32 patches 8 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v22 patches0 repliesSuperseded
v1 RFC3 patches10 repliesSuperseded

Changes in v5 from the cover letter

- Change helper function export types to EXPORT_SYMBOL_GPL

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3filemap: Add a helper for filesystems implementing dropbehindinclude/linux/pagemap.h mm/filemap.c+4 -20 replies
2/3filemap: Add a version of folio_end_writeback that ignores dropbehindinclude/linux/pagemap.h mm/filemap.c+24 -60 replies
3/3NFS: Enable use of the RWF_DONTCACHE flag on the NFS clientfs/nfs/file.c fs/nfs/nfs4file.c fs/nfs/write.c+9 -50 replies

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchMike Snitzer
1/3R-b
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 0/3] Initial NFS client support for RWF_DONTCACHE

From: Trond Myklebust <[email protected]>

The main issue is allowing support on 2 stage writes (i.e. unstable WRITE followed by a COMMIT) since those don't follow the current assumption that the 'dropbehind' flag can be fulfilled as soon as the writeback lock is dropped.

v2:
- Make use of the new iocb parameter for nfs_write_begin()
v3:
- Set/clear PG_DROPBEHIND on the head of the nfs_page group
- Simplify helper folio_end_dropbehind
v4:
- Replace filemap_end_dropbehind_write() with folio_end_dropbehind()
- Add a helper to replace folio_end_writeback with an equivalent that does not attempt to interpret the dropbehind flag
- Keep the folio dropbehind flag set until the NFS client is ready to call folio_end_dropbehind.
- Don't try to do a read-modify-write in nfs_write_begin() if the folio has the dropbehind flag set.
v5:
- Change helper function export types to EXPORT_SYMBOL_GPL

Trond Myklebust (3):
filemap: Add a helper for filesystems implementing dropbehind
filemap: Add a version of folio_end_writeback that ignores dropbehind
NFS: Enable use of the RWF_DONTCACHE flag on the NFS client

 fs/nfs/file.c           |  9 +++++----
 fs/nfs/nfs4file.c       |  1 +
 fs/nfs/write.c          |  4 +++-
 include/linux/pagemap.h |  2 ++
 mm/filemap.c            | 34 ++++++++++++++++++++++++++--------
 5 files changed, 37 insertions(+), 13 deletions(-)
Signature · 1 line
2.51.0