common: Move exit related functions to common/exit
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest2 patches 8 repliesIn review
- v22 patches 5 repliesSuperseded
- v12 patches 6 repliesSuperseded
Changes in v3 from the cover letter
Addressed Dave's feedbacks.
In patch [1/2]
- Removed _die() and die_now() from common/exit
- Replaced die_now() with _fatal in common/punch
- Removed sourcing of common/exit and common/test_names from common/config and moved them to the beginning of check.
- Added sourcing of common/test_names in _begin_fstest() since common/config is no more sourcing common/test_names.
- Added a blank line in _begin_fstest() after sourcing common/{exit,test_names}
In patch [2/2]
- Replaced "_exit 1" with _fatal and "echo <error message>; _exit 1" with _fatal <error message>.
- Reverted to "exit \$status" in the trap handler registration in check - just to make it more obvious to the reader that we are capturing $status as the final exit value.
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | common: Move exit related functions to a common/exitcheck common/ common/ +3 more | +61 | 4 replies | |
| 2/2 | check: Replace exit with _fatal and _exit in checkcheck | +18 | 2 replies |
Reviews trailers per patch
1 of 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Ritesh Harjani (IBM) | Zorro Lang |
|---|---|---|
| Series | R-b | |
| 1/2 | ||
| 2/2 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v3 0/2] common: Move exit related functions to common/exit
This patch series moves all the exit related functions to a separate file - common/exit. This will remove the dependency to source non-related files to use these exit related functions. Thanks to Dave for suggesting this[1]. The second patch replaces exit with _exit in check file - I missed replacing them in [2].
[v2] -> v3
Addressed Dave's feedbacks.
In patch [1/2]
- Removed _die() and die_now() from common/exit
- Replaced die_now() with _fatal in common/punch
- Removed sourcing of common/exit and common/test_names from common/config and moved them to the beginning of check.
- Added sourcing of common/test_names in _begin_fstest() since common/config is no more sourcing common/test_names.
- Added a blank line in _begin_fstest() after sourcing common/{exit,test_names}
In patch [2/2]
- Replaced "_exit 1" with _fatal and "echo <error message>; _exit 1" with _fatal <error message>.
- Reverted to "exit \$status" in the trap handler registration in check - just to make it more obvious to the reader that we are capturing $status as the final exit value.
[v1] https://lore.kernel.org/all/[email protected]/
[v2] https://lore.kernel.org/all/[email protected]/
[1] https://lore.kernel.org/all/[email protected]/
[2] https://lore.kernel.org/all/48dacdf636be19ae8bff66cc3852d27e28030613.1744181682.git.nirjhar.roy.lists@gmail.com/
Nirjhar Roy (IBM) (2):
common: Move exit related functions to a common/exit
check: Replace exit with _fatal and _exit in check
check | 54 ++++++++++++++++++------------------------------- common/config | 17 ---------------- common/exit | 39 +++++++++++++++++++++++++++++++++++ common/preamble | 3 +++ common/punch | 39 ++++++++++++++++------------------- common/rc | 28 ------------------------- 6 files changed, 79 insertions(+), 101 deletions(-) create mode 100644 common/exit
--
2.34.1