Skip to content

drm/i915: refactor VLV IOSF SB for display usage

Jani Nikula intel-gfx intel-xe 3 versions – Applied

Status from this message: Pushed to din, thanks for the review.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest8 patches 1 replyApplied
  2. v28 patches 2 repliesSuperseded
  3. v16 patches 1 replySuperseded

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/8drm/i915: rename vlv_sideband*.[ch] to vlv_iosf_sb*.[ch]drivers/gpu/drm/i915/Makefile drivers/gpu/drm/i915/display/i9xx_wm.c drivers/gpu/drm/i915/display/intel_cdclk.c +19 more+31 -310 replies
2/8drm/i915: add generic read/write functions for VLV IOSF SBdrivers/gpu/drm/i915/vlv_iosf_sb.c drivers/gpu/drm/i915/vlv_iosf_sb.h drivers/gpu/drm/xe/compat-i915-headers/vlv_iosf_sb.h+83 -50 replies
3/8drm/i915: rewrite VLV IOSF SB unit specific read/write functionsdrivers/gpu/drm/i915/vlv_iosf_sb.c drivers/gpu/drm/i915/vlv_iosf_sb.h+22 -550 replies
4/8drm/i915: switch i915 core to generic VLV IOSF SB functionsdrivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c drivers/gpu/drm/i915/gt/intel_rps.c drivers/gpu/drm/i915/soc/intel_dram.c+28 -280 replies
5/8drm/i915: move VLV IOSF SB unit specific helpers under displaydrivers/gpu/drm/i915/Makefile drivers/gpu/drm/i915/display/i9xx_wm.c drivers/gpu/drm/i915/display/intel_cdclk.c +13 more+213 -2890 replies
6/8drm/i915: convert VLV IOSF SB interface to struct drm_devicedrivers/gpu/drm/i915/display/i9xx_wm.c drivers/gpu/drm/i915/display/intel_cdclk.c drivers/gpu/drm/i915/display/intel_display.c +15 more+410 -4260 replies
7/8drm/i915: rename VLV IOSF SB ports parameter to unit_maskdrivers/gpu/drm/i915/vlv_iosf_sb.c drivers/gpu/drm/i915/vlv_iosf_sb.h+6 -60 replies
8/8drm/i915: ensure correct VLV IOSF SB units have been get/putdrivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/vlv_iosf_sb.c+11 -00 replies

Reviews trailers per patch

All 8 patches have a Reviewed-by or Acked-by.

PatchVille Syrjälä
1/8R-b
2/8R-b
3/8R-b
4/8R-b
5/8R-b
6/8R-b
7/8R-b
8/8R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/8] drm/i915: refactor VLV IOSF SB for display usage

v3 of [1] fixing dpio 1 vs 2 sanity checks.

[1] https://lore.kernel.org/r/[email protected]

Jani Nikula (8):
drm/i915: rename vlv_sideband*.[ch] to vlv_iosf_sb*.[ch] drm/i915: add generic read/write functions for VLV IOSF SB drm/i915: rewrite VLV IOSF SB unit specific read/write functions drm/i915: switch i915 core to generic VLV IOSF SB functions drm/i915: move VLV IOSF SB unit specific helpers under display drm/i915: convert VLV IOSF SB interface to struct drm_device drm/i915: rename VLV IOSF SB ports parameter to unit_mask drm/i915: ensure correct VLV IOSF SB units have been get/put

 drivers/gpu/drm/i915/Makefile                 |   5 +-
 drivers/gpu/drm/i915/display/i9xx_wm.c        |  35 ++-
 drivers/gpu/drm/i915/display/intel_cdclk.c    |  47 ++---
 drivers/gpu/drm/i915/display/intel_display.c  |  23 +-
 drivers/gpu/drm/i915/display/intel_display.h  |   7 +-
 .../drm/i915/display/intel_display_power.c    |   7 +-
 .../i915/display/intel_display_power_map.c    |   2 +-
 .../i915/display/intel_display_power_well.c   |  71 +++----
 drivers/gpu/drm/i915/display/intel_dpio_phy.c | 199 +++++++++---------
 drivers/gpu/drm/i915/display/intel_dpll.c     | 135 ++++++------
 drivers/gpu/drm/i915/display/vlv_dsi.c        |  26 ++-
 drivers/gpu/drm/i915/display/vlv_dsi_pll.c    |  46 ++--
 drivers/gpu/drm/i915/display/vlv_sideband.c   |  50 +++++
 drivers/gpu/drm/i915/display/vlv_sideband.h   | 156 ++++++++++++++
 drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c |   8 +-
 drivers/gpu/drm/i915/gt/intel_rps.c           |  58 ++---
 drivers/gpu/drm/i915/i915_driver.c            |   2 +-
 drivers/gpu/drm/i915/i915_drv.h               |   1 +
 drivers/gpu/drm/i915/intel_clock_gating.c     |   2 +-
 drivers/gpu/drm/i915/soc/intel_dram.c         |  14 +-
 .../i915/{vlv_sideband.c => vlv_iosf_sb.c}    | 176 ++++++----------
 drivers/gpu/drm/i915/vlv_iosf_sb.h            |  37 ++++
 .../{vlv_sideband_reg.h => vlv_iosf_sb_reg.h} |   6 +-
 drivers/gpu/drm/i915/vlv_sideband.h           | 125 -----------
 .../drm/xe/compat-i915-headers/vlv_iosf_sb.h  |  42 ++++
 .../{vlv_sideband_reg.h => vlv_iosf_sb_reg.h} |   2 +-
 .../drm/xe/compat-i915-headers/vlv_sideband.h | 132 ------------
 27 files changed, 689 insertions(+), 725 deletions(-)
 create mode 100644 drivers/gpu/drm/i915/display/vlv_sideband.c
 create mode 100644 drivers/gpu/drm/i915/display/vlv_sideband.h
 rename drivers/gpu/drm/i915/{vlv_sideband.c => vlv_iosf_sb.c} (55%)
 create mode 100644 drivers/gpu/drm/i915/vlv_iosf_sb.h
 rename drivers/gpu/drm/i915/{vlv_sideband_reg.h => vlv_iosf_sb_reg.h} (98%)
 delete mode 100644 drivers/gpu/drm/i915/vlv_sideband.h
 create mode 100644 drivers/gpu/drm/xe/compat-i915-headers/vlv_iosf_sb.h
 rename drivers/gpu/drm/xe/compat-i915-headers/{vlv_sideband_reg.h => vlv_iosf_sb_reg.h} (66%)
 delete mode 100644 drivers/gpu/drm/xe/compat-i915-headers/vlv_sideband.h
Signature · 1 line
2.39.5