spi: sh-msiof: Transfer size improvements and I2S reuse
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest22 patches 5 repliesIn review
- v122 patches 2 repliesSuperseded
Patches in v2 No applies recorded yet
Reviews trailers per patch
1 of 22 patches has a Reviewed-by or Acked-by.
| Patch | Kuninori Morimoto |
|---|---|
| 1/22 | |
| 2/22 | |
| 3/22 | |
| 4/22 | A-b |
| 5/22 | |
| 6/22 | |
| 7/22 | |
| 8/22 | |
| 9/22 | |
| 10/22 | |
| 11/22 | |
| 12/22 | |
| 13/22 | |
| 14/22 | |
| 15/22 | |
| 16/22 | |
| 17/22 | |
| 18/22 | |
| 19/22 | |
| 20/22 | |
| 21/22 | |
| 22/22 | T-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 00/22] spi: sh-msiof: Transfer size improvements and I2S reuse
Hi all,
This patch series (A) improves single transfer sizes in the MSIOF driver, using two methods:
- By increasing the assumed FIFO sizes, impacting both PIO and DMA transfers,
- By using two groups, impacting DMA transfers,
and (B) lets the recently-introduced MSIOF I2S drive reuse the SPI driver's register definitions. All of this is covered with a thick sauce of fixes for (harmless) bugs, cleanups, and refactorings.
Changes compared to v1[1]:
- Make include/linux/spi/sh_msiof.h self-contained,
- Add Tested-by for the sound part.
Note that the driver uses the limitations as specified in the hardware documentation. For discovering the actual FIFO sizes, I wrote some crude test code that can be found at [2].
This is based on spi/for-next and sound-asoc/for-next, and has been tested on a variery of R-Car SoCs.
Thanks for your comments!
[1] https://lore.kernel.org/[email protected]
[2] https://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git/log/?h=topic/msiof-fifo
Geert Uytterhoeven (22):
spi: sh-msiof: Drop comma after OF match table sentinel
spi: sh-msiof: Remove unneeded compatible values
spi: sh-msiof: Fix maximum DMA transfer size
spi: sh-msiof: Complete using dev in sh_msiof_spi_probe()
spi: sh-msiof: Use bool for boolean flags
spi: sh-msiof: Make words/bits unsigned in sh_msiof_spi_txrx_once()
spi: sh-msiof: Make words/fs unsigned in FIFO helpers
spi: sh-msiof: SITMDR1/SIRMDR1 bitfield conversion
spi: sh-msiof: SITMDR2 and SIRMDR2 bitfield conversion
spi: sh-msiof: SITSCR/SIRSCR bitfield conversion
spi: sh-msiof: SICTR bitfield conversion
spi: sh-msiof: SIFCTR bitfield conversion
spi: sh-msiof: Correct SIMDR2_GRPMASK
spi: sh-msiof: Add core support for dual-group transfers
spi: sh-msiof: Correct RX FIFO size for R-Car Gen2
spi: sh-msiof: Correct RX FIFO size for R-Car Gen3
spi: sh-msiof: Increase TX FIFO size for R-Car V4H/V4M
spi: sh-msiof: Simplify BRG's Division Ratio
spi: sh-msiof: Double maximum DMA transfer size using two groups
spi: sh-msiof: Document frame start sync pulse mode
spi: sh-msiof: Move register definitions to <linux/spi/sh_msiof.h>
ASoC: renesas: msiof: Convert to <linux/spi/sh_msiof.h>
drivers/spi/spi-sh-msiof.c | 357 +++++++++++++-------------------- include/linux/spi/sh_msiof.h | 125 ++++++++++++ sound/soc/renesas/rcar/msiof.c | 94 +++------ 3 files changed, 287 insertions(+), 289 deletions(-)
Signature · 12 lines
2.43.0
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds