Skip to content

mmc: Cleanup sdhci_pltfm_free()/sdhci_free_host() usage

Binbin Zhou imx linux-aspeed linux-mmc linux-riscv linux-tegra openbmc spacemit 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest posting 2/235 patches 8 repliesIn review
  2. v3 posting 1/236 patches 8 repliesSuperseded
  3. v235 patches 4 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v133 of 34 patches11 repliesSuperseded

Changes in v3 from the cover letter

- Collect Reviewed-by and Acked-by tags.
Patch-19:
- Use dev_err_probe() to cleanup the code.
Patch-32:
- Fix build warning by lkp:

Patches in v3 posting 2/2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/35mmc: sdhci: Use devm_mmc_alloc_host() helperdrivers/mmc/host/sdhci.c+1 -23 replies
2/35mmc: sdhci-acpi: Drop the use of sdhci_free_host()drivers/mmc/host/sdhci-acpi.c+0 -30 replies
3/35mmc: sdhci-milbeaut: Drop the use of sdhci_free_host()drivers/mmc/host/sdhci-milbeaut.c+6 -130 replies
4/35mmc: sdhci-pci: Drop the use of sdhci_free_host()drivers/mmc/host/sdhci-pci-core.c+2 -70 replies
5/35mmc: sdhci-s3c: Drop the use of sdhci_free_host()drivers/mmc/host/sdhci-s3c.c+4 -120 replies
6/35mmc: sdhci-spear: Drop the use of sdhci_free_host()drivers/mmc/host/sdhci-spear.c+4 -70 replies
7/35mmc: sdhci-pltfm: Drop the use of sdhci_pltfm_free()drivers/mmc/host/sdhci-pltfm.c+1 -100 replies
8/35mmc: sdhci-bcm-kona: Drop the use of sdhci_pltfm_free()drivers/mmc/host/sdhci-bcm-kona.c+0 -20 replies
9/35mmc: sdhci-brcmstb: Drop the use of sdhci_pltfm_free()drivers/mmc/host/sdhci-brcmstb.c+0 -10 replies
10/35mmc: sdhci-cadence: Drop the use of sdhci_pltfm_free()drivers/mmc/host/sdhci-cadence.c+6 -150 replies
11/35mmc: sdhci-dove: Drop the use of sdhci_pltfm_free()drivers/mmc/host/sdhci-dove.c+2 -100 replies
12/35mmc: sdhci-esdhc-imx: Drop the use of sdhci_pltfm_free()drivers/mmc/host/sdhci-esdhc-imx.c+0 -31 reply
13/35mmc: sdhci-esdhc-mcf: Drop the use of sdhci_pltfm_free()drivers/mmc/host/sdhci-esdhc-mcf.c+7 -180 replies
14/35mmc: sdhci-iproc: Drop the use of sdhci_pltfm_free()drivers/mmc/host/sdhci-iproc.c+4 -140 replies
15/35mmc: sdhci-msm: Drop the use of sdhci_pltfm_free()drivers/mmc/host/sdhci-msm.c+4 -70 replies
16/35mmc: sdhci-npcm: Drop the use of sdhci_pltfm_free()drivers/mmc/host/sdhci-npcm.c+3 -120 replies
17/35mmc: sdhci-of-arasan: Drop the use of sdhci_pltfm_free()drivers/mmc/host/sdhci-of-arasan.c+8 -180 replies
18/35mmc: sdhci-of-aspeed: Drop the use of sdhci_pltfm_free()drivers/mmc/host/sdhci-of-aspeed.c+2 -80 replies
19/35mmc: sdhci-of-at91: Drop the use of sdhci_pltfm_free()drivers/mmc/host/sdhci-of-at91.c+11 -191 reply
20/35mmc: sdhci-of-dwcmshc: Drop the use of sdhci_pltfm_free()drivers/mmc/host/sdhci-of-dwcmshc.c+5 -90 replies
21/35mmc: sdhci-of-esdhc: Drop the use of sdhci_pltfm_free()drivers/mmc/host/sdhci-of-esdhc.c+2 -90 replies
22/35mmc: sdhci-of-k1: Drop the use of sdhci_pltfm_free()drivers/mmc/host/sdhci-of-k1.c+0 -10 replies
23/35mmc: sdhci-of-ma35d1: Drop the use of sdhci_pltfm_free()drivers/mmc/host/sdhci-of-ma35d1.c+8 -150 replies
24/35mmc: sdhci-of-sparx5: Drop the use of sdhci_pltfm_free()drivers/mmc/host/sdhci-of-sparx5.c+8 -161 reply
25/35mmc: sdhci-omap: Drop the use of sdhci_pltfm_free()drivers/mmc/host/sdhci-omap.c+7 -140 replies
26/35mmc: sdhci-pic32: Drop the use of sdhci_pltfm_free()drivers/mmc/host/sdhci-pic32.c+3 -60 replies
27/35mmc: sdhci-pxav2: Drop the use of sdhci_pltfm_free()drivers/mmc/host/sdhci-pxav2.c+6 -200 replies
28/35mmc: sdhci-pxav3: Drop the use of sdhci_pltfm_free()drivers/mmc/host/sdhci-pxav3.c+1 -60 replies
29/35mmc: sdhci-sprd: Drop the use of sdhci_pltfm_free()drivers/mmc/host/sdhci-sprd.c+10 -230 replies
30/35mmc: sdhci-st: Drop the use of sdhci_pltfm_free()drivers/mmc/host/sdhci-st.c+2 -40 replies
31/35mmc: sdhci-tegra: Drop the use of sdhci_pltfm_free()drivers/mmc/host/sdhci-tegra.c+3 -61 reply
32/35mmc: sdhci-xenon: Drop the use of sdhci_pltfm_free()drivers/mmc/host/sdhci-xenon.c+5 -100 replies
33/35mmc: sdhci_am654: Drop the use of sdhci_pltfm_free()drivers/mmc/host/sdhci_am654.c+6 -140 replies
34/35mmc: sdhci_f_sdh30: Drop the use of sdhci_pltfm_free()drivers/mmc/host/sdhci_f_sdh30.c+4 -90 replies
35/35mmc: sdhci: Drop sdhci_free_host()/sdhci_pltfm_free() interfacedrivers/mmc/host/sdhci-pltfm.c drivers/mmc/host/sdhci-pltfm.h drivers/mmc/host/sdhci.c +1 more+0 -130 replies

Reviews trailers per patch

7 of 35 patches have a Reviewed-by or Acked-by.

PatchAngelo DureghelloYixun LanChunyan ZhangHaibo ChenAubin ConstansThierry RedingDaniel Machon
1/35
2/35
3/35
4/35
5/35
6/35
7/35
8/35
9/35
10/35
11/35
12/35R-b
13/35A-b
14/35
15/35
16/35
17/35
18/35
19/35A-b
20/35
21/35
22/35R-b
23/35
24/35A-b
25/35
26/35
27/35
28/35
29/35R-b
30/35
31/35A-b
32/35
33/35
34/35
35/35

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 7 reviewers.

Read the v3 thread

Cover letter [PATCH v3 00/35] mmc: Cleanup sdhci_pltfm_free()/sdhci_free_host() usage

Hi all:

After the first part of the cleanup[1], there are sdhci related drivers that need further cleanup.

This patchset is the second part of the cleanup series, and since sdhci has sdhci_alloc_host() as the general interface, our main job is to clean up sdhci_pltfm_free() and sdhci_free_host().

[1]: https://lore.kernel.org/all/[email protected]/

Thanks.

-----
V3:
- Collect Reviewed-by and Acked-by tags.
Patch-19:
- Use dev_err_probe() to cleanup the code.
Patch-32:
- Fix build warning by lkp:

	https://lore.kernel.org/all/[email protected]/

Link to V2:
https://lore.kernel.org/all/[email protected]/

V2:
- Collect Reviewed-by and Acked-by tags.

Patch-01:
- Set sdhci_free_host() to empty, rather than dropping it.
Patch-07:
- Set sdhci_pltfm_free() to empty, rather than dropping it.
Patch-22:
- As requested by Yixun, retain the goto scheme.
Patch-35:
- New patch;
- Since all calls have been cleaned up, sdhci_pltfm_free()/sdhci_free_host() are now dropped directly;

Link to V1:
https://lore.kernel.org/all/[email protected]/

Binbin Zhou (35):
mmc: sdhci: Use devm_mmc_alloc_host() helper
mmc: sdhci-acpi: Drop the use of sdhci_free_host()
mmc: sdhci-milbeaut: Drop the use of sdhci_free_host()
mmc: sdhci-pci: Drop the use of sdhci_free_host()
mmc: sdhci-s3c: Drop the use of sdhci_free_host()
mmc: sdhci-spear: Drop the use of sdhci_free_host()
mmc: sdhci-pltfm: Drop the use of sdhci_pltfm_free()
mmc: sdhci-bcm-kona: Drop the use of sdhci_pltfm_free()
mmc: sdhci-brcmstb: Drop the use of sdhci_pltfm_free()
mmc: sdhci-cadence: Drop the use of sdhci_pltfm_free()
mmc: sdhci-dove: Drop the use of sdhci_pltfm_free()
mmc: sdhci-esdhc-imx: Drop the use of sdhci_pltfm_free()
mmc: sdhci-esdhc-mcf: Drop the use of sdhci_pltfm_free()
mmc: sdhci-iproc: Drop the use of sdhci_pltfm_free()
mmc: sdhci-msm: Drop the use of sdhci_pltfm_free()
mmc: sdhci-npcm: Drop the use of sdhci_pltfm_free()
mmc: sdhci-of-arasan: Drop the use of sdhci_pltfm_free()
mmc: sdhci-of-aspeed: Drop the use of sdhci_pltfm_free()
mmc: sdhci-of-at91: Drop the use of sdhci_pltfm_free()
mmc: sdhci-of-dwcmshc: Drop the use of sdhci_pltfm_free()
mmc: sdhci-of-esdhc: Drop the use of sdhci_pltfm_free()
mmc: sdhci-of-k1: Drop the use of sdhci_pltfm_free()
mmc: sdhci-of-ma35d1: Drop the use of sdhci_pltfm_free()
mmc: sdhci-of-sparx5: Drop the use of sdhci_pltfm_free()
mmc: sdhci-omap: Drop the use of sdhci_pltfm_free()
mmc: sdhci-pic32: Drop the use of sdhci_pltfm_free()
mmc: sdhci-pxav2: Drop the use of sdhci_pltfm_free()
mmc: sdhci-pxav3: Drop the use of sdhci_pltfm_free()
mmc: sdhci-sprd: Drop the use of sdhci_pltfm_free()
mmc: sdhci-st: Drop the use of sdhci_pltfm_free()
mmc: sdhci-tegra: Drop the use of sdhci_pltfm_free()
mmc: sdhci-xenon: Drop the use of sdhci_pltfm_free()
mmc: sdhci_am654: Drop the use of sdhci_pltfm_free()
mmc: sdhci_f_sdh30: Drop the use of sdhci_pltfm_free()
mmc: sdhci: Drop sdhci_free_host()/sdhci_pltfm_free() interface

 drivers/mmc/host/sdhci-acpi.c       |  3 ---
 drivers/mmc/host/sdhci-bcm-kona.c   |  2 --
 drivers/mmc/host/sdhci-brcmstb.c    |  1 -
 drivers/mmc/host/sdhci-cadence.c    | 21 ++++++------------
 drivers/mmc/host/sdhci-dove.c       | 12 ++---------
 drivers/mmc/host/sdhci-esdhc-imx.c  |  3 ---
 drivers/mmc/host/sdhci-esdhc-mcf.c  | 25 ++++++----------------
 drivers/mmc/host/sdhci-iproc.c      | 18 ++++------------
 drivers/mmc/host/sdhci-milbeaut.c   | 19 ++++++-----------
 drivers/mmc/host/sdhci-msm.c        | 11 ++++------
 drivers/mmc/host/sdhci-npcm.c       | 15 +++----------
 drivers/mmc/host/sdhci-of-arasan.c  | 26 +++++++----------------
 drivers/mmc/host/sdhci-of-aspeed.c  | 10 ++-------
 drivers/mmc/host/sdhci-of-at91.c    | 30 ++++++++++----------------
 drivers/mmc/host/sdhci-of-dwcmshc.c | 14 +++++-------
 drivers/mmc/host/sdhci-of-esdhc.c   | 11 ++--------
 drivers/mmc/host/sdhci-of-k1.c      |  1 -
 drivers/mmc/host/sdhci-of-ma35d1.c  | 23 +++++++-------------
 drivers/mmc/host/sdhci-of-sparx5.c  | 24 +++++++--------------
 drivers/mmc/host/sdhci-omap.c       | 21 ++++++------------
 drivers/mmc/host/sdhci-pci-core.c   |  9 ++------
 drivers/mmc/host/sdhci-pic32.c      |  9 +++-----
 drivers/mmc/host/sdhci-pltfm.c      | 16 +-------------
 drivers/mmc/host/sdhci-pltfm.h      |  1 -
 drivers/mmc/host/sdhci-pxav2.c      | 26 ++++++-----------------
 drivers/mmc/host/sdhci-pxav3.c      |  7 +-----
 drivers/mmc/host/sdhci-s3c.c        | 16 ++++----------
 drivers/mmc/host/sdhci-spear.c      | 11 ++++------
 drivers/mmc/host/sdhci-sprd.c       | 33 +++++++++--------------------
 drivers/mmc/host/sdhci-st.c         |  6 ++----
 drivers/mmc/host/sdhci-tegra.c      |  9 +++-----
 drivers/mmc/host/sdhci-xenon.c      | 15 +++++--------
 drivers/mmc/host/sdhci.c            |  9 +-------
 drivers/mmc/host/sdhci.h            |  1 -
 drivers/mmc/host/sdhci_am654.c      | 20 ++++++-----------
 drivers/mmc/host/sdhci_f_sdh30.c    | 13 ++++--------
 36 files changed, 135 insertions(+), 356 deletions(-)

base-commit: d2c6acff6386f43ed307822454b970c831c48f1b

Signature · 1 line
2.47.1