Skip to content

btrfs-progs: convert: fix a long bug that bgt feature never works

Qu Wenruo linux-btrfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest9 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9btrfs-progs: convert: add feature dependency checks for bgtconvert/main.c+6 -00 replies
2/9btrfs-progs: convert: replace the bytenr check with a UASSERT()convert/common.c+5 -290 replies
3/9btrfs-progs: convert: simplify insert_temp_root_item()convert/common.c+24 -190 replies
4/9btrfs-progs: convert: simplify insert_temp_dev_item() and insert_temp_chunk_item()convert/common.c+21 -250 replies
5/9btrfs-progs: convert: simplify insert_temp_dev_extent()convert/common.c+11 -120 replies
6/9btrfs-progs: convert: simplify insert_temp_extent_item() and insert_temp_block_group()convert/common.c+35 -370 replies
7/9btrfs-progs: convert: merge setup_temp_fs_tree() and setup_temp_csum_tree()convert/common.c+6 -290 replies
8/9btrfs-progs: convert: implement the block group tree support properlyconvert/common.c+85 -230 replies
9/9btrfs-progs: convert-tests: add a test case for bgt featuretests/convert-tests/028-block-group-tree/test.sh+20 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/9] btrfs-progs: convert: fix a long bug that bgt feature never works

There is a long bug that, "btrfs-convert -O bgt" doesn't create a fs with bgt feature at all.

In fact "mkfs.btrfs -O bgt" is no different than "mkfs.btrfs -O ^bgt".

The root cause is explained and fixed in the second last patch.

The first 7 patches are mostly preparation and cleanup for properly intorduce block group tree at temprory fs creation time.

Qu Wenruo (9):
btrfs-progs: convert: add feature dependency checks for bgt
btrfs-progs: convert: replace the bytenr check with a UASSERT()
btrfs-progs: convert: simplify insert_temp_root_item()
btrfs-progs: convert: simplify insert_temp_dev_item() and
insert_temp_chunk_item()
btrfs-progs: convert: simplify insert_temp_dev_extent()
btrfs-progs: convert: simplify insert_temp_extent_item() and
insert_temp_block_group()
btrfs-progs: convert: merge setup_temp_fs_tree() and
setup_temp_csum_tree()
btrfs-progs: convert: implement the block group tree support properly
btrfs-progs: convert-tests: add a test case for bgt feature

 convert/common.c                              | 337 +++++++++---------
 convert/main.c                                |   6 +
 .../028-block-group-tree/test.sh              |  20 ++
 3 files changed, 201 insertions(+), 162 deletions(-)
 create mode 100755 tests/convert-tests/028-block-group-tree/test.sh

--
2.49.0