smb:common: introduce and use common smbdirect headers/structures (step1)
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest12 patches 14 repliesIn review
- v15 patches 3 repliesSuperseded
Changes in v2 from the cover letter
- change smb_direct into smbdirect
- make usage of header files just as needed
- also introduce struct smbdirect_socket[_parameters] as shared structures
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/12 | smb: smbdirect: add smbdirect_pdu.h with protocol definitionsfs/ | +55 | 12 replies | |
| 2/12 | smb: client: make use of common smbdirect_pdu.hfs/ fs/ | +19 | 0 replies | |
| 3/12 | smb: server: make use of common smbdirect_pdu.hfs/ fs/ | +25 | 0 replies | |
| 4/12 | smb: smbdirect: add smbdirect.h with public structuresfs/ | +17 | 0 replies | |
| 5/12 | smb: client: make use of common smbdirect.hfs/ fs/ | +9 | 0 replies | |
| 6/12 | smb: server: make use of common smbdirect.hfs/ fs/ fs/ +2 more | +18 | 0 replies | |
| 7/12 | smb: smbdirect: add smbdirect_socket.hfs/ | +41 | 0 replies | |
| 8/12 | smb: client: make use of common smbdirect_socketfs/ fs/ fs/ | +146 | 0 replies | |
| 9/12 | smb: server: make use of common smbdirect_socketfs/ | +139 | 0 replies | |
| 10/12 | smb: smbdirect: introduce smbdirect_socket_parametersfs/ fs/ fs/ | +23 | 0 replies | |
| 11/12 | smb: client: make use of common smbdirect_socket_parametersfs/ fs/ fs/ +1 more | +77 | 0 replies | |
| 12/12 | smb: server: make use of common smbdirect_socket_parametersfs/ | +44 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.
Cover letter [PATCH v2 00/12] smb:common: introduce and use common smbdirect headers/structures (step1)
Hi,
in preparation of a having a common smb_direct layer I started to move things into common header files and added the first step in using shared structues like struct smbdirect_socket.
Currently only simple things are shared and there is no intended behaviour change (even if I found some things I'd like to change, but I'll defer them in order to make the review easier).
I'll work on this the next few months in order to
unify the in kernel client and server layers
and expose the result to userspace too.
So that Samba can also use it.
v2:
- change smb_direct into smbdirect
- make usage of header files just as needed
- also introduce struct smbdirect_socket[_parameters] as shared structures
Stefan Metzmacher (12):
smb: smbdirect: add smbdirect_pdu.h with protocol definitions
smb: client: make use of common smbdirect_pdu.h
smb: server: make use of common smbdirect_pdu.h
smb: smbdirect: add smbdirect.h with public structures
smb: client: make use of common smbdirect.h
smb: server: make use of common smbdirect.h
smb: smbdirect: add smbdirect_socket.h
smb: client: make use of common smbdirect_socket
smb: server: make use of common smbdirect_socket
smb: smbdirect: introduce smbdirect_socket_parameters
smb: client: make use of common smbdirect_socket_parameters
smb: server: make use of common smbdirect_socket_parameters
fs/smb/client/cifs_debug.c | 23 +- fs/smb/client/smb2ops.c | 14 +- fs/smb/client/smb2pdu.c | 17 +- fs/smb/client/smbdirect.c | 389 +++++++++++---------- fs/smb/client/smbdirect.h | 71 +--- fs/smb/common/smbdirect/smbdirect.h | 37 ++ fs/smb/common/smbdirect/smbdirect_pdu.h | 55 +++ fs/smb/common/smbdirect/smbdirect_socket.h | 43 +++ fs/smb/server/connection.c | 4 +- fs/smb/server/connection.h | 10 +- fs/smb/server/smb2pdu.c | 11 +- fs/smb/server/smb2pdu.h | 6 - fs/smb/server/transport_rdma.c | 385 +++++++++++--------- fs/smb/server/transport_rdma.h | 41 --- 14 files changed, 613 insertions(+), 493 deletions(-) create mode 100644 fs/smb/common/smbdirect/smbdirect.h create mode 100644 fs/smb/common/smbdirect/smbdirect_pdu.h create mode 100644 fs/smb/common/smbdirect/smbdirect_socket.h
Signature · 1 line
2.34.1