Skip to content

Remove some hardcoded SEV-SNP guest policy checks during guest launch

Tom Lendacky kvm lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2KVM: SVM: Allow SNP guest policy disallow running with SMT enabledarch/x86/kvm/svm/sev.c+1 -20 replies
2/2KVM: SVM: Allow SNP guest policy to specify SINGLE_SOCKETarch/x86/kvm/svm/sev.c+0 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] Remove some hardcoded SEV-SNP guest policy checks during guest launch

This series removes some guest policy checks that can be better controlled by the SEV firmware.

- Remove the check for the SMT policy bit. Currently, a check is made to ensure the SMT policy bit is set to 1. However, there is no reason for KVM to do this. The SMT policy bit, when 0, is used to ensure that SMT has been disabled *in the BIOS.* As this does not require any special support within KVM, the check can be safely removed to allow the SEV firmware to determine whether the system meets the policy.

- Remove the check for the SINGLE_SOCKET policy bit. Currently, a check is made to ensure the SINGLE_SOCKET policy bit is set to 0. However, there is no reason for KVM to do this. The SINGLE_SOCKET policy bit, when 1, is used to ensure that an SNP guest is only run on a single socket. When the system only consists of a single socket, the SEV firmware allows guest activation to succeed. However, if the system has more than one socket, the SEV firmware will fail guest activation when the SNP_ACTIVATE command is used (which is the activation command used by KVM).

The SMT policy patch should not be controversial. The SINGLE_SOCKET policy patch could be a bit controversial, since, when you have the SINGLE_SOCKET policy bit set, you can have a guest that can run without issue on a single socket system, but suddenly fail when attempted to be started on a system with more than one socket. But, as this is opt-in behavior from userspace, this could be viewed as providing the protection that the guest owner desires.

In order to support use of the SINGLE_SOCKET policy bit on a system with more than one socket, the SNP_ACTIVATE_EX command must be used and proper scheduling support performed.

The series is based off of:
https://github.com/kvm-x86/linux.git next

Tom Lendacky (2):
KVM: SVM: Allow SNP guest policy disallow running with SMT enabled
KVM: SVM: Allow SNP guest policy to specify SINGLE_SOCKET

 arch/x86/kvm/svm/sev.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

base-commit: 3f7b307757ecffc1c18ede9ee3cf9ce8101f3cc9

Signature · 1 line
2.46.2