Skip to content

Device name and RCU string

David Sterba linux-btrfs oe-kbuild-all 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 10 repliesIn review
  2. v13 patches 5 repliesSuperseded

Changes in v2 from the cover letter

- drop patch adding RCU protection around update_dev_time(), there's a sleeping allocation inside; after revisiting the RCU requirements, I don't think it's needed and we can access the raw string (the same way it was done with rcu_string), the time update is called from scratch superblocks and after the ->dev_list hook is removed, so there's no chance it can be reached from device_list_add

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2btrfs: open code RCU for device namefs/btrfs/volumes.c fs/btrfs/volumes.h fs/btrfs/zoned.c+31 -249 replies
2/2btrfs: remove struct rcu_stringfs/btrfs/rcu-string.h fs/btrfs/volumes.c fs/btrfs/volumes.h +1 more+0 -430 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchDaniel Vacek
SeriesR-b
1/2
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/2] Device name and RCU string

v2:
- drop patch adding RCU protection around update_dev_time(), there's a sleeping allocation inside; after revisiting the RCU requirements, I don't think it's needed and we can access the raw string (the same way it was done with rcu_string), the time update is called from scratch superblocks and after the ->dev_list hook is removed, so there's no chance it can be reached from device_list_add

After recent simplifications of the RCU usage in messages, this patchset implements the RCU protection directly without the RCU string so this API can be removed completely as we don't have nor plan anything else to use it for.

David Sterba (2):
btrfs: open code RCU for device name
btrfs: remove struct rcu_string

 fs/btrfs/rcu-string.h | 40 ----------------------------------------
 fs/btrfs/volumes.c    | 29 +++++++++++++++++------------
 fs/btrfs/volumes.h    |  6 +++---
 fs/btrfs/zoned.c      | 23 +++++++++++------------
 4 files changed, 31 insertions(+), 67 deletions(-)
 delete mode 100644 fs/btrfs/rcu-string.h
Signature · 1 line
2.49.0