Skip to content

Set/get accessor cleanups

David Sterba linux-btrfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4btrfs: don't use token set/get accessors for btrfs_item membersfs/btrfs/ctree.c+18 -330 replies
2/4btrfs: don't use token set/get accessors in inode.c:fill_inode_item()fs/btrfs/inode.c+20 -300 replies
3/4btrfs: tree-log: don't use token set/get accessors in fill_inode_item()fs/btrfs/tree-log.c+19 -290 replies
4/4btrfs: accessors: delete token versions of set/get helpersfs/btrfs/accessors.c fs/btrfs/accessors.h+0 -1152 replies

Reviews trailers per patch

None of the 4 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchQu WenruoJohannes Thumshirn
SeriesR-b R-b
1/4
2/4
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/4] Set/get accessor cleanups

This patchset is first in a series to cleanup and optimize the accessors, now removing code that's not needed anymore, explained with references in the last patch.

Overall effects on .ko:

text data bss dec hex filename

1463615  115665   16088 1595368  1857e8 pre/btrfs.ko
1456601  115665   16088 1588354  183c82 post/btrfs.ko

DELTA: -7014

And stack consumption:

__push_leaf_left                                   -32 (176 -> 144)
copy_for_split                                     -32 (144 -> 112)
fill_inode_item                                    -32 (80 -> 48)
btrfs_truncate_item                                -24 (152 -> 128)
btrfs_extend_item                                  -16 (104 -> 88)
btrfs_del_items                                    -16 (144 -> 128)
setup_items_for_insert                             -32 (144 -> 112)
__push_leaf_right                                  -24 (168 -> 144)

REMOVED (744):

        btrfs_get_token_32                          88
        btrfs_set_token_64                          96
        btrfs_get_token_64                          88
        btrfs_set_token_32                          96
        btrfs_get_token_16                          88
        btrfs_get_token_8                           88
        btrfs_set_token_16                          96
        btrfs_set_token_8                           96

btrfs_init_map_token 8

REMOVED/NEW DELTA:  -744
PRE/POST DELTA:     -952

David Sterba (4):
btrfs: don't use token set/get accessors for btrfs_item members
btrfs: don't use token set/get accessors in inode.c:fill_inode_item()
btrfs: tree-log: don't use token set/get accessors in
fill_inode_item()
btrfs: accessors: delete token versions of set/get helpers

 fs/btrfs/accessors.c | 78 --------------------------------------------
 fs/btrfs/accessors.h | 37 ---------------------
 fs/btrfs/ctree.c     | 51 ++++++++++-------------------
 fs/btrfs/inode.c     | 50 ++++++++++++----------------
 fs/btrfs/tree-log.c  | 48 +++++++++++----------------
 5 files changed, 57 insertions(+), 207 deletions(-)
Signature · 1 line
2.49.0