Skip to content

RDMA/siw: [re-]introduce module parameters and add MPA V1

Stefan Metzmacher linux-rdma 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8RDMA/siw: make mpa_version = MPA_REVISION_2 constdrivers/infiniband/sw/siw/siw.h drivers/infiniband/sw/siw/siw_cm.c drivers/infiniband/sw/siw/siw_main.c+2 -80 replies
2/8RDMA/siw: remove unused loopback_enabled = truedrivers/infiniband/sw/siw/siw.h drivers/infiniband/sw/siw/siw_main.c+1 -51 reply
3/8RDMA/siw: add and remember siw_device_options per device.drivers/infiniband/sw/siw/siw.h drivers/infiniband/sw/siw/siw_main.c+19 -00 replies
4/8RDMA/siw: make use of sdev->options.* and avoid globalsdrivers/infiniband/sw/siw/siw_cm.c drivers/infiniband/sw/siw/siw_qp_tx.c drivers/infiniband/sw/siw/siw_verbs.c+29 -180 replies
5/8RDMA/siw: combine global options into siw_default_optionsdrivers/infiniband/sw/siw/siw.h drivers/infiniband/sw/siw/siw_main.c+34 -350 replies
6/8RDMA/siw: move rtr_type to siw_device_optionsdrivers/infiniband/sw/siw/siw.h drivers/infiniband/sw/siw/siw_cm.c drivers/infiniband/sw/siw/siw_main.c+8 -50 replies
7/8RDMA/siw: [re-]introduce module parameters to alter the behavior at runtimedrivers/infiniband/sw/siw/siw_cm.c drivers/infiniband/sw/siw/siw_main.c+111 -20 replies
8/8RDMA/siw: add support for MPA V1 and IRD/ORD negotiation based on [MS-SMBD]drivers/infiniband/sw/siw/iwarp.h drivers/infiniband/sw/siw/siw_cm.c drivers/infiniband/sw/siw/siw_cm.h +1 more+204 -220 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/8] RDMA/siw: [re-]introduce module parameters and add MPA V1

While working on smbdirect cleanup I'm using siw.ko for testing against Windows using Chelsio T404-BT (only supporting MPA V1) and T520-BT (supporting MPA V2) cards.

Up to now I used old patches to add MPA V1 support to siw.ko and compiled against the running kernel each time. I don't want to do that forever, so I re-introduced module parameters in order to avoid patching and compiling.

For my testing I'm using something like this:

echo 1 > /sys/module/siw/parameters/mpa_crc_required echo 1 > /sys/module/siw/parameters/mpa_crc_strict echo 0 > /sys/module/siw/parameters/mpa_rdma_write_rtr echo 1 > /sys/module/siw/parameters/mpa_peer_to_peer

echo 1 > /sys/module/siw/parameters/mpa_version
rdma link add siw_v1_eth0 type siw netdev eth0

echo 2 > /sys/module/siw/parameters/mpa_version
rdma link add siw_v2_eth1 type siw netdev eth1

The global parameters are copied at 'rdma link add' time and will stay as is for the lifetime of the specific device.

So I can testing against the T520-BT card using siw_v2_eth1 and against the T404-BT card using siw_v1_eth0.

It would be great if this can go upstream.

Stefan Metzmacher (8):
RDMA/siw: make mpa_version = MPA_REVISION_2 const RDMA/siw: remove unused loopback_enabled = true RDMA/siw: add and remember siw_device_options per device. RDMA/siw: make use of sdev->options.* and avoid globals RDMA/siw: combine global options into siw_default_options RDMA/siw: move rtr_type to siw_device_options
RDMA/siw: [re-]introduce module parameters to alter the behavior at
runtime
RDMA/siw: add support for MPA V1 and IRD/ORD negotiation based on

    [MS-SMBD]
 drivers/infiniband/sw/siw/iwarp.h     |   8 +
 drivers/infiniband/sw/siw/siw.h       |  21 +-
 drivers/infiniband/sw/siw/siw_cm.c    | 268 +++++++++++++++++++++-----
 drivers/infiniband/sw/siw/siw_cm.h    |   2 +
 drivers/infiniband/sw/siw/siw_main.c  | 173 ++++++++++++++---
 drivers/infiniband/sw/siw/siw_qp_tx.c |   3 +-
 drivers/infiniband/sw/siw/siw_verbs.c |   2 +-
 7 files changed, 395 insertions(+), 82 deletions(-)
Signature · 1 line
2.34.1