Skip to content

Improve KVM_SET_TSC_KHZ handling for CoCo VMs

Kai Huang kvm lkml 2 versions – Applied

Status from this message: Applied patch 2 to kvm-x86 fixes, with a tweaked changelog to call out that

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 5 repliesApplied
  2. v12 patches 14 repliesSuperseded

Changes in v2 from the cover letter

- Protect kvm->create_vcpus check using kvm->lock. - Chao.
- Add documentation update to each patch. -Nikunj.
- Collect RB (Xiaoyao, Nikunj).
- Switched the patch order to make documentation update easier.

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/2KVM: x86: Reject KVM_SET_TSC_KHZ VM ioctl when vCPUs have been createdDocumentation/virt/kvm/api.rst arch/x86/kvm/x86.c+7 -42 replies
2/2KVM: x86: Reject KVM_SET_TSC_KHZ vCPU ioctl for TSC protected guestDocumentation/virt/kvm/api.rst arch/x86/kvm/x86.c+11 -00 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchXiaoyao LiNikunj A DadhaniaChao Gao
1/2R-b R-b R-b
2/2R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCH v2 0/2] Improve KVM_SET_TSC_KHZ handling for CoCo VMs

This series follows Sean's suggestions [1][2] to:

- Reject vCPU scope KVM_SET_TSC_KHZ ioctl for TSC protected vCPU
- Reject VM scope KVM_SET_TSC_KHZ ioctl when vCPUs have been created

.. in the discussion of SEV-SNP Secure TSC support series.

v1 -> v2:
- Protect kvm->create_vcpus check using kvm->lock. - Chao.
- Add documentation update to each patch. -Nikunj.
- Collect RB (Xiaoyao, Nikunj).
- Switched the patch order to make documentation update easier.

v1: https://lore.kernel.org/kvm/[email protected]/

Hi Xiaoyao, Nikunj, I added your RB anyway, so let me know if you have concern :-)

This series has been sanity tested with TDX guests using today's Qemu:

- With this series Qemu can still run TDX guests successfully.
- With some hack to the Qemu, both VM and vCPU scope KVM_SET_TSC_KHZ ioctls failed as expected.

Kai Huang (2):
KVM: x86: Reject KVM_SET_TSC_KHZ VM ioctl when vCPUs have been created
KVM: x86: Reject KVM_SET_TSC_KHZ vCPU ioctl for TSC protected guest

 Documentation/virt/kvm/api.rst |  9 ++++++++-
 arch/x86/kvm/x86.c             | 13 ++++++++++---
 2 files changed, 18 insertions(+), 4 deletions(-)

base-commit: 6c7ecd725e503bf2ca69ff52c6cc48bb650b1f11

Signature · 1 line
2.50.0