Skip to content

commit: improve behaviour of core.commentChar=auto for comments in commit messages

Ayush Chandekar git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2commit: avoid scanning trailing comments when 'core.commentChar' is "auto"builtin/commit.c t/t3418-rebase-continue.sh+18 -10 replies
2/2config: set comment_line_str to "#" when core.commentChar=autoconfig.c+4 -27 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by.

PatchChristian CouderGhanshyam Thakkar
1/2Mentored-by Mentored-by
2/2Mentored-by Mentored-by

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [GSOC PATCH 0/2] commit: improve behaviour of core.commentChar=auto for comments in commit messages

Hey everyone,

The aim of this patch series is to improve the behaviour of core.commentChar=auto by the following patches:
1/2 - Fix a bug which reads comment character of the comments in commit message leading to change in the value of comment_line_str and thus resulting the comments in the final commit message. 2/2 - Standardizes the behaviour of code by resetting the 'comment_line_str' to "#" when core.commentChar is set to auto.

Thanks to Junio, Phillip and Kristoffer for reviewing the patches and also Christian for the reviews and mentoring me.

Ayush Chandekar (2):
commit: avoid scanning trailing comments when 'core.commentChar' is

    "auto"

config: set comment_line_str to "#" when core.commentChar=auto

 builtin/commit.c           |  6 +++++-
 config.c                   |  6 ++++--
 t/t3418-rebase-continue.sh | 13 +++++++++++++
 3 files changed, 22 insertions(+), 3 deletions(-)
Signature · 1 line
2.49.0