Skip to content

smack: clean up xattr handling

Konstantin Andreev linux-security-module 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest19 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/19smack: fix bug: changing Smack xattrs requires cap_sys_adminsecurity/smack/smack_lsm.c+1 -10 replies
2/19smack: fix bug: changing Smack xattrs requires cap_mac_overridesecurity/smack/smack_lsm.c+54 -510 replies
3/19smack: fix bug: setting label-containing xattrs silently ignores input garbagesecurity/smack/smack_lsm.c+57 -240 replies
4/19smack: stop polling other LSMs & VFS to getxattr() unsupported SMACK64IPIN/OUTsecurity/smack/smack_lsm.c+15 -170 replies
5/19smack: restrict getxattr() SMACK64TRANSMUTE to directoriessecurity/smack/smack_lsm.c+1 -10 replies
6/19smack: fix bug: getxattr() returns invalid SMACK64EXEC/MMAPsecurity/smack/smack_lsm.c+21 -150 replies
7/19smack: deduplicate task label validationsecurity/smack/smack_lsm.c+26 -210 replies
8/19smack: smack_inode_setsecurity: prevent setting SMACK64EXEC/MMAP in other LSMssecurity/smack/smack_lsm.c+4 -00 replies
9/19smack: smack_inode_setsecurity: prevent setting SMACK64IPIN/OUT in other LSMssecurity/smack/smack_lsm.c+9 -60 replies
10/19smack: fix bug: smack_inode_setsecurity() imports alien xattrs as labelssecurity/smack/smack_lsm.c+8 -40 replies
11/19smack: fix bug: smack_inode_setsecurity() false EINVAL for alien xattrssecurity/smack/smack_lsm.c+9 -80 replies
12/19smack: restrict setxattr() SMACK64IPIN/IPOUT to socketsDocumentation/admin-guide/LSM/Smack.rst security/smack/smack_lsm.c+11 -80 replies
13/19smack: restrict setxattr() SMACK64EXEC/MMAP to regular filessecurity/smack/smack_lsm.c+12 -80 replies
14/19smack: return EOPNOTSUPP for setxattr() unsupported SMACK64(TRANSMUTE)security/smack/smack_lsm.c+4 -30 replies
15/19smack: smack_inode_setsecurity(): skip checks for SMACK64TRANSMUTEsecurity/smack/smack_lsm.c+0 -40 replies
16/19smack: smack_inode_notifysecctx(): reject invalid labelssecurity/smack/smack_lsm.c+6 -00 replies
17/19smack: smack_inode_post_setxattr(): find label instead of importsecurity/smack/smack.h security/smack/smack_access.c security/smack/smack_lsm.c+34 -160 replies
18/19smack: smack_inode_setsecurity(): find label instead of importsecurity/smack/smack_lsm.c+5 -90 replies
19/19smack: deduplicate strcmp(name, XATTR_{,NAME_}SMACK*)security/smack/smack_lsm.c+109 -610 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/19] smack: clean up xattr handling

A set of minor bug fixes and optimizations in Smack xattr handling. Logically independent, but with the code dependencies.

The patch set applies on top of:
https://github.com/cschaufler/smack-next/commits/next
commit 6ddd169d0288

Konstantin Andreev (19):
smack: fix bug: changing Smack xattrs requires cap_sys_admin
smack: fix bug: changing Smack xattrs requires cap_mac_override
smack: fix bug: setting label-containing xattrs silently ignores input garbage
smack: stop polling other LSMs & VFS to getxattr() unsupported SMACK64IPIN/OUT
smack: restrict getxattr() SMACK64TRANSMUTE to directories
smack: fix bug: getxattr() returns invalid SMACK64EXEC/MMAP
smack: deduplicate task label validation
smack: smack_inode_setsecurity: prevent setting SMACK64EXEC/MMAP in other LSMs
smack: smack_inode_setsecurity: prevent setting SMACK64IPIN/OUT in other LSMs
smack: fix bug: smack_inode_setsecurity() imports alien xattrs as labels
smack: fix bug: smack_inode_setsecurity() false EINVAL for alien xattrs
smack: restrict setxattr() SMACK64IPIN/IPOUT to sockets
smack: restrict setxattr() SMACK64EXEC/MMAP to regular files
smack: return EOPNOTSUPP for setxattr() unsupported SMACK64(TRANSMUTE)
smack: smack_inode_setsecurity(): skip checks for SMACK64TRANSMUTE
smack: smack_inode_notifysecctx(): reject invalid labels
smack: smack_inode_post_setxattr(): find label instead of import
smack: smack_inode_setsecurity(): find label instead of import
smack: deduplicate strcmp(name, XATTR_{,NAME_}SMACK*)

 Documentation/admin-guide/LSM/Smack.rst |   3 +-
 security/smack/smack.h                  |   2 +
 security/smack/smack_access.c           |  22 +-
 security/smack/smack_lsm.c              | 492 +++++++++++++++---------
 4 files changed, 324 insertions(+), 195 deletions(-)
Signature · 1 line
2.43.0