Skip to content

Fix wrong type cast

Nam Cao linux-trace-kernel lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2Fix wrong type cast in monitors_show()kernel/trace/rv/rv.c+1 -13 replies
2/2Fix wrong type cast in reactors_show() and monitor_reactor_show()kernel/trace/rv/rv_reactors.c+2 -20 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchGabriele Monaco
1/2R-b
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] rv: Fix wrong type cast

Hi,

After my previous rv simplification series:
https://lore.kernel.org/linux-trace-kernel/[email protected]/T/#t

Some RV's available/enabled reactors/monitors files do not work anymore:

    root@yellow:~# cat /sys/kernel/tracing/rv/available_monitors
    nop: �������`������� ���������Z������u�����-s�����
    nop:���������������� �������@>H�����

nop:
��������
��������8�������:��������
`���������������

root@yellow:~# cat /sys/kernel/tracing/rv/available_reactors ��������8�������
P�������x������� 8����������������^�����81s������I?�������������8�������

It turned out that there has been a type cast mistake in RV all this time, but it still happened to work. Due to the recent refactor, the mistaken type cast got "promoted" and became a real problem.

This series fixes up this type cast.

Nam Cao (2):
rv: Fix wrong type cast in monitors_show()
rv: Fix wrong type cast in reactors_show() and monitor_reactor_show()

 kernel/trace/rv/rv.c          | 2 +-
 kernel/trace/rv/rv_reactors.c | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)
Signature · 1 line
2.39.5