Skip to content

Better handle and document Python needs for Kernel build

Mauro Carvalho Chehab linux-doc lkml workflows 2 versions – Applied

Status from this message: Applied, thanks.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 3 repliesApplied
  2. v12 patches 5 repliesSuperseded

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/2docs: kernel-doc: avoid script crash on ancient Pythonscripts/kernel-doc.py+24 -100 replies
2/2docs: changes: better document Python needsDocumentation/process/changes.rst+8 -12 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchAkira YokosawaRob Herring (Arm)
1/2
2/2A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/2] Better handle and document Python needs for Kernel build

Hi Jon,

It follows the second version of this small series. It contains missing patches from the python backward-compatibility series.

I dropped support for 2.7 and did some changes at changes.rst per Akira's request.

They're not urgent, IMO it should be OK to have them merged for 6.17.

The first patch ensures that kernel-doc won't crash with version 3.2 (tested on 3.4, as 3.2 is like an unicorn: docker containers v1 don't run anymore on Fedora, building is broken since at least Fedora 32, Anaconda doesn't have it anymore).

With this change, on elder versions, it would emit a warning and do nothing, as the actual code depends on features at 3.6 (f-strings) and 3.7 (ordered dict).

The second patch changes process/changes.rst. Currently, it makes one think that Python is optional. While not having python may work on some cases, it breaks on arm/arm64 with defconfigs. It also breaks with allyesconfig/almodconfig (at least on x86/x86_64), with clang (on some archs) and apparently on some other subsystems that I didn't care enough to identify, as for me, breaking on arm/arm64 with defconfigs, and on x86/x86_64 with allyesconfig/allmodconfig is enough evidence that this is mandatory nowadays.

So, remove optional from Python and add a quick description about where it is required, leaving it open to one's imagination that it could break with other configs we didn't map.

---
v2: drop support for 2.7, updated a comment and updated changes.rst.

Mauro Carvalho Chehab (2):
docs: kernel-doc: avoid script crash on ancient Python
docs: changes: better document Python needs

 Documentation/process/changes.rst |  9 +++++++-
 scripts/kernel-doc.py             | 34 ++++++++++++++++++++++---------
 2 files changed, 32 insertions(+), 11 deletions(-)
Signature · 1 line
2.49.0