Skip to content

btrfs: Misc test fixes for large block/node sizes

Nirjhar Roy (IBM) fstests linux-btrfs 4 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest4 patches 0 repliesNew
  2. v34 patches 10 repliesSuperseded
  3. v24 patches 8 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v17 patches20 repliesSuperseded

[v2] -> v3 from the cover letter

1. Fixed commit message typo for generic/563
2. Added RB of Qu for generic/274
3. Added RB of Ojaswin for all the patches.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4btrfs/301: Make the test compatible with all the supported block sizestests/btrfs/301+1 -10 replies
2/4generic/274: Make the pwrite block sizes and offsets to 64ktests/generic/274+4 -40 replies
3/4btrfs/137: Make this test compatible with all supported block sizestests/btrfs/137 tests/btrfs/137.out+39 -380 replies
4/4generic/563: Increase the iosize to cover for btrfs higher node sizestests/generic/563+1 -10 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchQu WenruoOjaswin Mujoo
1/4R-b R-b
2/4R-b R-b
3/4R-b R-b
4/4R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/4] btrfs: Misc test fixes for large block/node sizes

Some of the btrfs and generic tests are written with 4k block/node size in mind. This patch fixes some of those tests to be compatible with other block/node sizes too. We caught these bugs while running the auto group tests on btrfs with large block/node sizes.

[v2] -> v3
1. Fixed commit message typo for generic/563
2. Added RB of Qu for generic/274
3. Added RB of Ojaswin for all the patches.

[v2] -> v3
1. Added RBs by Qu Wenruo in btrfs/{301, 137}
2. Updated the commit message of generic/563 with a more detailed explanation by Qu Wenrou.
3. Reverted by block size from 64k to 4k while filling the filesystem with dd for test generic/274.

[v1] -> [v2]:
1. Removed the patch for btrfs/200 of [v1] - need more analysis on this.
2. Removed the first 2 patches of [v1] which introduced 2 new helper functions
3. btrfs/{137,301} and generic/274 - Instead of scaling the test dynamically based on the underlying disk block size, I have hardcoded the pwrite blocksizes and offsets to 64k which is aligned to all underlying fs block sizes <= 64.
4. For generic/563 - Doubled the iosize instead of btrfs specific hack to cover for btrfs write ranges.
5. Updated the commit messages

[v1] - https://lore.kernel.org/all/[email protected]/
[v2] - https://lore.kernel.org/all/[email protected]/
[v3] - https://lore.kernel.org/all/[email protected]/

Nirjhar Roy (IBM) (4):
btrfs/301: Make the test compatible with all the supported block sizes generic/274: Make the pwrite block sizes and offsets to 64k btrfs/137: Make this test compatible with all supported block sizes generic/563: Increase the iosize to cover for btrfs higher node sizes

 tests/btrfs/137     | 11 ++++----
 tests/btrfs/137.out | 66 ++++++++++++++++++++++-----------------------
 tests/btrfs/301     |  2 +-
 tests/generic/274   |  8 +++---
 tests/generic/563   |  2 +-
 5 files changed, 45 insertions(+), 44 deletions(-)

--
2.34.1