Skip to content

btrfs-progs: check for device item between super

Qu Wenruo linux-btrfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2btrfs-progs: fsck-tests: make the warning check more specific for 057tests/fsck-tests/057-seed-false-alerts/test.sh+3 -30 replies
2/2btrfs-progs: check that device byte values in superblock match those in chunk rootcheck/main.c+35 -00 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchBoris Burkov
SeriesR-b
1/2
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] btrfs-progs: check for device item between super

Mark has submitted a check enhancement for progs to detect the device item mismatch between super blocks and the items inside chunk tree.

However there is a long existing problem that it will break CI.

The root cause is that the CI kernel lacks the needed backports, that on a lot cases the kernel can lead to such mismatch and being caught by the newer progs.

So to merge this long existing fsck enhancement, this series refresh and workaround the problem by:

- Only reports warnings when such mismatch is detected
Such mismatch is not a huge deal, as we always trust the device item in chunk tree more than the super block one.
So it won't cause data loss or whatever.

So even if the CI kernel doesn't have the fix, self test cases won't report them as a failure.

- Workaround fsck/057 to avoid failure
Test case fsck/057 is a special case, where we manually check the output for warning messages.

This is originally to detect problems related seed device, but now it will also detect device item mismatch cause by the older CI kernel.

Workaround it by making the keyword more specific to the original problem, not just checking for warnings.

With those done, we can finally make CI to accept the new checks even the kernel is not uptodate.

Mark Harmstone (1):
btrfs-progs: check that device byte values in superblock match those
in chunk root

Qu Wenruo (1):
btrfs-progs: fsck-tests: make the warning check more specific for 057

 check/main.c                                  | 35 +++++++++++++++++++
 .../fsck-tests/057-seed-false-alerts/test.sh  |  6 ++--
 2 files changed, 38 insertions(+), 3 deletions(-)

--
2.50.1