mm/mremap: allow multi-VMA move for huge folio, find ineligible earlier
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest3 patches 10 repliesIn review 2 of 3 applied
Patches in v1 2 of 3 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | mm/mremap: allow multi-VMA move when filesystem uses thp_get_unmapped_areamm/ | +11 | 1 reply | Applied |
| 2/3 | mm/mremap: catch invalid multi VMA moves earliermm/ | +12 | 6 replies | |
| 3/3 | selftests/mm: add test for invalid multi VMA operationstools/ | +261 | 0 replies | Applied |
Reviews trailers per patch
2 of 3 patches have a Reviewed-by or Acked-by.
| Patch | Vlastimil Babka |
|---|---|
| 1/3 | R-b |
| 2/3 | R-b R-b |
| 3/3 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 6.17 0/3] mm/mremap: allow multi-VMA move for huge folio, find ineligible earlier
The multi-VMA move functionality introduced in commit d23cb648e365 ("mm/mremap: permit mremap() move of multiple VMA") doesn't allow moves of file-backed mappings which specify a custom f_op->get_unmapped_area handler excepting hugetlb and shmem.
We expand this to include thp_get_unmapped_area to support file-backed mappings for filesystems which use large folios.
Additionally, when the first VMA in a range is not compatible with a multi-VMA move, instead of moving the first VMA and returning an error, this series results in us not moving anything and returning an error immediately.
Examining this second change in detail:
The semantics of multi-VMA moves in mremap() very clearly indicate that a failure can result in a partial move of VMAs.
This is in line with other aggregate operations within the kernel, which share these semantics.
There are two classes of failures we're concerned with - eligiblity for mutli-VMA move, and transient failures that would occur even if the user individually moved each VMA.
The latter are either a product of the user using mremap() incorrectly or a failure due to out-of-memory conditions (which, given the allocations involved are small, would likely be fatal in any case), or hitting the mapping limit.
Regardless of the cause, transient issues would be fatal anyway, so it isn't really material which VMAs succeeded at being moved or not.
However with when it comes to multi-VMA move eligiblity, we face another issue - we must allow a single VMA to succeed regardless of this eligiblity (as, of course, it is not a multi-VMA move) - but we must then fail multi-VMA operations.
The two means by which VMAs may fail the eligbility test are - the VMAs being UFFD-armed, or the VMA being file-backed and providing its own f_op->get_unmapped_area() helper (because this may result in MREMAP_FIXED being disregarded), excepting those known to correctly handle MREMAP_FIXED.
It is therefore conceivable that a user could erroneously try to use this functionality in these instances, and would prefer to not perform any move at all should that occur.
This series therefore avoids any move of subsequent VMAs should the first be multi-VMA move ineligble and the input span exceeds that of the first VMA.
We also add detailed test logic to assert that multi VMA move with ineligible VMAs functions as expected.
Andrew - I think this should go in as a hot-fix for 6.17, as it would be better to change the semantics here before the functionality appears in a released kernel.
Lorenzo Stoakes (3):
mm/mremap: allow multi-VMA move when filesystem uses
thp_get_unmapped_area
mm/mremap: catch invalid multi VMA moves earlier selftests/mm: add test for invalid multi VMA operations
mm/mremap.c | 40 ++-- tools/testing/selftests/mm/mremap_test.c | 264 ++++++++++++++++++++++- 2 files changed, 284 insertions(+), 20 deletions(-)
--
2.50.1