Skip to content

smb:client: fix possible use after free problems

Stefan Metzmacher linux-cifs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5smb: client: let send_done() cleanup before calling smbd_disconnect_rdma_connection()fs/smb/client/smbdirect.c+8 -62 replies
2/5smb: client: remove separate empty_packet_queuefs/smb/client/cifs_debug.c fs/smb/client/smbdirect.c fs/smb/client/smbdirect.h+7 -650 replies
3/5smb: client: make sure we call ib_dma_unmap_single() only if we called ib_dma_map_single alreadyfs/smb/client/smbdirect.c+9 -20 replies
4/5smb: client: let recv_done() cleanup before notifying the callers.fs/smb/client/smbdirect.c+8 -60 replies
5/5smb: client: let recv_done() avoid touching data_transfer after cleanup/movefs/smb/client/smbdirect.c+11 -140 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/5] smb:client: fix possible use after free problems

While refactoring the client and server smbdirect code I noticed a few problems where we might hit use after free style problems.

In order to allow backports I decided to fix the problems before trying to move things to common code.

The server has similar problems, I'll send a separate patchset for the server as they are independed.

Stefan Metzmacher (5):
smb: client: let send_done() cleanup before calling
smbd_disconnect_rdma_connection()
smb: client: remove separate empty_packet_queue
smb: client: make sure we call ib_dma_unmap_single() only if we called
ib_dma_map_single already
smb: client: let recv_done() cleanup before notifying the callers.
smb: client: let recv_done() avoid touching data_transfer after
cleanup/move

 fs/smb/client/cifs_debug.c |   6 +-
 fs/smb/client/smbdirect.c  | 124 ++++++++++++-------------------------
 fs/smb/client/smbdirect.h  |   4 --
 3 files changed, 42 insertions(+), 92 deletions(-)
Signature · 1 line
2.43.0