Skip to content

smb:server: fix possible use after free problems

Stefan Metzmacher linux-cifs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4smb: server: remove separate empty_recvmsg_queuefs/smb/server/transport_rdma.c+8 -520 replies
2/4smb: server: make sure we call ib_dma_unmap_single() only if we called ib_dma_map_single alreadyfs/smb/server/transport_rdma.c+9 -20 replies
3/4smb: server: let recv_done() consitently call put_recvmsg/smb_direct_disconnect_rdma_connectionfs/smb/server/transport_rdma.c+13 -50 replies
4/4smb: server: let recv_done() avoid touching data_transfer after cleanup/movefs/smb/server/transport_rdma.c+7 -50 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] smb:server: fix possible use after free problems

While refactoring the client and server smbdirect code I noticed a few problems where we might hit use after free style problems.

In order to allow backports I decided to fix the problems before trying to move things to common code.

The client has similar problems, I've sent a separate patchset for the client already.

Stefan Metzmacher (4):
smb: server: remove separate empty_recvmsg_queue
smb: server: make sure we call ib_dma_unmap_single() only if we called
ib_dma_map_single already
smb: server: let recv_done() consitently call
put_recvmsg/smb_direct_disconnect_rdma_connection
smb: server: let recv_done() avoid touching data_transfer after
cleanup/move

 fs/smb/server/transport_rdma.c | 97 ++++++++++++----------------------
 1 file changed, 35 insertions(+), 62 deletions(-)
Signature · 1 line
2.43.0