Skip to content

drm/i915: vlv clock cleanups

Jani Nikula intel-gfx intel-xe 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest15 patches 12 repliesIn review
  2. v1 posting 2/212 patches 4 repliesSuperseded
  3. v1 posting 1/212 patches 2 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/15drm/i915: do cck get/put inside vlv_get_hpll_vco()drivers/gpu/drm/i915/display/intel_cdclk.c drivers/gpu/drm/i915/display/intel_display.c+8 -31 reply
2/15drm/i915: do cck get/put inside vlv_get_cck_clock()drivers/gpu/drm/i915/display/intel_cdclk.c drivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/gt/intel_rps.c+9 -141 reply
3/15drm/i915: add vlv_clock_get_gpll()drivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/display/intel_display.h drivers/gpu/drm/i915/gt/intel_rps.c+10 -40 replies
4/15drm/i915: add vlv_clock_get_czclk()drivers/gpu/drm/i915/display/intel_cdclk.c drivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/display/intel_display.h +2 more+20 -100 replies
5/15drm/i915: add vlv_clock_get_hrawclk()drivers/gpu/drm/i915/display/intel_cdclk.c drivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/display/intel_display.h+8 -80 replies
6/15drm/i915: make vlv_get_cck_clock_hpll() staticdrivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/display/intel_display.h+2 -40 replies
7/15drm/i915: add vlv_clock_get_cdclk()drivers/gpu/drm/i915/display/intel_cdclk.c drivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/display/intel_display.h+8 -30 replies
8/15drm/i915: make vlv_get_cck_clock() staticdrivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/display/intel_display.h+2 -40 replies
9/15drm/i915: rename vlv_get_hpll_vco() to vlv_clock_get_hpll_vco()drivers/gpu/drm/i915/display/intel_cdclk.c drivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/display/intel_display.h+5 -50 replies
10/15drm/i915: cache the results in vlv_clock_get_hpll_vco() and use it moredrivers/gpu/drm/i915/display/intel_cdclk.c drivers/gpu/drm/i915/display/intel_display.c+14 -233 replies
11/15drm/i915: remove vlv_get_cck_clock_hpll()drivers/gpu/drm/i915/display/intel_display.c+4 -91 reply
12/15drm/i915: remove intel_update_czclk() as unnecessarydrivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/display/intel_display.h drivers/gpu/drm/i915/display/intel_display_driver.c+3 -151 reply
13/15drm/i915: log HPLL frequency similar to CZCLKdrivers/gpu/drm/i915/display/intel_display.c+2 -00 replies
14/15drm/i915: move hpll and czclk caching under displaydrivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/display/intel_display_core.h drivers/gpu/drm/i915/i915_drv.h +1 more+16 -201 reply
15/15drm/i915: split out vlv_clock.[ch]drivers/gpu/drm/i915/Makefile drivers/gpu/drm/i915/display/intel_cdclk.c drivers/gpu/drm/i915/display/intel_display.c +5 more+123 -811 reply

Reviews trailers per patch

All 15 patches have a Reviewed-by or Acked-by.

PatchMika KaholaMichał GrzelakVille Syrjälä
1/15R-b
2/15R-b
3/15R-b R-b A-b
4/15R-b R-b A-b
5/15R-b A-b
6/15R-b A-b
7/15R-b A-b
8/15R-b A-b
9/15R-b A-b
10/15R-b A-b
11/15R-b
12/15R-b
13/15R-b A-b
14/15R-b
15/15R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCH v2 00/15] drm/i915: vlv clock cleanups

This is v2 of [1]. There were issues with sideband get/put, discovered in CI, so I ended up doing what Ville suggested in [2], and handling sideband get/put inside the functions. This is done in new patches 1-2, which obviously caused some rebase churn in the rest. I also removed vlv_get_cck_clock_hpll() completely, this is new patch 11.

I added r-b/ack from the previous version in some patches, dropped them from others, depending on how much changes there were. Sorry about the trouble, please look into this again.

BR,
Jani.

[1] https://lore.kernel.org/r/[email protected]
[2] https://lore.kernel.org/r/[email protected]

Jani Nikula (15):
drm/i915: do cck get/put inside vlv_get_hpll_vco() drm/i915: do cck get/put inside vlv_get_cck_clock() drm/i915: add vlv_clock_get_gpll()
drm/i915: add vlv_clock_get_czclk()
drm/i915: add vlv_clock_get_hrawclk()
drm/i915: make vlv_get_cck_clock_hpll() static drm/i915: add vlv_clock_get_cdclk()
drm/i915: make vlv_get_cck_clock() static
drm/i915: rename vlv_get_hpll_vco() to vlv_clock_get_hpll_vco() drm/i915: cache the results in vlv_clock_get_hpll_vco() and use it
more
drm/i915: remove vlv_get_cck_clock_hpll()
drm/i915: remove intel_update_czclk() as unnecessary drm/i915: log HPLL frequency similar to CZCLK
drm/i915: move hpll and czclk caching under display drm/i915: split out vlv_clock.[ch]

 drivers/gpu/drm/i915/Makefile                 |  1 +
 drivers/gpu/drm/i915/display/intel_cdclk.c    | 36 +++------
 drivers/gpu/drm/i915/display/intel_display.c  | 61 --------------
 drivers/gpu/drm/i915/display/intel_display.h  |  6 --
 .../gpu/drm/i915/display/intel_display_core.h |  5 ++
 .../drm/i915/display/intel_display_driver.c   |  1 -
 drivers/gpu/drm/i915/display/vlv_clock.c      | 81 +++++++++++++++++++
 drivers/gpu/drm/i915/display/vlv_clock.h      | 38 +++++++++
 drivers/gpu/drm/i915/gt/intel_rc6.c           |  3 +-
 drivers/gpu/drm/i915/gt/intel_rps.c           | 18 ++---
 drivers/gpu/drm/i915/i915_drv.h               |  3 -
 drivers/gpu/drm/xe/xe_device_types.h          |  6 --
 12 files changed, 145 insertions(+), 114 deletions(-)
 create mode 100644 drivers/gpu/drm/i915/display/vlv_clock.c
 create mode 100644 drivers/gpu/drm/i915/display/vlv_clock.h
Signature · 1 line
2.47.3