drm/i915: vlv clock cleanups
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest15 patches 12 repliesIn review
- v1 posting 2/212 patches 4 repliesSuperseded
- v1 posting 1/212 patches 2 repliesSuperseded
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/15 | drm/i915: do cck get/put inside vlv_get_hpll_vco()drivers/ drivers/ | +8 | 1 reply | |
| 2/15 | drm/i915: do cck get/put inside vlv_get_cck_clock()drivers/ drivers/ drivers/ | +9 | 1 reply | |
| 3/15 | drm/i915: add vlv_clock_get_gpll()drivers/ drivers/ drivers/ | +10 | 0 replies | |
| 4/15 | drm/i915: add vlv_clock_get_czclk()drivers/ drivers/ drivers/ +2 more | +20 | 0 replies | |
| 5/15 | drm/i915: add vlv_clock_get_hrawclk()drivers/ drivers/ drivers/ | +8 | 0 replies | |
| 6/15 | drm/i915: make vlv_get_cck_clock_hpll() staticdrivers/ drivers/ | +2 | 0 replies | |
| 7/15 | drm/i915: add vlv_clock_get_cdclk()drivers/ drivers/ drivers/ | +8 | 0 replies | |
| 8/15 | drm/i915: make vlv_get_cck_clock() staticdrivers/ drivers/ | +2 | 0 replies | |
| 9/15 | drm/i915: rename vlv_get_hpll_vco() to vlv_clock_get_hpll_vco()drivers/ drivers/ drivers/ | +5 | 0 replies | |
| 10/15 | drm/i915: cache the results in vlv_clock_get_hpll_vco() and use it moredrivers/ drivers/ | +14 | 3 replies | |
| 11/15 | drm/i915: remove vlv_get_cck_clock_hpll()drivers/ | +4 | 1 reply | |
| 12/15 | drm/i915: remove intel_update_czclk() as unnecessarydrivers/ drivers/ drivers/ | +3 | 1 reply | |
| 13/15 | drm/i915: log HPLL frequency similar to CZCLKdrivers/ | +2 | 0 replies | |
| 14/15 | drm/i915: move hpll and czclk caching under displaydrivers/ drivers/ drivers/ +1 more | +16 | 1 reply | |
| 15/15 | drm/i915: split out vlv_clock.[ch]drivers/ drivers/ drivers/ +5 more | +123 | 1 reply |
Reviews trailers per patch
All 15 patches have a Reviewed-by or Acked-by.
| Patch | Mika Kahola | Michał Grzelak | Ville Syrjälä |
|---|---|---|---|
| 1/15 | R-b | ||
| 2/15 | R-b | ||
| 3/15 | R-b | R-b | A-b |
| 4/15 | R-b | R-b | A-b |
| 5/15 | R-b | A-b | |
| 6/15 | R-b | A-b | |
| 7/15 | R-b | A-b | |
| 8/15 | R-b | A-b | |
| 9/15 | R-b | A-b | |
| 10/15 | R-b | A-b | |
| 11/15 | R-b | ||
| 12/15 | R-b | ||
| 13/15 | R-b | A-b | |
| 14/15 | R-b | ||
| 15/15 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v2 00/15] drm/i915: vlv clock cleanups
This is v2 of [1]. There were issues with sideband get/put, discovered in CI, so I ended up doing what Ville suggested in [2], and handling sideband get/put inside the functions. This is done in new patches 1-2, which obviously caused some rebase churn in the rest. I also removed vlv_get_cck_clock_hpll() completely, this is new patch 11.
I added r-b/ack from the previous version in some patches, dropped them from others, depending on how much changes there were. Sorry about the trouble, please look into this again.
BR,
Jani.
[1] https://lore.kernel.org/r/[email protected]
[2] https://lore.kernel.org/r/[email protected]
Jani Nikula (15):
drm/i915: do cck get/put inside vlv_get_hpll_vco() drm/i915: do cck get/put inside vlv_get_cck_clock() drm/i915: add vlv_clock_get_gpll()
drm/i915: add vlv_clock_get_czclk()
drm/i915: add vlv_clock_get_hrawclk()
drm/i915: make vlv_get_cck_clock_hpll() static drm/i915: add vlv_clock_get_cdclk()
drm/i915: make vlv_get_cck_clock() static
drm/i915: rename vlv_get_hpll_vco() to vlv_clock_get_hpll_vco() drm/i915: cache the results in vlv_clock_get_hpll_vco() and use it
more
drm/i915: remove vlv_get_cck_clock_hpll()
drm/i915: remove intel_update_czclk() as unnecessary drm/i915: log HPLL frequency similar to CZCLK
drm/i915: move hpll and czclk caching under display drm/i915: split out vlv_clock.[ch]
drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/display/intel_cdclk.c | 36 +++------ drivers/gpu/drm/i915/display/intel_display.c | 61 -------------- drivers/gpu/drm/i915/display/intel_display.h | 6 -- .../gpu/drm/i915/display/intel_display_core.h | 5 ++ .../drm/i915/display/intel_display_driver.c | 1 - drivers/gpu/drm/i915/display/vlv_clock.c | 81 +++++++++++++++++++ drivers/gpu/drm/i915/display/vlv_clock.h | 38 +++++++++ drivers/gpu/drm/i915/gt/intel_rc6.c | 3 +- drivers/gpu/drm/i915/gt/intel_rps.c | 18 ++--- drivers/gpu/drm/i915/i915_drv.h | 3 - drivers/gpu/drm/xe/xe_device_types.h | 6 -- 12 files changed, 145 insertions(+), 114 deletions(-) create mode 100644 drivers/gpu/drm/i915/display/vlv_clock.c create mode 100644 drivers/gpu/drm/i915/display/vlv_clock.h
Signature · 1 line
2.47.3