Skip to content

mptcp: disable add_addr retrans

Geliang Tang mptcp 2 versions – Applied

Status from this message: Applied to our tree (fixes for -net):

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 3 repliesApplied
  2. v12 patches 3 repliesSuperseded

Changes in v2 from the cover letter

- move "remove duplicate sk_reset_timer call" into this set.
- check add_addr timeout value in mptcp_pm_alloc_anno_list() too.

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/3mptcp: remove duplicate sk_reset_timer callnet/mptcp/pm.c+2 -30 replies
2/3mptcp: disable add_addr retransmission when timeout is 0Documentation/networking/mptcp-sysctl.rst net/mptcp/pm.c+12 -30 replies
3/3selftests: mptcp: disable add_addr retrans in endpoint_teststools/testing/selftests/net/mptcp/mptcp_join.sh+1 -00 replies

Reviews trailers per patch

None of the 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMatthieu Baerts (NGI0)
SeriesR-b
1/3
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH mptcp-net v2 0/3] mptcp: disable add_addr retrans

From: Geliang Tang <[email protected]>

v2:
- move "remove duplicate sk_reset_timer call" into this set.
- check add_addr timeout value in mptcp_pm_alloc_anno_list() too.

This series enhances MPTCP's ADD_ADDR retransmission mechanism by:

1. Adding support for disabling retransmissions when add_addr_timeout is set to 0
2. Modifying the self-tests to leverage this new capability

The first patch implements the core functionality change in the MPTCP subsystem, while the second patch updates the selftests to use this feature for stabilizing a specific test case.

These changes provide more control over ADD_ADDR behavior and improve test reliability by eliminating race conditions caused by unexpected retransmissions.

Patch 1: Remove duplicate sk_reset_timer call
Patch 2: When add_addr_timeout is 0, skip retransmission entirely Patch 3: Disable retransmissions in "delete re-add signal" test

Geliang Tang (3):
mptcp: remove duplicate sk_reset_timer call
mptcp: disable add_addr retransmission when timeout is 0
selftests: mptcp: disable add_addr retrans in endpoint_tests

 Documentation/networking/mptcp-sysctl.rst      |  2 ++
 net/mptcp/pm.c                                 | 18 ++++++++++++------
 .../testing/selftests/net/mptcp/mptcp_join.sh  |  1 +
 3 files changed, 15 insertions(+), 6 deletions(-)
Signature · 1 line
2.48.1