Skip to content

smb: smbdirect: more use of common structures e.g. smbdirect_send_io

Stefan Metzmacher linux-cifs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest18 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/18smb: client: remove unused enum smbd_connection_statusfs/smb/client/smbdirect.h+0 -100 replies
2/18smb: smbdirect: add SMBDIRECT_RECV_IO_MAX_SGEfs/smb/common/smbdirect/smbdirect_socket.h+7 -00 replies
3/18smb: client: make use of SMBDIRECT_RECV_IO_MAX_SGEfs/smb/client/smbdirect.c fs/smb/client/smbdirect.h+2 -50 replies
4/18smb: smbdirect: introduce struct smbdirect_send_iofs/smb/common/smbdirect/smbdirect_socket.h+24 -00 replies
5/18smb: client: make use of struct smbdirect_send_iofs/smb/client/smbdirect.c fs/smb/client/smbdirect.h+23 -380 replies
6/18smb: smbdirect: add smbdirect_socket.{send,recv}_io.mem.{cache,pool}fs/smb/common/smbdirect/smbdirect_socket.h+23 -00 replies
7/18smb: client: make use of smbdirect_socket.{send,recv}_io.mem.{cache,pool}fs/smb/client/smbdirect.c fs/smb/client/smbdirect.h+34 -400 replies
8/18smb: server: make use of common smbdirect_pdu.hfs/smb/server/transport_rdma.c fs/smb/server/transport_rdma.h+25 -652 replies
9/18smb: server: make use of common smbdirect.hfs/smb/server/connection.c fs/smb/server/connection.h fs/smb/server/smb2pdu.c +2 more+18 -200 replies
10/18smb: server: make use of common smbdirect_socketfs/smb/server/transport_rdma.c+137 -1120 replies
11/18smb: server: make use of common smbdirect_socket_parametersfs/smb/server/transport_rdma.c+44 -410 replies
12/18smb: server: make use of smbdirect_socket->recv_io.expectedfs/smb/server/transport_rdma.c+25 -190 replies
13/18smb: server: make use of struct smbdirect_recv_iofs/smb/server/transport_rdma.c+26 -350 replies
14/18smb: server: make use of smbdirect_socket.recv_io.free.{list,lock}fs/smb/server/transport_rdma.c+12 -150 replies
15/18smb: server: make use of smbdirect_socket.recv_io.reassembly.*fs/smb/server/transport_rdma.c+43 -470 replies
16/18smb: server: make use of SMBDIRECT_RECV_IO_MAX_SGEfs/smb/server/transport_rdma.c+2 -30 replies
17/18smb: server: make use of struct smbdirect_send_iofs/smb/server/transport_rdma.c+36 -450 replies
18/18smb: server: make use of smbdirect_socket.{send,recv}_io.mem.{cache,pool}fs/smb/server/transport_rdma.c+23 -270 replies

Reviews trailers per patch

None of the 18 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchNamjae Jeon
SeriesA-b
1/18
2/18
3/18
4/18
5/18
6/18
7/18
8/18
9/18
10/18
11/18
12/18
13/18
14/18
15/18
16/18
17/18
18/18

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/18] smb: smbdirect: more use of common structures e.g. smbdirect_send_io

Hi,

this is the next step towards a common smbdirect layer between cifs.ko and ksmbd.ko, with the aim to provide a socket layer for userspace usage at the end of the road.

This patchset focuses on the usage of a common smbdirect_send_io and related structures in smbdirect_socket.send_io.

Note only patches 01-08 are intended to be merged soon, while the ksmbd patches 09-18 are only posted for completeness (as discussed with Namjae) to get early feedback.

I used the following xfstests as regression tests:
cifs/001 generic/001 generic/002 generic/005 generic/006 generic/007 generic/010 generic/011

Between cifs.ko against ksmbd.ko via siw.ko in all combinations with and without the patchset on each side.

Stefan Metzmacher (18):
smb: client: remove unused enum smbd_connection_status
smb: smbdirect: add SMBDIRECT_RECV_IO_MAX_SGE
smb: client: make use of SMBDIRECT_RECV_IO_MAX_SGE
smb: smbdirect: introduce struct smbdirect_send_io
smb: client: make use of struct smbdirect_send_io
smb: smbdirect: add smbdirect_socket.{send,recv}_io.mem.{cache,pool}
smb: client: make use of

    smbdirect_socket.{send,recv}_io.mem.{cache,pool}
  smb: server: make use of common smbdirect_pdu.h
  smb: server: make use of common smbdirect.h
  smb: server: make use of common smbdirect_socket
  smb: server: make use of common smbdirect_socket_parameters
  smb: server: make use of smbdirect_socket->recv_io.expected
  smb: server: make use of struct smbdirect_recv_io
  smb: server: make use of smbdirect_socket.recv_io.free.{list,lock}
  smb: server: make use of smbdirect_socket.recv_io.reassembly.*
  smb: server: make use of SMBDIRECT_RECV_IO_MAX_SGE
  smb: server: make use of struct smbdirect_send_io
  smb: server: make use of
    smbdirect_socket.{send,recv}_io.mem.{cache,pool}
 fs/smb/client/smbdirect.c                  | 112 ++--
 fs/smb/client/smbdirect.h                  |  38 --
 fs/smb/common/smbdirect/smbdirect_socket.h |  54 ++
 fs/smb/server/connection.c                 |   4 +-
 fs/smb/server/connection.h                 |  10 +-
 fs/smb/server/smb2pdu.c                    |  11 +-
 fs/smb/server/smb2pdu.h                    |   6 -
 fs/smb/server/transport_rdma.c             | 742 +++++++++++----------
 fs/smb/server/transport_rdma.h             |  41 --
 9 files changed, 500 insertions(+), 518 deletions(-)
Signature · 1 line
2.43.0