rtla: fix cgroup and trace options parsing
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest2 patches 0 repliesNew
- v42 patches 0 repliesSuperseded
- v33 patches 5 repliesSuperseded
Earlier versions · 2
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 | 3 patches | 5 replies | Superseded | |
| v1 | 3 patches | 1 reply | Superseded |
Changes in v5 from the cover letter
- Removed setting trace_output before checking if it's NULL in fix -a overriding -t argument patch
Patches in v5 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | rtla: fix -C/--cgroup interfaceDocumentation/ tools/ tools/ +4 more | +56 | 0 replies | |
| 2/2 | rtla: fix -a overriding -t argumenttools/ tools/ tools/ +1 more | +8 | 0 replies |
Reviews trailers per patch
All 2 patches have a Reviewed-by or Acked-by.
| Patch | Tomas Glozar |
|---|---|
| 1/2 | R-b |
| 2/2 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v5 0/2] rtla: fix cgroup and trace options parsing
This series fixes 2 issue in rtla timerlat and osnoise parsing.
1. Make -C/--cgroup option more user-friendly. Currently rtla timerlat and osnoise parses does not allow to specify tracer's threads cgroup name as -C [cgroup] or --cgroup [cgroup]. Second patch fixes this by allowing users to specify cgroup in the aforementioned manner.
2. When specifying -t/--trace before -a/--auto, trace filename is override to default <osnoise|timerlat>_trace.txt. For example, when running rtla as
rtla timerlat top -t custom_file.txt -a 100
when the threshold is reached, timerlat_trace.txt file is created instead of specified custom_file.txt. Third patch addresses this issue.
changes v4 -> v5:
- Removed setting trace_output before checking if it's NULL in fix -a overriding -t argument patch
changes v3 -> v4:
- Removed patch [1] as it has been mainlined
- Resolved merge conflicts with [2]
changes v2 -> v3:
- Combined common logic into a utility function to parse optional argument value
- Removed change that removed clear_terminal
changes v1 -> v2:
- Moved removing clear_terminal from fix -C/--cgroup interface patch to fix -a overriding -t argument patch
- Added clarification why to remove clear_terminal
- Added Fixes: tag to the fix -C/--cgroup interface patch
v4: https://lore.kernel.org/all/[email protected]/
v3: https://lore.kernel.org/all/[email protected]/
v2: https://lore.kernel.org/all/[email protected]/
v1: https://lore.kernel.org/all/[email protected]/
[1] https://lore.kernel.org/all/164ffc2ec8edacaf1295789dad82a07817b6263d.1757034919.git.ipravdin.official@gmail.com/
[2] https://patchwork.kernel.org/project/linux-trace-kernel/list/?series=999703
Ivan Pravdin (2):
rtla: fix -C/--cgroup interface
rtla: fix -a overriding -t argument
Documentation/tools/rtla/common_options.rst | 2 +- tools/tracing/rtla/src/osnoise_hist.c | 29 +++++++-------------- tools/tracing/rtla/src/osnoise_top.c | 29 +++++++-------------- tools/tracing/rtla/src/timerlat_hist.c | 29 +++++++-------------- tools/tracing/rtla/src/timerlat_top.c | 29 +++++++-------------- tools/tracing/rtla/src/utils.c | 26 ++++++++++++++++++ tools/tracing/rtla/src/utils.h | 1 + 7 files changed, 64 insertions(+), 81 deletions(-)
Signature · 1 line
2.48.1