Skip to content

efi: stmm: Fix for incorrect buffer allocation and cleanups

Jan Kiszka linux-efi lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 2 repliesIn review
  2. v24 patches 3 repliesSuperseded
  3. v13 patches 10 repliesSuperseded

Changes in v3 from the cover letter

- improve description of patch 3

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4efi: stmm: Fix incorrect buffer allocation methoddrivers/firmware/efi/stmm/tee_stmm_efi.c+12 -90 replies
2/4efi: stmm: Do not return EFI_OUT_OF_RESOURCES on internal errorsdrivers/firmware/efi/stmm/tee_stmm_efi.c+6 -60 replies
3/4efi: stmm: Drop unused EFI error from setup_mm_hdr argumentsdrivers/firmware/efi/stmm/tee_stmm_efi.c+8 -170 replies
4/4efi: stmm: Drop unneeded null pointer checkdrivers/firmware/efi/stmm/tee_stmm_efi.c+1 -20 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchIlias ApalodimasSumit Garg
SeriesA-b
1/4A-b
2/4R-b
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/4] efi: stmm: Fix for incorrect buffer allocation and cleanups

Changes in v3:
- improve description of patch 3

Changes in v2:
- simplify page allocation approach
- switch to returning EFI_DEVICE_ERROR on ENOMEM
- drop efi return value argument from setup_mm_hdr

One critical fix for the EFI StMM driver, one error return code adjustment and two smaller cleanups.

Note that the suggestion to convert tee_shm_register_kernel_buf to take pages instead of buffer addresses is not forgotten, just in the backlog. I wanted to avoid that the critical fix has to wait for me finding time to refactor the API as well.

Jan

Jan Kiszka (4):
efi: stmm: Fix incorrect buffer allocation method
efi: stmm: Do not return EFI_OUT_OF_RESOURCES on internal errors
efi: stmm: Drop unused EFI error from setup_mm_hdr arguments
efi: stmm: Drop unneeded null pointer check

 drivers/firmware/efi/stmm/tee_stmm_efi.c | 61 +++++++++++-------------
 1 file changed, 27 insertions(+), 34 deletions(-)
Signature · 1 line
2.43.0