Skip to content

drm/i915/display: convert to generic poll_timeout_us()

Jani Nikula intel-gfx intel-xe 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest20 patches 21 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/20drm/i915/hdmi: use generic poll_timeout_us() instead of __wait_for()drivers/gpu/drm/i915/display/intel_hdmi.c+5 -52 replies
2/20drm/i915/hdcp: use generic poll_timeout_us() instead of __wait_for()drivers/gpu/drm/i915/display/intel_hdcp.c+4 -41 reply
3/20drm/i915/hdcp: use generic poll_timeout_us() instead of wait_for()drivers/gpu/drm/i915/display/intel_hdcp.c+10 -71 reply
4/20drm/i915/dsi: use generic poll_timeout_us() instead of wait_for_us()drivers/gpu/drm/i915/display/icl_dsi.c+14 -41 reply
5/20drm/i915/dsi-pll: use generic poll_timeout_us() instead of wait_for()drivers/gpu/drm/i915/display/vlv_dsi_pll.c+7 -41 reply
6/20drm/i915/gmbus: use generic poll_timeout*() instead of wait_for*()drivers/gpu/drm/i915/display/intel_gmbus.c+8 -51 reply
7/20drm/i915/wm: use generic poll_timeout_us() instead of wait_for()drivers/gpu/drm/i915/display/i9xx_wm.c+12 -41 reply
8/20drm/i915/cdclk: use generic poll_timeout_us() instead of wait_for()drivers/gpu/drm/i915/display/intel_cdclk.c+20 -171 reply
9/20drm/i915/power: use generic poll_timeout_us() instead of wait_for()drivers/gpu/drm/i915/display/intel_display_power.c+5 -21 reply
10/20drm/i915/power-well: use generic poll_timeout_us() instead of wait_for() for DKL PHYdrivers/gpu/drm/i915/display/intel_display_power_well.c+9 -41 reply
11/20drm/i915/power-well: use generic poll_timeout_us() instead of wait_for() for VLV/CHVdrivers/gpu/drm/i915/display/intel_display_power_well.c+15 -141 reply
12/20drm/i915/dp: use generic poll_timeout_us() instead of wait_for()drivers/gpu/drm/i915/display/intel_dp.c+11 -101 reply
13/20drm/i915/dp: use generic poll_timeout_us() instead of wait_for() in link trainingdrivers/gpu/drm/i915/display/intel_dp_link_training.c+13 -41 reply
14/20drm/i915/vblank: use generic poll_timeout_us() instead of wait_for()drivers/gpu/drm/i915/display/intel_vblank.c+8 -11 reply
15/20drm/i915/tc: use generic poll_timeout_us() instead of wait_for()drivers/gpu/drm/i915/display/intel_tc.c+14 -21 reply
16/20drm/i915/dsb: use generic poll_timeout_us() instead of wait_for()drivers/gpu/drm/i915/display/intel_dsb.c+8 -21 reply
17/20drm/i915/lspcon: use generic poll_timeout_us() instead of wait_for()drivers/gpu/drm/i915/display/intel_lspcon.c+10 -31 reply
18/20drm/i915/opregion: use generic poll_timeout_us() instead of wait_for()drivers/gpu/drm/i915/display/intel_opregion.c+6 -41 reply
19/20drm/i915/ddi: prefer poll_timeout_us() over readx_poll_timeout()drivers/gpu/drm/i915/display/intel_ddi.c+11 -211 reply
20/20drm/i915/pps: prefer poll_timeout_us() over read_poll_timeout()drivers/gpu/drm/i915/display/intel_pps.c+3 -51 reply

Reviews trailers per patch

All 20 patches have a Reviewed-by or Acked-by.

PatchJouni Högander
1/20R-b
2/20R-b
3/20R-b
4/20R-b
5/20R-b
6/20R-b
7/20R-b
8/20R-b
9/20R-b
10/20R-b
11/20R-b
12/20R-b
13/20R-b
14/20R-b
15/20R-b
16/20R-b
17/20R-b
18/20R-b
19/20R-b
20/20R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/20] drm/i915/display: convert to generic poll_timeout_us()

Completely remove the remaining custom i915_utils.h wait macro usage from display code, and unify on the kernel generic poll_timeout_us() poll waiter. Also convert existing read_poll_timeout() and readx_poll_timeout() to poll_timeout_us().

This is a rewrite of [1] switching to the new poll_timeout_us() instead of read_poll_timeout().

The main functional change is losing the exponentially growing sleep from the custom macros. This is highlighted in each commit message with details.

BR,
Jani.

[1] https://lore.kernel.org/r/[email protected]

Jani Nikula (20):
drm/i915/hdmi: use generic poll_timeout_us() instead of __wait_for() drm/i915/hdcp: use generic poll_timeout_us() instead of __wait_for() drm/i915/hdcp: use generic poll_timeout_us() instead of wait_for() drm/i915/dsi: use generic poll_timeout_us() instead of wait_for_us() drm/i915/dsi-pll: use generic poll_timeout_us() instead of wait_for() drm/i915/gmbus: use generic poll_timeout*() instead of wait_for*() drm/i915/wm: use generic poll_timeout_us() instead of wait_for() drm/i915/cdclk: use generic poll_timeout_us() instead of wait_for() drm/i915/power: use generic poll_timeout_us() instead of wait_for() drm/i915/power-well: use generic poll_timeout_us() instead of
wait_for() for DKL PHY
drm/i915/power-well: use generic poll_timeout_us() instead of
wait_for() for VLV/CHV
drm/i915/dp: use generic poll_timeout_us() instead of wait_for() drm/i915/dp: use generic poll_timeout_us() instead of wait_for() in
link training
drm/i915/vblank: use generic poll_timeout_us() instead of wait_for() drm/i915/tc: use generic poll_timeout_us() instead of wait_for() drm/i915/dsb: use generic poll_timeout_us() instead of wait_for() drm/i915/lspcon: use generic poll_timeout_us() instead of wait_for() drm/i915/opregion: use generic poll_timeout_us() instead of wait_for() drm/i915/ddi: prefer poll_timeout_us() over readx_poll_timeout() drm/i915/pps: prefer poll_timeout_us() over read_poll_timeout()

 drivers/gpu/drm/i915/display/i9xx_wm.c        | 16 +++++--
 drivers/gpu/drm/i915/display/icl_dsi.c        | 18 ++++++--
 drivers/gpu/drm/i915/display/intel_cdclk.c    | 37 ++++++++--------
 drivers/gpu/drm/i915/display/intel_ddi.c      | 32 +++++---------
 .../drm/i915/display/intel_display_power.c    |  7 +++-
 .../i915/display/intel_display_power_well.c   | 42 +++++++++++--------
 drivers/gpu/drm/i915/display/intel_dp.c       | 21 +++++-----
 .../drm/i915/display/intel_dp_link_training.c | 17 ++++++--
 drivers/gpu/drm/i915/display/intel_dsb.c      | 10 ++++-
 drivers/gpu/drm/i915/display/intel_gmbus.c    | 13 +++---
 drivers/gpu/drm/i915/display/intel_hdcp.c     | 25 ++++++-----
 drivers/gpu/drm/i915/display/intel_hdmi.c     | 10 ++---
 drivers/gpu/drm/i915/display/intel_lspcon.c   | 13 ++++--
 drivers/gpu/drm/i915/display/intel_opregion.c | 10 +++--
 drivers/gpu/drm/i915/display/intel_pps.c      |  8 ++--
 drivers/gpu/drm/i915/display/intel_tc.c       | 16 ++++++-
 drivers/gpu/drm/i915/display/intel_vblank.c   |  9 +++-
 drivers/gpu/drm/i915/display/vlv_dsi_pll.c    | 11 +++--
 18 files changed, 193 insertions(+), 122 deletions(-)
Signature · 1 line
2.47.2