Skip to content

drm/{i915, xe}/panic: refactor framebuffer allocation etc.

Jani Nikula intel-gfx intel-xe 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8drm/i915/fb: add intel_framebuffer_alloc()drivers/gpu/drm/i915/display/i9xx_plane.c drivers/gpu/drm/i915/display/intel_fb.c drivers/gpu/drm/i915/display/intel_fb.h +1 more+11 -40 replies
2/8drm/{i915,xe}/panic: split out intel_panic.[ch]drivers/gpu/drm/i915/Makefile drivers/gpu/drm/i915/display/i9xx_plane.c drivers/gpu/drm/i915/display/intel_bo.c +9 more+136 -1100 replies
3/8drm/{i915, xe}/panic: rename intel_bo_panic_*() to intel_panic_*()drivers/gpu/drm/i915/display/intel_panic.c drivers/gpu/drm/i915/display/intel_panic.h drivers/gpu/drm/i915/display/intel_plane.c +1 more+8 -80 replies
4/8drm/{i915, xe}/fb: add panic pointer member to struct intel_framebufferdrivers/gpu/drm/i915/display/intel_display_types.h drivers/gpu/drm/i915/gem/i915_gem_pages.c drivers/gpu/drm/xe/display/xe_panic.c+19 -220 replies
5/8drm/{i915, xe}/panic: rename struct {i915, xe}_panic_data to struct intel_panicdrivers/gpu/drm/i915/display/intel_display_types.h drivers/gpu/drm/i915/gem/i915_gem_pages.c drivers/gpu/drm/xe/display/xe_panic.c+14 -130 replies
6/8drm/{i915, xe}/panic: move framebuffer allocation where it belongsdrivers/gpu/drm/i915/display/intel_fb.c drivers/gpu/drm/i915/display/intel_panic.c drivers/gpu/drm/i915/display/intel_panic.h +3 more+31 -324 replies
7/8drm/{i915, xe}/panic: convert intel_panic_finish() to struct intel_panicdrivers/gpu/drm/i915/display/intel_panic.c drivers/gpu/drm/i915/display/intel_panic.h drivers/gpu/drm/i915/display/intel_plane.c +3 more+7 -130 replies
8/8drm/{i915, xe}/panic: pass struct intel_panic to intel_panic_setup()drivers/gpu/drm/i915/display/intel_panic.c drivers/gpu/drm/i915/display/intel_panic.h drivers/gpu/drm/i915/display/intel_plane.c +3 more+18 -140 replies

Reviews trailers per patch

None of the 8 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchJocelyn Falempe
SeriesR-b
1/8
2/8
3/8
4/8
5/8
6/8
7/8
8/8

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/8] drm/{i915, xe}/panic: refactor framebuffer allocation etc.

Split out intel_panic functionality separate from intel_bo abstraction, and lift the framebuffer allocation back to where it belongs in intel_fb.c.

There's more that should be improved, ideally making struct intel_framebuffer opaque towards i915 and xe, but this already goes along way in adjusting where the abstractions should happen.

BR,
Jani.

Cc Jocelyn Falempe <[email protected]>
Cc Maarten Lankhorst <[email protected]>

Jani Nikula (8):
drm/i915/fb: add intel_framebuffer_alloc() drm/{i915,xe}/panic: split out intel_panic.[ch] drm/{i915,xe}/panic: rename intel_bo_panic_*() to intel_panic_*() drm/{i915,xe}/fb: add panic pointer member to struct intel_framebuffer drm/{i915,xe}/panic: rename struct {i915,xe}_panic_data to struct
intel_panic
drm/{i915,xe}/panic: move framebuffer allocation where it belongs drm/{i915,xe}/panic: convert intel_panic_finish() to struct
intel_panic
drm/{i915,xe}/panic: pass struct intel_panic to intel_panic_setup()

 drivers/gpu/drm/i915/Makefile                 |  1 +
 drivers/gpu/drm/i915/display/i9xx_plane.c     |  4 +-
 drivers/gpu/drm/i915/display/intel_bo.c       | 15 ---
 drivers/gpu/drm/i915/display/intel_bo.h       |  3 -
 .../drm/i915/display/intel_display_types.h    |  2 +
 drivers/gpu/drm/i915/display/intel_fb.c       | 23 ++++-
 drivers/gpu/drm/i915/display/intel_fb.h       |  3 +
 drivers/gpu/drm/i915/display/intel_panic.c    | 27 ++++++
 drivers/gpu/drm/i915/display/intel_panic.h    | 14 +++
 drivers/gpu/drm/i915/display/intel_plane.c    |  6 +-
 .../drm/i915/display/skl_universal_plane.c    |  3 +-
 drivers/gpu/drm/i915/gem/i915_gem_object.h    | 11 ++-
 drivers/gpu/drm/i915/gem/i915_gem_pages.c     | 40 +++-----
 drivers/gpu/drm/xe/Makefile                   |  1 +
 drivers/gpu/drm/xe/display/intel_bo.c         | 91 -------------------
 drivers/gpu/drm/xe/display/xe_panic.c         | 80 ++++++++++++++++
 16 files changed, 176 insertions(+), 148 deletions(-)
 create mode 100644 drivers/gpu/drm/i915/display/intel_panic.c
 create mode 100644 drivers/gpu/drm/i915/display/intel_panic.h
 create mode 100644 drivers/gpu/drm/xe/display/xe_panic.c
Signature · 1 line
2.47.2