Skip to content

RFC net: dsa: lantiq_gswip: convert to use regmap

Daniel Golle lkml netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest6 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6net: dsa: lantiq_gswip: convert accessors to use regmapdrivers/net/dsa/lantiq/Kconfig drivers/net/dsa/lantiq/lantiq_gswip.c drivers/net/dsa/lantiq/lantiq_gswip.h+106 -441 reply
2/6net: dsa: lantiq_gswip: convert trivial accessor uses to regmapdrivers/net/dsa/lantiq/lantiq_gswip.c+78 -980 replies
3/6net: dsa: lantiq_gswip: manually convert remaining uses of read accessorsdrivers/net/dsa/lantiq/lantiq_gswip.c+34 -430 replies
4/6net: dsa: lantiq_gswip: replace *_mask() functions with regmap APIdrivers/net/dsa/lantiq/lantiq_gswip.c+63 -850 replies
5/6net: dsa: lantiq_gswip: optimize regmap_write_bits() statementsdrivers/net/dsa/lantiq/lantiq_gswip.c+3 -50 replies
6/6net: dsa: lantiq_gswip: harmonize gswip_mii_mask_*() parametersdrivers/net/dsa/lantiq/lantiq_gswip.c+7 -100 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC PATCH net-next 0/6] net: dsa: lantiq_gswip: convert to use regmap

Prepare the lantiq_gswip DSA driver to use transports other than MMIO to access the switch registers by using regmap.

In order to ease future maintainance and get rid of unneeded indirection replace the existing accessor functions in favour of using the regmap API directly.

The biggest part of that conversion is done using easy-to-review semantic patches (coccinelle), leaving only a few corner cases and some optimization to be done manually.

Register writes could be further reduced in future by using regmap_update_bits() instead of regmap_write_bits() in cases which allow that.

Also note that, just like the current code, there is no error handling in case register access fails, however, an error message is printed in such cases at least.

This series is meant to be merged after series

"net: dsa: lantiq_gswip: prepare for supporting MaxLinear GSW1xx"[1]

and also after the series with fixes Vladimir Oltean is currently preparing; applying a bunch of semantic patches is easy even after code changes, while on the other hand applying his code changes after the conversion to regmap would require a rework of all his work).

Hence this is posted as RFC to potentially get some feedback before both other series mentioned above have been merged.

DSA selftests have been run with this series applied, the results are unchanged (ie. the expected result).

[1]: https://patchwork.kernel.org/project/netdevbpf/list/?series=997105

Daniel Golle (6):
net: dsa: lantiq_gswip: convert to use regmap
net: dsa: lantiq_gswip: convert trivial accessor uses to regmap
net: dsa: lantiq_gswip: manually convert remaining uses of read
accessors
net: dsa: lantiq_gswip: replace *_mask() functions with regmap API
net: dsa: lantiq_gswip: optimize regmap_write_bits() statements
net: dsa: lantiq_gswip: harmonize gswip_mii_mask_*() parameters

 drivers/net/dsa/lantiq/Kconfig        |   1 +
 drivers/net/dsa/lantiq/lantiq_gswip.c | 443 +++++++++++++-------------
 drivers/net/dsa/lantiq/lantiq_gswip.h |   6 +-
 3 files changed, 228 insertions(+), 222 deletions(-)
Signature · 1 line
2.51.0