tty: serial: 8250: Rework HP300 serial Kconfig logic
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest2 patches 1 replyIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | tty: serial: 8250: Move HP300/400 serial Kconfig optionsarch/ drivers/ drivers/ | +29 | 0 replies | |
| 2/2 | tty: serial: 8250: Rework HP300 serial Kconfig logicdrivers/ drivers/ | +2 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/2] tty: serial: 8250: Rework HP300 serial Kconfig logic
Hi all,
The HP300 serial driver has a long-standing configuration issue: when SERIAL_8250 and HP300 are enabled, but none of HPDCA and HPAPCI is built-in:
drivers/tty/serial/8250/8250_hp300.c:24:2: warning: #warning CONFIG_SERIAL_8250 defined but neither CONFIG_HPDCA nor CONFIG_HPAPCI defined, are you sure? [-Wcpp]
24 | #warning CONFIG_SERIAL_8250 defined but neither CONFIG_HPDCA nor CONFIG_HPAPCI defined, are you sure?
| ^~~~~~~
This series fixes this by reworking the Kconfig logic to make invalid configurations impossible, after moving the HP300 serial suboptions to where they really belong. It is meant as a replacement for "[PATCH]
m68k: make HPDCA and HPAPCI bools" [1], and was compile-tested only.
Anyone who can test this one real hardware? Probably we should add the following to hp300_defconfig:
+CONFIG_SERIAL_8250=y
+# CONFIG_SERIAL_8250_DEPRECATED_OPTIONS is not set
+# CONFIG_SERIAL_8250_16550A_VARIANTS is not set
+CONFIG_SERIAL_8250_CONSOLE=y
+CONFIG_SERIAL_8250_HPDCA=y
+CONFIG_SERIAL_8250_HPAPCI=yThanks for your comments!
[1] https://lore.kernel.org/all/[email protected]
Geert Uytterhoeven (2):
tty: serial: 8250: Move HP300/400 serial Kconfig options
tty: serial: 8250: Rework HP300 serial Kconfig logic
arch/m68k/Kconfig.devices | 14 ------------- drivers/tty/serial/8250/8250_hp300.c | 30 ++++++++++++---------------- drivers/tty/serial/8250/Kconfig | 16 ++++++++++++++- 3 files changed, 28 insertions(+), 32 deletions(-)
Signature · 12 lines
2.43.0
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds