Align atomic storage
Status from this message: [merged mm-nonmm-stable] atomic-add-option-for-weaker-alignment-check.patch removed from -mm tree
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v7 Latest4 patches 4 repliesApplied 4/4
- v64 patches 2 repliesSuperseded
- v54 patches 4 repliesSuperseded
Earlier versions · 3
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v4 RFC | 5 patches | 3 replies | Superseded | |
| v3 RFC | 5 patches | 12 replies | Superseded | |
| v2 RFC | 3 patches | 40 replies | Superseded |
Changes in v7 from the cover letter
- Test for __DISABLE_EXPORTS macro instead of __DISABLE_BUG_TABLE macro.
Patches in v7 All 4 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | bpf: Explicitly align bpf_res_spin_lockinclude/ kernel/ | +1 | 0 replies | Applied |
| 2/4 | atomic: Specify alignment for atomic_t and atomic64_tinclude/ include/ | +2 | 0 replies | Applied |
| 3/4 | atomic: Add alignment check to instrumented atomic operationsinclude/ lib/ | +21 | 4 replies | Applied |
| 4/4 | atomic: Add option for weaker alignment checkinclude/ lib/ | +15 | 0 replies | Applied |
Reviews trailers per patch
2 of 4 patches have a Reviewed-by or Acked-by.
| Patch | Alexei Starovoitov | Arnd Bergmann | Guo Ren | Geert Uytterhoeven |
|---|---|---|---|---|
| 1/4 | A-b | R-b | ||
| 2/4 | R-b | A-b | ||
| 3/4 | Suggested-by-suggested-by | |||
| 4/4 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.
Cover letter [PATCH v7 0/4] Align atomic storage
This series adds the __aligned attribute to atomic_t and atomic64_t definitions in include/linux and include/asm-generic (respectively) to get natural alignment of both types on csky, m68k, microblaze, nios2, openrisc and sh.
This series also adds Kconfig options to enable a new run-time warning to help reveal misaligned atomic accesses on platforms which don't trap that.
The performance impact is expected to vary across platforms and workloads. The measurements I made on m68k show that some workloads run faster and others slower.
---
Changed since v6
- Test for __DISABLE_EXPORTS macro instead of __DISABLE_BUG_TABLE macro.
Changed since v5:
- Added acked-by and revewed-by tags.
- Added a new macro to inhibit emission of __bug_table section, for the benefit of pre-boot code like the EFI stub loader.
Changed since v4:
- Dropped parisc header file patch as it's been merged already.
- Submitted as PATCH instead of RFC.
Changed since v3:
- Rebased on v6.17.
- New patch to resolve header dependency issue on parisc.
- Dropped documentation patch.
Changed since v2:
- Specify natural alignment for atomic64_t.
- CONFIG_DEBUG_ATOMIC checks for natural alignment again.
- New patch to add weakened alignment check.
- New patch for explicit alignment in BPF header.
---
Finn Thain (3):
bpf: Explicitly align bpf_res_spin_lock
atomic: Specify alignment for atomic_t and atomic64_t
atomic: Add option for weaker alignment check
Peter Zijlstra (1):
atomic: Add alignment check to instrumented atomic operations
include/asm-generic/atomic64.h | 2 +- include/asm-generic/rqspinlock.h | 2 +- include/linux/instrumented.h | 17 +++++++++++++++++ include/linux/types.h | 2 +- kernel/bpf/rqspinlock.c | 1 - lib/Kconfig.debug | 18 ++++++++++++++++++ 6 files changed, 38 insertions(+), 4 deletions(-)
Signature · 1 line
2.49.1