Skip to content

virtio: feature related cleanups

Michael S. Tsirkin kvm linux-doc lkml netdev virtualization 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest3 patches 2 repliesIn review
  2. v52 patches 3 repliesSuperseded
  3. v42 patches 3 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v32 patches1 replySuperseded
v22 patches2 repliesSuperseded
v13 patches10 repliesSuperseded

Changes in v6 from the cover letter

rename variables in vhost to make the diff much smaller
changes from v4: address comments by Jason
move features variable to beginning of block unsigned long -> u64 - they are not the same

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3virtio: clean up features qword/dword termsdrivers/vhost/net.c drivers/virtio/virtio.c drivers/virtio/virtio_debug.c +5 more+41 -400 replies
2/3vhost/test: add test specific macro for featuresdrivers/vhost/test.c+4 -20 replies
3/3vhost: switch to arrays of feature bitsdrivers/vhost/net.c drivers/vhost/scsi.c drivers/vhost/test.c +2 more+61 -252 replies

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchJason Wang
1/3A-b
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH v6 0/3] virtio: feature related cleanups

Cleanup around handling of feature bits:
- address word/dword/qword confusion
- simplify interfaces so callers do not need to
remember in which 64 bit chunk each bit belongs

changes from v5:
rename variables in vhost to make the diff much smaller
changes from v4: address comments by Jason
move features variable to beginning of block unsigned long -> u64 - they are not the same
changes from v3:
drop an out of date unnecessary kdoc parser change

changes from v2:
- drop unnecessary casts
- rework the interface to use array of bits not

Michael S. Tsirkin (3):
virtio: clean up features qword/dword terms vhost/test: add test specific macro for features
vhost: switch to arrays of feature bits

 drivers/vhost/net.c                    | 29 +++++++++---------
 drivers/vhost/scsi.c                   |  9 ++++--
 drivers/vhost/test.c                   | 10 ++++--
 drivers/vhost/vhost.h                  | 42 +++++++++++++++++++++-----
 drivers/vhost/vsock.c                  | 10 +++---
 drivers/virtio/virtio.c                | 12 ++++----
 drivers/virtio/virtio_debug.c          | 10 +++---
 drivers/virtio/virtio_pci_modern_dev.c |  6 ++--
 include/linux/virtio.h                 |  2 +-
 include/linux/virtio_config.h          |  2 +-
 include/linux/virtio_features.h        | 29 +++++++++---------
 include/linux/virtio_pci_modern.h      |  8 ++---
 12 files changed, 104 insertions(+), 65 deletions(-)
Signature · 1 line
MST