iio: pressure: add driver and bindings for adp810
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest2 patches 2 repliesIn review
- v32 patches 6 repliesSuperseded
- v22 patches 3 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 2 patches | 16 replies | Superseded |
Changes in v4 from the cover letter
- Revert reordering of other entries in pressure/Makefile. Only add adp810.o at alphabetically correct place. Makefile reordering will be separate patch.
- Added additional include files types.h, array_size.h and error.h to follow IWYU.
- Fixed trigger command sending logic in case of big endian systems by using u8 array instead of u16 variable.
- Removed ADP810_MEASURE_LATENCY_MS macro and used it directly in msleep() with 20ms delay value. Improved comments for it.
- Tab and spacing cleanup at .read_raw callback.
- Added comments at adp810_read_buf struct declaration regarding usage of __packed.
- Link to v3: https://lore.kernel.org/lkml/[email protected]/
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | dt-bindings: iio: pressure: Add Aosong adp810Documentation/ | +46 | 0 replies | |
| 2/2 | iio: pressure: adp810: Add driver for adp810 sensorMAINTAINERS drivers/ drivers/ +1 more | +245 | 2 replies |
Reviews trailers per patch
All 2 patches have a Reviewed-by or Acked-by.
| Patch | Krzysztof Kozlowski | Andy Shevchenko |
|---|---|---|
| 1/2 | R-b | |
| 2/2 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v4 0/2] iio: pressure: add driver and bindings for adp810
This patch series adds support for aosong adp810 differential pressure and temperature sensor driver in the IIO subsystem.
Patch 1: Adds bindings for this hardware. Patch 2: Adds driver code with device tree support.
Overview of adp810:
This is digital differential pressure and temperature sensor from aosong under the brand name of ASAIR. This sensor can measure pressure from -500 to +500Pa and temperature from -40 to +85 degree. It provides simple protocol to measure readings over I2C bus interface.
How to read from sensor (Protocol)?
To read from sensor, i2c master needs to send measure command 0x372d to start the data acquisition. Then host/master should wait for minimum 10ms for data to be ready before reading. Post this delay i2c master can read 9 bytes of measurement data which includes - pressure(u16): crc(u8): temperature(u16): crc(u8) scale factor (u16): crc(8).
Host/master can optionally verify crc for data integrity. Read sequence can be terminated anytime by sending NAK.
Datasheet: https://aosong.com/userfiles/files/media/Datasheet%20ADP810-Digital.pdf
Testing:
Driver is tested on Texas Instruments am62x sk board by connecting sensor at i2c-2. Data communication is validated with i2c bus at 100KHz and 400KHz using logic analyzer. Sensor values are read using iio subsystem's sysfs interface.
Changes in v4:
- Revert reordering of other entries in pressure/Makefile. Only add adp810.o at alphabetically correct place. Makefile reordering will be separate patch.
- Added additional include files types.h, array_size.h and error.h to follow IWYU.
- Fixed trigger command sending logic in case of big endian systems by using u8 array instead of u16 variable.
- Removed ADP810_MEASURE_LATENCY_MS macro and used it directly in msleep() with 20ms delay value. Improved comments for it.
- Tab and spacing cleanup at .read_raw callback.
- Added comments at adp810_read_buf struct declaration regarding usage of __packed.
- Link to v3: https://lore.kernel.org/lkml/[email protected]/
Changes in v3:
- Followed Include What You Use (IWYU) by adding additional include files (mutex.h, dev_printk.h and few others)
- Improved error handling of i2c_master_send() and i2c_master_recv() with additional transfer length checks.
- Changed style of structure initialization from {0} to { }
- Rebased on top of v6.18-rc2
- Link to v2: https://lore.kernel.org/lkml/[email protected]/
Changes in v2:
- Wrapped yaml binding description to 80 lines.
- Dropped block scalar ' | ' from binding description.
- Carry forward Reviewed-by tag from Krzysztof on device tree binding.
- Grammar and spelling fixes at multiple places.
- Ordered makefile alphabetically.
- Ordered include files alphabetically and used IWYU principle
- Explicitly mentioned unit of measure latency macro in MS (milliseconds)
- Added inline comments for explaining CRC8 polynomial for CRC calculation
- Used scoped_guard() for mutex for safe and clean lock handling.
- Used resource managed mutex_init() -> devm_mutex_init()
- Removed dead code in _probe() function.
- Used __be16 and related helpers to handle big endian data processing.
- Apply reverse xmas tree guideline while declaring local variables if possible.
- Used parent device pointer in dev_err() calls.
- Hardcode device name string in _probe() function for simplicity.
- Made default return value of _probe() function to 0.
- Rebased and retested driver on top of 6.18-rc1
- Link to v1: https://lore.kernel.org/lkml/[email protected]/
Akhilesh Patil (2):
dt-bindings: iio: pressure: Add Aosong adp810
iio: pressure: adp810: Add driver for adp810 sensor
.../bindings/iio/pressure/aosong,adp810.yaml | 46 ++++ MAINTAINERS | 7 + drivers/iio/pressure/Kconfig | 12 + drivers/iio/pressure/Makefile | 1 + drivers/iio/pressure/adp810.c | 225 ++++++++++++++++++ 5 files changed, 291 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/pressure/aosong,adp810.yaml create mode 100644 drivers/iio/pressure/adp810.c
Signature · 1 line
2.34.1