Skip to content

media: omap3isp: v4l2-compliance fixes

Hans Verkuil linux-media 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest12 patches 3 repliesIn review
  2. v211 patches 0 repliesSuperseded
  3. v114 patches 22 repliesSuperseded

Changes in v3 from the cover letter

- restored the first patch ("configure entity functions") that I accidentally dropped in v2.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12media: omap3isp: configure entity functionsdrivers/media/platform/ti/omap3isp/ispccdc.c drivers/media/platform/ti/omap3isp/ispccp2.c drivers/media/platform/ti/omap3isp/ispcsi2.c +3 more+6 -00 replies
2/12media: omap3isp: add V4L2_CAP_IO_MC and don't set bus_infodrivers/media/platform/ti/omap3isp/ispvideo.c+3 -50 replies
3/12media: omap3isp: isp_video_mbus_to_pix/pix_to_mbus fixesdrivers/media/platform/ti/omap3isp/ispvideo.c+3 -30 replies
4/12media: omap3isp: implement enum_fmt_vid_cap/outdrivers/media/platform/ti/omap3isp/ispvideo.c+36 -30 replies
5/12media: omap3isp: use V4L2_COLORSPACE_SRGB instead of _JPEGdrivers/media/platform/ti/omap3isp/isppreview.c drivers/media/platform/ti/omap3isp/ispresizer.c+2 -20 replies
6/12media: omap3isp: set initial formatdrivers/media/platform/ti/omap3isp/ispvideo.c+8 -00 replies
7/12media: omap3isp: rework isp_video_try/set_formatdrivers/media/platform/ti/omap3isp/ispvideo.c+30 -290 replies
8/12media: omap3isp: implement create/prepare_bufsdrivers/media/platform/ti/omap3isp/ispvideo.c+45 -20 replies
9/12media: omap3isp: better VIDIOC_G/S_PARM handlingdrivers/media/platform/ti/omap3isp/ispvideo.c+9 -20 replies
10/12media: omap3isp: support ctrl events for isppreviewdrivers/media/platform/ti/omap3isp/isppreview.c+1 -10 replies
11/12media: omap3isp: ispccp2: always clamp in ccp2_try_format()drivers/media/platform/ti/omap3isp/ispccp2.c+1 -10 replies
12/12media: omap3isp: isppreview: always clamp in preview_try_format()drivers/media/platform/ti/omap3isp/isppreview.c+8 -130 replies

Reviews trailers per patch

None of the 12 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchSakari Ailus
SeriesA-b
1/12
2/12
3/12
4/12
5/12
6/12
7/12
8/12
9/12
10/12
11/12
12/12

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCHv3 00/12] media: omap3isp: v4l2-compliance fixes

When I worked on the patch series to remove the vb2 wait_prepare/finish callbacks, I had to test that series on my Beagle xM board with a Leopard Imaging li5m03 camera.

Since I wanted to use v4l2-compliance to test the vb2 change, I first had to fix a bunch of other compliance problems in this driver so it would actually be able to run the streaming tests.

This series contains the fixes I made to get to that point.

It depends on one sensor driver fix (posted separately):

https://patchwork.linuxtv.org/project/linux-media/patch/[email protected]/

This series doesn't fix all compliance problems, but at least it is a lot better now.

Regards,

Hans

Changes since v2:
- restored the first patch ("configure entity functions") that I accidentally dropped in v2.

Changes since v1:
- Simplify isp_video_enum_format by checking for duplicate pixelformats
- Drop -ENOTTY to -EINVAL change in isp_video_try_format.

Hans Verkuil (12):
media: omap3isp: configure entity functions
media: omap3isp: add V4L2_CAP_IO_MC and don't set bus_info
media: omap3isp: isp_video_mbus_to_pix/pix_to_mbus fixes
media: omap3isp: implement enum_fmt_vid_cap/out
media: omap3isp: use V4L2_COLORSPACE_SRGB instead of _JPEG
media: omap3isp: set initial format
media: omap3isp: rework isp_video_try/set_format
media: omap3isp: implement create/prepare_bufs
media: omap3isp: better VIDIOC_G/S_PARM handling
media: omap3isp: support ctrl events for isppreview
media: omap3isp: ispccp2: always clamp in ccp2_try_format()
media: omap3isp: isppreview: always clamp in preview_try_format()

 drivers/media/platform/ti/omap3isp/ispccdc.c  |   1 +
 drivers/media/platform/ti/omap3isp/ispccp2.c  |   3 +-
 drivers/media/platform/ti/omap3isp/ispcsi2.c  |   1 +
 .../media/platform/ti/omap3isp/isppreview.c   |  26 ++-
 .../media/platform/ti/omap3isp/ispresizer.c   |   3 +-
 drivers/media/platform/ti/omap3isp/ispstat.c  |   1 +
 drivers/media/platform/ti/omap3isp/ispvideo.c | 178 +++++++++++++-----
 7 files changed, 152 insertions(+), 61 deletions(-)
Signature · 1 line
2.51.0