Skip to content

btrfs: some small optimizations around space_info locking and cleanups

[email protected] linux-btrfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest28 patches 12 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/28btrfs: return real error when failing tickets in maybe_fail_all_tickets()fs/btrfs/space-info.c+6 -60 replies
2/28btrfs: avoid recomputing used space in btrfs_try_granting_tickets()fs/btrfs/space-info.c+5 -20 replies
3/28btrfs: make btrfs_can_overcommit() return bool instead of intfs/btrfs/space-info.c fs/btrfs/space-info.h+6 -80 replies
4/28btrfs: avoid used space computation when trying to grant ticketsfs/btrfs/space-info.c+22 -40 replies
5/28btrfs: avoid used space computation when reserving spacefs/btrfs/space-info.c+2 -20 replies
6/28btrfs: inline btrfs_space_info_used()fs/btrfs/space-info.c fs/btrfs/space-info.h+11 -122 replies
7/28btrfs: bail out earlier from need_preemptive_reclaim() if we have ticketsfs/btrfs/space-info.c+9 -90 replies
8/28btrfs: increment loop count outside critical section during metadata reclaimfs/btrfs/space-info.c+2 -20 replies
9/28btrfs: shorten critical section in btrfs_preempt_reclaim_metadata_space()fs/btrfs/space-info.c+7 -60 replies
10/28btrfs: avoid unnecessary reclaim calculation in priority_reclaim_metadata_space()fs/btrfs/space-info.c+2 -12 replies
11/28btrfs: assert space_info is locked in steal_from_global_rsv()fs/btrfs/space-info.c+2 -00 replies
12/28btrfs: assign booleans to global reserve's full fieldfs/btrfs/space-info.c+2 -20 replies
13/28btrfs: process ticket outside global reserve critical sectionfs/btrfs/space-info.c+4 -30 replies
14/28btrfs: remove double underscore prefix from __reserve_bytes()fs/btrfs/space-info.c+5 -50 replies
15/28btrfs: reduce space_info critical section in btrfs_chunk_alloc()fs/btrfs/block-group.c+3 -30 replies
16/28btrfs: reduce block group critical section in btrfs_free_reserved_bytes()fs/btrfs/block-group.c+9 -60 replies
17/28btrfs: reduce block group critical section in btrfs_add_reserved_bytes()fs/btrfs/block-group.c+14 -60 replies
18/28btrfs: reduce block group critical section in do_trimming()fs/btrfs/free-space-cache.c+12 -82 replies
19/28btrfs: reduce block group critical section in pin_down_extent()fs/btrfs/extent-tree.c+5 -52 replies
20/28btrfs: use local variable for space_info in pin_down_extent()fs/btrfs/extent-tree.c+10 -90 replies
21/28btrfs: remove 'reserved' argument from btrfs_pin_extent()fs/btrfs/extent-tree.c fs/btrfs/extent-tree.h+8 -100 replies
22/28btrfs: change 'reserved' argument from pin_down_extent() to boolfs/btrfs/extent-tree.c+6 -60 replies
23/28btrfs: reduce block group critical section in unpin_extent_range()fs/btrfs/extent-tree.c+8 -80 replies
24/28btrfs: remove pointless label and goto from unpin_extent_range()fs/btrfs/extent-tree.c+3 -50 replies
25/28btrfs: add data_race() in btrfs_account_ro_block_groups_free_space()fs/btrfs/space-info.c+1 -10 replies
26/28btrfs: move ticket wakeup and finalization to remove_ticket()fs/btrfs/space-info.c+18 -220 replies
27/28btrfs: avoid space_info locking when checking if tickets are servedfs/btrfs/space-info.c fs/btrfs/space-info.h+34 -233 replies
28/28btrfs: tag as unlikely fs aborted checks in space flushing codefs/btrfs/space-info.c+18 -190 replies

Reviews trailers per patch

None of the 28 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchJohannes Thumshirn
SeriesR-b
1/28
2/28
3/28
4/28
5/28
6/28
7/28
8/28
9/28
10/28
11/28
12/28
13/28
14/28
15/28
16/28
17/28
18/28
19/28
20/28
21/28
22/28
23/28
24/28
25/28
26/28
27/28
28/28

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/28] btrfs: some small optimizations around space_info locking and cleanups

From: Filipe Manana <[email protected]>

Several optimizations to reduce critical sections delimited by a space_info's spinlock and several cleanups mostly arround space reservation and flushing. Details in the changelogs.

Filipe Manana (28):
btrfs: return real error when failing tickets in maybe_fail_all_tickets()
btrfs: avoid recomputing used space in btrfs_try_granting_tickets()
btrfs: make btrfs_can_overcommit() return bool instead of int
btrfs: avoid used space computation when trying to grant tickets
btrfs: avoid used space computation when reserving space
btrfs: inline btrfs_space_info_used()
btrfs: bail out earlier from need_preemptive_reclaim() if we have tickets
btrfs: increment loop count outside critical section during metadata reclaim
btrfs: shorten critical section in btrfs_preempt_reclaim_metadata_space()
btrfs: avoid unnecessary reclaim calculation in priority_reclaim_metadata_space()
btrfs: assert space_info is locked in steal_from_global_rsv()
btrfs: assign booleans to global reserve's full field
btrfs: process ticket outside global reserve critical section
btrfs: remove double underscore prefix from __reserve_bytes()
btrfs: reduce space_info critical section in btrfs_chunk_alloc()
btrfs: reduce block group critical section in btrfs_free_reserved_bytes()
btrfs: reduce block group critical section in btrfs_add_reserved_bytes()
btrfs: reduce block group critical section in do_trimming()
btrfs: reduce block group critical section in pin_down_extent()
btrfs: use local variable for space_info in pin_down_extent()
btrfs: remove 'reserved' argument from btrfs_pin_extent()
btrfs: change 'reserved' argument from pin_down_extent() to bool
btrfs: reduce block group critical section in unpin_extent_range()
btrfs: remove pointless label and goto from unpin_extent_range()
btrfs: add data_race() in btrfs_account_ro_block_groups_free_space()
btrfs: move ticket wakeup and finalization to remove_ticket()
btrfs: avoid space_info locking when checking if tickets are served
btrfs: tag as unlikely fs aborted checks in space flushing code

 fs/btrfs/block-group.c      |  41 +++---
 fs/btrfs/extent-tree.c      |  72 ++++++-----
 fs/btrfs/extent-tree.h      |   3 +-
 fs/btrfs/free-space-cache.c |  20 +--
 fs/btrfs/space-info.c       | 243 +++++++++++++++++++-----------------
 fs/btrfs/space-info.h       |  18 ++-
 6 files changed, 219 insertions(+), 178 deletions(-)
Signature · 1 line
2.47.2