f2fs: Add sanity checks before unlinking and loading inodes
Status from this message: This series was applied to jaegeuk/f2fs.git (dev)
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest2 patches 2 repliesApplied 2/2
- v32 patches 1 replySuperseded
- v22 patches 3 repliesSuperseded
Changes in v4 from the cover letter
- Replace F2FS_I_SB(inode) with already obtained f2fs_sb_info pointer.
https://lore.kernel.org/linux-f2fs-devel/[email protected]/T/#u
Patches in v4 All 2 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | f2fs: Rename f2fs_unlink exit labelfs/ | +7 | 1 reply | Applied |
| 2/2 | f2fs: Add sanity checks before unlinking and loading inodesfs/ fs/ | +18 | 1 reply | Applied |
Reviews trailers per patch
All 2 patches have a Reviewed-by or Acked-by.
| Patch | [email protected] | Chao Yu |
|---|---|---|
| 1/2 | R-b | |
| 2/2 | T-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v4 0/2] f2fs: Add sanity checks before unlinking and loading inodes
This series is provoked by syzbot warnings caused by corrupted directory inode with i_nlink == 1 that passes the initial sanity check which will only mark the filesystem as corrupted in case i_nlink == 0.
Tests:
- fio/fsmark parallel create/unlink on VM with f2fs root filesystem.
- syzbot
Changelog:
Changes from v1:
- Rename exit label in f2fs_unlink().
- Add sanity check in sanity_check_inode() and remove it from f2fs_iget() as suggested by Chao Yu in order to detect on-disk corruption early.
https://lore.kernel.org/linux-f2fs-devel/[email protected]/T/#t
Changes from v2:
- Remove i_nlink == 0 check from sanity_check_inode.
- Wrap i_nlink == 1 in unlikely() marco.
https://lore.kernel.org/linux-f2fs-devel/[email protected]/T/#u
Changes from v3:
- Replace F2FS_I_SB(inode) with already obtained f2fs_sb_info pointer.
https://lore.kernel.org/linux-f2fs-devel/[email protected]/T/#u
Nikola Z. Ivanov (2):
f2fs: Rename f2fs_unlink exit label
f2fs: Add sanity checks before unlinking and loading inodes
fs/f2fs/inode.c | 6 ++++++ fs/f2fs/namei.c | 29 ++++++++++++++++++----------- 2 files changed, 24 insertions(+), 11 deletions(-)
Signature · 1 line
2.51.0