Skip to content

drm: avoid poking at dev->vblank[] directly

Jani Nikula dri-devel intel-gfx intel-xe linux-arm-msm 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 11 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6drm/vblank: use drm_crtc_vblank_crtc() in workersdrivers/gpu/drm/drm_vblank_work.c+1 -11 reply
2/6drm/atomic: use drm_crtc_vblank_waitqueue()drivers/gpu/drm/drm_atomic_helper.c+3 -14 replies
3/6drm/msm: use drm_crtc_vblank_waitqueue()drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c+4 -21 reply
4/6drm/tidss: use drm_crtc_vblank_crtc()drivers/gpu/drm/tidss/tidss_crtc.c+1 -21 reply
5/6drm/vmwgfx: use drm_crtc_vblank_crtc()drivers/gpu/drm/vmwgfx/vmwgfx_vkms.c+2 -41 reply
6/6drm/gma500: use drm_crtc_vblank_crtc()drivers/gpu/drm/gma500/psb_irq.c+23 -133 replies

Reviews trailers per patch

5 of 6 patches have a Reviewed-by or Acked-by.

PatchPatrik JakobssonIan ForbesJyri SarhaDmitry BaryshkovThomas Zimmermann
1/6R-b
2/6
3/6A-b
4/6A-b
5/6R-b
6/6A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v1 thread

Cover letter [PATCH 0/6] drm: avoid poking at dev->vblank[] directly

We have accessors for dev->vblank[], and poking at that directly should be reserved for drm_vblank.c. This series along with [1] switches to use the accessors.

I've got a whole another series brewing refactoring drm_vblank.c, but wanted to split this out of the series to keep it manageable. None of the patches here depend on each other, and the refactoring doesn't depend on it, so the patches to drivers can be merged every which way, just let me know.

BR,
Jani.

[1] https://lore.kernel.org/r/[email protected]

Jani Nikula (6):
drm/vblank: use drm_crtc_vblank_crtc() in workers drm/atomic: use drm_crtc_vblank_waitqueue() drm/msm: use drm_crtc_vblank_waitqueue() drm/tidss: use drm_crtc_vblank_crtc() drm/vmwgfx: use drm_crtc_vblank_crtc() drm/gma500: use drm_crtc_vblank_crtc()

 drivers/gpu/drm/drm_atomic_helper.c       |  4 ++-
 drivers/gpu/drm/drm_vblank_work.c         |  2 +-
 drivers/gpu/drm/gma500/psb_irq.c          | 36 +++++++++++++++--------
 drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c |  3 +-
 drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c |  3 +-
 drivers/gpu/drm/tidss/tidss_crtc.c        |  3 +-
 drivers/gpu/drm/vmwgfx/vmwgfx_vkms.c      |  6 ++--
 7 files changed, 34 insertions(+), 23 deletions(-)
Signature · 1 line
2.47.3