Skip to content

drm/vblank: refactoring and cleanups

Jani Nikula dri-devel intel-gfx intel-xe 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest25 patches 1 replyIn review
  2. v225 patches 6 repliesSuperseded
  3. v124 patches 32 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/25drm/vblank: Unexport drm_wait_one_vblank()drivers/gpu/drm/drm_vblank.c include/drm/drm_vblank.h+1 -140 replies
2/25drm/vblank: remove drm_wait_one_vblank() completelydrivers/gpu/drm/drm_vblank.c+11 -140 replies
3/25drm/vblank: remove superfluous pipe checkdrivers/gpu/drm/drm_vblank.c+0 -30 replies
4/25drm/vblank: add return value to drm_crtc_wait_one_vblank()drivers/gpu/drm/drm_vblank.c include/drm/drm_vblank.h+7 -30 replies
5/25drm/vblank: limit vblank variable scope to atomicdrivers/gpu/drm/drm_vblank.c+5 -30 replies
6/25drm/vblank: use the drm_vblank_crtc() and drm_crtc_vblank_crtc() helpers moredrivers/gpu/drm/drm_vblank.c+6 -40 replies
7/25drm/vblank: prefer drm_crtc_vblank_crtc() over drm_vblank_crtc()drivers/gpu/drm/drm_vblank.c+2 -20 replies
8/25drm/vblank: pass vlank to drm_vblank_get()/_put()/_count()drivers/gpu/drm/drm_internal.h drivers/gpu/drm/drm_vblank.c drivers/gpu/drm/drm_vblank_work.c+51 -360 replies
9/25drm/vblank: pass vblank to drm_update_vblank_count()drivers/gpu/drm/drm_vblank.c+17 -150 replies
10/25drm/vblank: pass vblank to drm_handle_vblank_events()drivers/gpu/drm/drm_vblank.c+8 -60 replies
11/25drm/vblank: use the vblank based interfaces moredrivers/gpu/drm/drm_vblank.c+10 -340 replies
12/25drm/vblank: pass vblank to drm_queue_vblank_event()drivers/gpu/drm/drm_vblank.c+7 -60 replies
13/25drm/vblank: pass vblank to drm_wait_vblank_reply()drivers/gpu/drm/drm_vblank.c+6 -60 replies
14/25drm/vblank: pass vblank to drm_vblank_count_and_time()drivers/gpu/drm/drm_vblank.c+16 -220 replies
15/25drm/vblank: pass vblank to drm_reset_vblank_timestamp()drivers/gpu/drm/drm_vblank.c+4 -20 replies
16/25drm/vblank: pass vblank to store_vblank()drivers/gpu/drm/drm_vblank.c+8 -80 replies
17/25drm/vblank: pass vblank to drm_vblank_enable()drivers/gpu/drm/drm_vblank.c+5 -50 replies
18/25drm/vblank: merge drm_vblank_restore() into drm_crtc_vblank_restore()drivers/gpu/drm/drm_vblank.c+23 -340 replies
19/25drm/vblank: add drm_crtc_from_vblank() helperdrivers/gpu/drm/drm_vblank.c+7 -20 replies
20/25drm/vblank: pass vblank to __get_vblank_counter() and drm_max_vblank_count()drivers/gpu/drm/drm_vblank.c+17 -170 replies
21/25drm/vblank: pass vblank to __{enable, disable}_vblank()drivers/gpu/drm/drm_vblank.c+10 -60 replies
22/25drm/vblank: pass vblank to drm_get_last_vbltimestamp()drivers/gpu/drm/drm_vblank.c+8 -120 replies
23/25drm/vblank: pass vblank to drm_vblank_disable_and_save(), make staticdrivers/gpu/drm/drm_internal.h drivers/gpu/drm/drm_vblank.c+4 -50 replies
24/25drm/vblank: reduce pipe checksdrivers/gpu/drm/drm_vblank.c+15 -210 replies
25/25drm/vblank: clean up debug loggingdrivers/gpu/drm/drm_vblank.c+50 -590 replies

Reviews trailers per patch

All 25 patches have a Reviewed-by or Acked-by.

PatchThomas Zimmermann
1/25R-b
2/25R-b
3/25R-b
4/25R-b
5/25R-b
6/25R-b
7/25R-b
8/25R-b
9/25R-b
10/25R-b
11/25R-b
12/25R-b
13/25R-b
14/25R-b
15/25R-b
16/25R-b
17/25R-b
18/25R-b
19/25R-b
20/25R-b
21/25R-b
22/25R-b
23/25R-b
24/25R-b
25/25R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 00/25] drm/vblank: refactoring and cleanups

v3 of [1], just a resend to dri-devel, which I forgot to add, and Thomas' R-b's, which I also forgot to add, in v2.

Fingers crossed I don't fumble it this time.

BR,
Jani.

[1] https://lore.kernel.org/r/[email protected]

Jani Nikula (24):
drm/vblank: remove drm_wait_one_vblank() completely drm/vblank: remove superfluous pipe check
drm/vblank: add return value to drm_crtc_wait_one_vblank() drm/vblank: limit vblank variable scope to atomic drm/vblank: use the drm_vblank_crtc() and drm_crtc_vblank_crtc()
helpers more
drm/vblank: prefer drm_crtc_vblank_crtc() over drm_vblank_crtc() drm/vblank: pass vlank to drm_vblank_get()/_put()/_count() drm/vblank: pass vblank to drm_update_vblank_count() drm/vblank: pass vblank to drm_handle_vblank_events() drm/vblank: use the vblank based interfaces more drm/vblank: pass vblank to drm_queue_vblank_event() drm/vblank: pass vblank to drm_wait_vblank_reply() drm/vblank: pass vblank to drm_vblank_count_and_time() drm/vblank: pass vblank to drm_reset_vblank_timestamp() drm/vblank: pass vblank to store_vblank()
drm/vblank: pass vblank to drm_vblank_enable()
drm/vblank: merge drm_vblank_restore() into drm_crtc_vblank_restore() drm/vblank: add drm_crtc_from_vblank() helper
drm/vblank: pass vblank to __get_vblank_counter() and
drm_max_vblank_count()
drm/vblank: pass vblank to __{enable,disable}_vblank() drm/vblank: pass vblank to drm_get_last_vbltimestamp() drm/vblank: pass vblank to drm_vblank_disable_and_save(), make static drm/vblank: reduce pipe checks
drm/vblank: clean up debug logging

Thomas Zimmermann (1):
drm/vblank: Unexport drm_wait_one_vblank()

 drivers/gpu/drm/drm_internal.h    |   7 +-
 drivers/gpu/drm/drm_vblank.c      | 533 ++++++++++++++----------------
 drivers/gpu/drm/drm_vblank_work.c |  12 +-
 include/drm/drm_vblank.h          |   3 +-
 4 files changed, 257 insertions(+), 298 deletions(-)
Signature · 1 line
2.47.3