hsr: Send correct HSRv0 supervision frames
Status from this message: This series was applied to netdev/net.git (main)
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 All 2 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | hsr: Fix supervision frame sending on HSRv0net/ | +3 | 1 reply | Applied |
| 2/2 | hsr: Follow standard for HSRv0 supervision framesnet/ net/ | +16 | 3 replies | Applied |
Reviews trailers per patch
All 2 patches have a Reviewed-by or Acked-by.
| Patch | Hangbin Liu | Sebastian Andrzej Siewior |
|---|---|---|
| Series | T-b | |
| 1/2 | R-b T-b | |
| 2/2 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH net 0/2] hsr: Send correct HSRv0 supervision frames
Hangbin recently reported that the hsr selftests were failing and noted that the entries in the node table were not merged, i.e., had 00:00:00:00:00:00 as MacAddressB forever [1].
This failure only occured with HSRv0 because it was not sending supervision frames anymore. While debugging this I found that we were not really following the HSRv0 standard for the supervision frames we sent, so I additionally made a few changes to get closer to the standard and restore a more correct behavior we had a while ago.
The selftests can still fail because they take a while and run into the timeout. I did not include a change of the timeout because I have more improvements to the selftests mostly ready that change the test duration but are net-next material.
[1]: https://lore.kernel.org/netdev/aMONxDXkzBZZRfE5@fedora/
Felix Maurer (2):
hsr: Fix supervision frame sending on HSRv0
hsr: Follow standard for HSRv0 supervision frames
net/hsr/hsr_device.c | 5 ++++- net/hsr/hsr_forward.c | 22 +++++++++++++++------- 2 files changed, 19 insertions(+), 8 deletions(-)
--
2.51.0