RFC use cleanup.h in btrfs
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest8 patches 12 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/8 | btrfs: remove redundant label in __del_qgroup_relationfs/ | +4 | 0 replies | |
| 2/8 | btrfs: move kfree out of btrfs_create_qgroup's cleanup pathfs/ | +4 | 1 reply | |
| 3/8 | btrfs: simplify control flow in scrub_simple_mirrorfs/ | +8 | 0 replies | |
| 4/8 | btrfs: simplify function protections with guardsfs/ fs/ fs/ +8 more | +29 | 4 replies | |
| 5/8 | btrfs: use cleanup.h guard()s to simplify unlocks on returnfs/ fs/ fs/ +12 more | +73 | 0 replies | |
| 6/8 | btrfs: simplify cleanup via scoped_guard()fs/ fs/ fs/ +5 more | +97 | 1 reply | |
| 7/8 | btrfs: simplify return path via cleanup.hfs/ fs/ fs/ | +68 | 3 replies | |
| 8/8 | btrfs: simplify cleanup in btrfs_add_qgroup_relationfs/ | +16 | 1 reply |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [RFC PATCH 0/8] use cleanup.h in btrfs
This series represents my experimentation with refactoring with cleanup guards. In my opinion, RAII-style locking improves readability in most cases and also improves code robustness for future code changes, so I tried to refactor simple cases that really benefits from lock guards.
However readability is a subjective concept, so you can freely disagree and reject any of those changes, I won't insist on any. Please note that patches 1-3 can be useful even without lock guards.
I didn't know how to split this series, mostly because it's just a lot of small changes... so I tried to split it by types of transformation:
1. Patches 1-3 include some preparation work and simple fixes I noticed.
2. Patches 4-6 gradually increase the complexity of the refactored situations, from simple lock/unlock pairs to scoped guards.
3. Patch 7 refactors functions which control flow can really benefit from removed cleanups on exit. E.g. we can get rid of obscure if statements in exit paths.
4. Patch 8 is kinda an example of overdone code refactoring and I predict that it will be dropped anyway.
There is no TODOs for this series, but it's junk enough to be marked as RFC.
Gladyshev Ilya (8):
btrfs: remove redundant label in __del_qgroup_relation
btrfs: move kfree out of btrfs_create_qgroup's cleanup path
btrfs: simplify control flow in scrub_simple_mirror
btrfs: simplify function protections with guards
btrfs: use cleanup.h guard()s to simplify unlocks on return
btrfs: simplify cleanup via scoped_guard()
btrfs: simplify return path via cleanup.h
btrfs: simplify cleanup in btrfs_add_qgroup_relation
fs/btrfs/block-group.c | 24 ++---- fs/btrfs/compression.c | 13 ++- fs/btrfs/discard.c | 20 ++--- fs/btrfs/disk-io.c | 9 +- fs/btrfs/extent-io-tree.c | 72 ++++++---------- fs/btrfs/extent-tree.c | 104 ++++++++++------------- fs/btrfs/extent_io.c | 33 ++++---- fs/btrfs/file-item.c | 6 +- fs/btrfs/free-space-cache.c | 87 +++++++------------ fs/btrfs/fs.c | 9 +- fs/btrfs/inode.c | 3 +- fs/btrfs/ordered-data.c | 67 ++++++--------- fs/btrfs/qgroup.c | 165 ++++++++++++++---------------------- fs/btrfs/raid56.c | 20 ++--- fs/btrfs/scrub.c | 19 ++--- fs/btrfs/send.c | 40 ++++----- fs/btrfs/space-info.c | 4 +- fs/btrfs/subpage.c | 41 +++------ fs/btrfs/tree-log.c | 28 +++--- fs/btrfs/volumes.c | 3 +- fs/btrfs/zoned.c | 13 +-- fs/btrfs/zstd.c | 13 +-- 22 files changed, 299 insertions(+), 494 deletions(-)
base-commit: 24172e0d79900908cf5ebf366600616d29c9b417
Signature · 1 line
2.51.1.dirty