Skip to content

make VM_SOFTDIRTY a sticky VMA flag

Lorenzo Stoakes linux-mm lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 5 repliesIn review 1 of 2 applied
  2. v12 patches 18 repliesSuperseded

Changes in v2 from the cover letter

* Propagated tags (thanks David, Pedro!)
* Corrected comments and added ASCII diagrams as per David.
* Expanded self-test to check for mprotect() case.
* Updated incomplete cover letter.
* Updated commit messages accordingly.

Patches in v2 1 of 2 applied

#Subject and filesSizeRepliesApplied
1/2mm: propagate VM_SOFTDIRTY on mergeinclude/linux/mm.h tools/testing/vma/vma_internal.h+22 -245 replies
2/2testing/selftests/mm: add soft-dirty merge self-testtools/testing/selftests/mm/soft-dirty.c+126 -10 repliesApplied

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchDavid Hildenbrand (Red Hat)Pedro FalcatoAndrey VaginVlastimil Babka
1/2A-b R-b A-b R-b
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v2 thread

Cover letter [PATCH v2 0/2] make VM_SOFTDIRTY a sticky VMA flag

Currently we set VM_SOFTDIRTY when a new mapping is set up (whether by establishing a new VMA, or via merge) as implemented in __mmap_complete() and do_brk_flags().

However, when performing a merge of existing mappings such as when performing mprotect(), we may lose the VM_SOFTDIRTY flag.

Now we have the concept of making VMA flags 'sticky', that is that they both don't prevent merge and, importantly, are propagated to merged VMAs, this seems a sensible alternative to the existing special-casing of VM_SOFTDIRTY.

We additionally add a self-test that demonstrates that this logic behaves as expected.

v2:
* Propagated tags (thanks David, Pedro!)
* Corrected comments and added ASCII diagrams as per David.
* Expanded self-test to check for mprotect() case.
* Updated incomplete cover letter.
* Updated commit messages accordingly.

v1:
https://lore.kernel.org/all/[email protected]/

Lorenzo Stoakes (2):
mm: propagate VM_SOFTDIRTY on merge testing/selftests/mm: add soft-dirty merge self-test

 include/linux/mm.h                      |  23 ++---
 tools/testing/selftests/mm/soft-dirty.c | 127 +++++++++++++++++++++++-
 tools/testing/vma/vma_internal.h        |  23 ++---
 3 files changed, 148 insertions(+), 25 deletions(-)

--
2.51.0