Skip to content

PCI: rockchip: 5.0 GT/s speed may be dangerous

Geraldo Nascimento linux-arm-kernel linux-pci linux-rockchip lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 5 repliesIn review
  2. v24 patches 14 repliesApplied
  3. v13 patches 17 repliesSuperseded

Changes in v3 from the cover letter

- Clarify warning message even though Rockchip won't disclose details
- Drop DT changes as they were applied as subset by Heiko
- Link to v2: https://lore.kernel.org/all/[email protected]/

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2PCI: rockchip: limit RK3399 to 2.5 GT/s to avoid data lossdrivers/pci/controller/pcie-rockchip.c+8 -20 replies
2/2PCI: rockchip-host: comment danger of 5.0 GT/s speeddrivers/pci/controller/pcie-rockchip-host.c+4 -05 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchDragan Simic
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/2] PCI: rockchip: 5.0 GT/s speed may be dangerous

Dragan Simic already had warned me of potential issues with 5.0 GT/s speed operation in Rockchip PCIe. However, in recent interactions with Shawn Lin from Rockchip it came to my attention there's grave danger in the unknown errata regarding 5.0 GT/s operational speed of their PCIe core. Even if the odds are low, to contain any damage, let's prevent 5.0 GT/s operation as well as add a comment to Root Complex driver core, documenting this danger of data loss or worse.

---

Changes in v3:
- Clarify warning message even though Rockchip won't disclose details
- Drop DT changes as they were applied as subset by Heiko
- Link to v2: https://lore.kernel.org/all/[email protected]/

Changes in v2:
- hard limit to 2.5 GT/s, not just warn
- add Reported-by: and Reviewed-by: Dragan Simic
- remove redundant declaration of max-link-speed from helios64 dts
- fix Link: of helios64 patch
- simplify RC mode comment
- Link to v1: https://lore.kernel.org/all/aRhR79u5BPtRRFw3@geday/

---

Geraldo Nascimento (2):
PCI: rockchip: limit RK3399 to 2.5 GT/s to avoid data loss
PCI: rockchip-host: comment danger of 5.0 GT/s speed

 drivers/pci/controller/pcie-rockchip-host.c |  4 ++++
 drivers/pci/controller/pcie-rockchip.c      | 10 ++++++++--
 2 files changed, 12 insertions(+), 2 deletions(-)
Signature · 1 line
2.52.0