Skip to content

Add TMAP & GMAP information services

Pauli Virtanen linux-bluetooth 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest7 patches 1 replyIn review
  2. v29 patches 5 repliesSuperseded
  3. v110 patches 5 repliesSuperseded

Changes in v3 from the cover letter

- rename after_uuids -> after_services + make it a struct
- add tests for btd_profile_sort_list()
- leave it as the GSList version for now, tests use queue
- add commits to mark VCP connected only after its attach has finished

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7profile: add after_services for ordering profile startupsrc/profile.c src/profile.h+116 -00 replies
2/7test-profile: add tests for profile sorting.gitignore Makefile.am unit/btd.c +1 more+403 -50 replies
3/7device: use after_services in service autoconnect and sort also GATTsrc/device.c+62 -120 replies
4/7service: implement btd_profile::after_services callbacksrc/service.c+106 -00 replies
5/7bap: have unicast client wait for VCS & TMAS & GMAPprofiles/audio/bap.c+33 -30 replies
6/7shared/vcp: add ready callback to bt_vcp_attach()src/shared/vcp.c src/shared/vcp.h+30 -20 replies
7/7vcp: wait until client ready before marking profile connectedprofiles/audio/vcp.c+8 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH BlueZ v3 0/7] Add TMAP & GMAP information services

Add support for TMAP and GMAP services. They contain only device audio capability bitmasks.

v3:
- rename after_uuids -> after_services + make it a struct
- add tests for btd_profile_sort_list()
- leave it as the GSList version for now, tests use queue
- add commits to mark VCP connected only after its attach has finished

v2:
- Rework the service wait to be general mechanism that also determines the service autoconnect order.

This is now slightly more involved, but this sort of "soft" ordering dependency must know which services the autoconnect mechanism is going to start.

Sorting autoconnect services is one of the ways to do it, probably makes sense also otherwise, and we could insert service conflict handling at the same place.

- Make org.bluez.MediaEndpoint::SupportedFeatures per-uuid dict

---

Expose the values from remote devices in
org.bluez.MediaEndpoint->SupportedFeatures

This maybe could also be org.bluez.Device->SupportedFeatures instead, but MediaEndpoint looks OK too.

Sound server can use theses to determine which mandatory capabilities devices have.

TODO (maybe later): add way to configure advertised local service values, e.g. via config file.

Pauli Virtanen (7):
profile: add after_services for ordering profile startup
test-profile: add tests for profile sorting
device: use after_services in service autoconnect and sort also GATT
service: implement btd_profile::after_services callback
bap: have unicast client wait for VCS & TMAS & GMAP shared/vcp: add ready callback to bt_vcp_attach()
vcp: wait until client ready before marking profile connected

 .gitignore           |   1 +
 Makefile.am          |  22 ++-
 profiles/audio/bap.c |  36 ++++-
 profiles/audio/vcp.c |  11 +-
 src/device.c         |  74 ++++++++--
 src/profile.c        |  90 +++++++++++
 src/profile.h        |  26 ++++
 src/service.c        | 106 +++++++++++++
 src/shared/vcp.c     |  29 +++-
 src/shared/vcp.h     |   3 +-
 unit/btd.c           |  41 ++++++
 unit/test-profile.c  | 344 +++++++++++++++++++++++++++++++++++++++++++
 12 files changed, 758 insertions(+), 25 deletions(-)
 create mode 100644 unit/btd.c
 create mode 100644 unit/test-profile.c
Signature · 1 line
2.51.1